From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60017) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0WKo-0001nR-3T for guix-patches@gnu.org; Mon, 26 Mar 2018 13:55:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f0WKk-0004J3-71 for guix-patches@gnu.org; Mon, 26 Mar 2018 13:55:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:46788) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f0WKk-0004Ix-2O for guix-patches@gnu.org; Mon, 26 Mar 2018 13:55:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f0WKj-0004lY-OZ for guix-patches@gnu.org; Mon, 26 Mar 2018 13:55:01 -0400 Subject: [bug#30925] [PATCH] gnu: Add emacs-puppet-mode. Resent-Message-ID: From: Marius Bakke In-Reply-To: <20180324155920.970-1-mail@cbaines.net> References: <20180324155920.970-1-mail@cbaines.net> Date: Mon, 26 Mar 2018 19:54:05 +0200 Message-ID: <87370mk9j6.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Baines , 30925@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Christopher Baines writes: > * gnu/packages/emacs.scm (emacs-puppet-mode): New variable. [...] =20=20 > +(define-public emacs-puppet-mode > + (let ((commit "b3ed5057166a4f49dfa9be638523a348b55a2fd2") > + (revision "1")) > + (package > + (name "emacs-puppet-mode") > + (version (git-version "0.3" revision commit)) Maybe mention why we can't take the 0.3 tag? > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "https://raw.githubusercontent.com/voxpupuli/puppet-mode/" > + commit "/puppet-mode.el")) It would be nice to install the README too, but no strong opinion. > + (sha256 > + (base32 > + "1indycxawsl0p2aqqg754f6735q3cmah9vd886rpn0ncc3ipi1xm")))) > + (build-system emacs-build-system) > + (home-page "https://github.com/voxpupuli/puppet-mode") > + (synopsis "Emacs major mode for the Puppet configuration language") > + (description > + "This package provides support for the Puppet configuration langu= age, > +including syntax highlighting, indentation of expressions and statements, > +linting of manifests and integration with Puppet Debugger.") > + (license license:gpl3+)))) Perhaps mention in a comment that it includes ASL code, as mentioned in puppet-mode.el. LGTM otherwise. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlq5M70ACgkQoqBt8qM6 VPorcAf9H1dlyH/fV7E2fpvJjKHvVEnlE5dp7rOSJEJAJBTwdcFL9x922rB2d4sv N/tNM6IPS1wcQ3EOQoFg/lPihA6P0RxtwfZP5kNdCqdlR93NB5yiuZ+XoIWZrBrA K6iIsyKGvSARwVZ5wXi2gL5xhd9vV8Oujk/AVgQCicMk2xaylu3NqdL9OqruVDk7 i7ubyPJgoRlOZgvjuGMBYYaReDK4heTfeWYFWJWj6oM7nnk7jnrShztXJa8grxpX 7cwNpcc1utclbZ13HwdYhgp9chiODW7Kuqgc2OziAZ6XCzDCIrcdQTW6W3PbywnT 7uTcma4KXLrCwJxS2Kme2DRhaHVttQ== =23pp -----END PGP SIGNATURE----- --=-=-=--