all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Pierre Neidhardt <ambrevar@gmail.com>
To: Oleg Pykhalov <go.wigust@gmail.com>
Cc: help-guix <help-guix@gnu.org>
Subject: Re: Package request inxi
Date: Thu, 12 Apr 2018 12:54:03 +0530	[thread overview]
Message-ID: <873700hoq4.fsf@gmail.com> (raw)
In-Reply-To: <874lkghp4a.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1517 bytes --]


Going on with the package, I think we only need this patch beside the
shabang adjustment:

	 ## System
	 my ($bsd_type,$language,$os) = ('','','');
	 my ($cpu_sleep,$dl_timeout,$limit,$ps_count,$usb_level) = (0.35,4,10,5,0);
	-my @paths = qw(/sbin /bin /usr/sbin /usr/bin /usr/X11R6/bin /usr/local/sbin /usr/local/bin);
	-$ENV{'PATH'} = 'sbin:/bin:/usr/sbin:/usr/bin:/usr/X11R6/bin:/usr/local/sbin:/usr/local/bin';
	+my @paths = qw(/sbin /bin /run/setuid-programs /run/current-system/profile/bin /run/current-system/profile/sbin);
	+push (@paths, "$ENV{'HOME'}/.guix-profile/bin");
	+push (@paths, "$ENV{'HOME'}/.guix-profile/sbin");
	+$ENV{'PATH'} = '/sbin:/bin:/run/setuid-programs:/run/current-system/profile/bin:/run/current-system/profile/sbin';
	+$ENV{'PATH'} = '$ENV:$ENV{'HOME'}/.guix-profile/bin";
	+$ENV{'PATH'} = '$ENV:$ENV{'HOME'}/.guix-profile/sbin";
	 my $sensors_cpu_nu = 0;

Basically inxi sets a 'paths' variable with the usual Unix paths and
then forces the environment PATH to the same value.

My suggestion instead: set 'paths' to /run/current-system/* and
~/.guix-profile/{sbin,bin}.

What do you think?  Is this generic enough?  Is ~/.guix-profile a
guaranteed location for the user profile?

Last but not least, what's the better approach between
- a patch,
- a substitute,
- a snippet?

I only know very little about Perl so the above code might look very clumsy.

-- 
Pierre Neidhardt

There is very little future in being right when your boss is wrong.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2018-04-12  7:24 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-28 14:02 Package requests: fortune, gifsicle, inxi, uncrustify, unrar, vsftp, xss-lock Pierre Neidhardt
2018-03-28 15:27 ` Package request inxi Oleg Pykhalov
2018-03-28 17:26   ` Pierre Neidhardt
2018-04-11 16:17     ` Pierre Neidhardt
2018-04-11 17:23       ` Oleg Pykhalov
2018-04-11 17:29         ` Pierre Neidhardt
2018-04-11 17:34           ` Pierre Neidhardt
2018-04-11 18:14             ` Oleg Pykhalov
2018-04-12  7:15               ` Pierre Neidhardt
2018-04-12  7:24                 ` Pierre Neidhardt [this message]
2018-04-12  8:53                   ` Chris Marusich
2018-04-12  9:09                     ` Pierre Neidhardt
2018-04-11 17:42           ` Oleg Pykhalov
2018-04-12  5:29             ` Pierre Neidhardt
2018-04-12  8:25       ` Chris Marusich
2018-04-12  8:39         ` Pierre Neidhardt
2018-04-12 17:07           ` inxi and inxi-full Oleg Pykhalov
2018-04-12 17:19             ` Pierre Neidhardt
2018-04-13  3:41               ` Chris Marusich
2018-04-13  4:00                 ` Pierre Neidhardt
2018-04-13  5:11                   ` Chris Marusich
2018-04-13  5:52                     ` Pierre Neidhardt
2018-04-13  6:13                       ` Chris Marusich
2018-04-13  6:24                         ` Pierre Neidhardt
2018-04-14  6:22                           ` Pierre Neidhardt
2018-04-16  6:59                             ` Chris Marusich
2018-04-16  7:16                               ` Pierre Neidhardt
2018-04-16 10:26                               ` gnu: Add inxi (old Shell script version) Oleg Pykhalov
2018-04-16 10:31                                 ` Pierre Neidhardt
2018-03-31  5:15 ` Package requests: fortune, gifsicle, inxi, uncrustify, unrar, vsftp, xss-lock Pierre Neidhardt
2018-04-01 12:15   ` Pierre Neidhardt
2018-04-12 13:04 ` Ricardo Wurmus
2018-04-12 17:00   ` Leo Famulari
2018-04-12 17:13 ` Clément Lassieur
2018-04-12 17:17   ` Pierre Neidhardt
2018-04-12 17:23     ` Marius Bakke
2018-04-12 17:34       ` Pierre Neidhardt
2018-04-12 17:41       ` Clément Lassieur
2018-04-12 17:53         ` Pierre Neidhardt
2018-04-21 19:18     ` File sharing with GNU Guix (was: Re: Package requests: fortune, gifsicle, inxi, uncrustify, unrar, vsftp, xss-lock) Chris Marusich
2018-04-22  5:58       ` Pierre Neidhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=873700hoq4.fsf@gmail.com \
    --to=ambrevar@gmail.com \
    --cc=go.wigust@gmail.com \
    --cc=help-guix@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.