From: Mark H Weaver <mhw@netris.org>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: 31647@debbugs.gnu.org
Subject: bug#31647: [core-updates] gtkglext fails in a weird way
Date: Tue, 29 May 2018 23:56:24 -0400 [thread overview]
Message-ID: <8736y9dcev.fsf@netris.org> (raw)
In-Reply-To: <87a7siqk5m.fsf@mdc-berlin.de> (Ricardo Wurmus's message of "Tue, 29 May 2018 22:30:45 +0200")
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:
>> on “core-updates” the “gtkglext” package fails with an odd error
>> message: […]
>
> It seems that this is not limited to “gtkglext”. This behaviour seems
> to affect any package using “invoke” where the invoked command fails.
>
> Should the build system catch the exception and make sure that it gets
> to print “build phase `foo' failed”?
In my opinion, it's not important for that message to be printed. What
is being printed now is far more informative, and sometimes that extra
information is quite useful.
If we caught exceptions, we'd need to ensure that all of the relevant
information about the exception is printed. The code to catch and print
those exceptions would need to be in (guix build ...), and it could
never be updated without forcing a full rebuild.
'call-with-error-handling' in (guix ui) might be suitable, but it would
need to be duplicated.
Also, even if we catch the exception and do a nice job printing it, we'd
likely lose the backtrace to the original error, which in some cases
might be quite useful.
In summary, although the new messages don't look as nice in common
cases, I think it's more important to ensure that we have the
information we need to debug the occasional non-obvious problem. So, I
think we should leave it alone :)
What do you think?
Mark
next prev parent reply other threads:[~2018-05-30 3:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 18:20 bug#31647: [core-updates] gtkglext fails in a weird way Ricardo Wurmus
2018-05-29 20:30 ` Ricardo Wurmus
2018-05-30 3:56 ` Mark H Weaver [this message]
2018-05-30 6:50 ` Ricardo Wurmus
2018-05-30 8:27 ` Mark H Weaver
2018-05-30 8:43 ` Mark H Weaver
2018-05-31 6:42 ` Ricardo Wurmus
2018-06-03 20:37 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736y9dcev.fsf@netris.org \
--to=mhw@netris.org \
--cc=31647@debbugs.gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.