From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: GSoC: Adding a web interface similar to the Hydra web interface
Date: Tue, 12 Jun 2018 23:52:45 +0200
Message-ID: <8736xrd64y.fsf@elephly.net>
References: <CAMSS15C0nNEPqQKjRt9=-JKFvrGZsKBtMOxju65p_y88EzOZgg@mail.gmail.com>
	<87vac3twbe.fsf@gnu.org> <87o9hog2ye.fsf@elephly.net>
	<CAMSS15CQwypdFafPG1ii-CgMpxYxLtcbx8hHTvDvyBS+6xNSxA@mail.gmail.com>
	<87d0xyn9zs.fsf@elephly.net>
	<CAMSS15CGdzb8=-Oz6z6bmeWjrnT85PL+q7DLUFw-9E4_d4Y6pw@mail.gmail.com>
	<87d0xswvls.fsf@elephly.net>
	<CAMSS15CDGat-pFjiz2vrkvb14qWnY4rbCW-d8KSzY6MO7WzT_g@mail.gmail.com>
	<87r2m4ntk4.fsf@mdc-berlin.de>
	<CAMSS15D42gCV-UneBBJWngdfi-jG4JfWWh6NWhWMiet0Y=bUsg@mail.gmail.com>
	<87tvqxy4i9.fsf@elephly.net>
	<CAMSS15DThnLO+YEVaBmJ9ozMeu4mO1rHAdXHgZ8K+Csu40pORQ@mail.gmail.com>
	<87in78hxo2.fsf@elephly.net> <878t7xb58o.fsf@elephly.net>
	<CAMSS15BgazLcPLR=Wgi4N0N20dbJH++F5g3OmcA07bLkP-+=MQ@mail.gmail.com>
	<874lijbqvf.fsf@elephly.net>
	<CAMSS15CxBzPkKTsuPwtdBvbcXd+ePG2x+7CushRwKbsZE8h_+w@mail.gmail.com>
	<20180606200210.7a9c4dd6@scratchpost.org>
	<CAMSS15AKvAwbogR_-uWMWyr+miKOREP6dOWVMPTAMdGQuqzmjg@mail.gmail.com>
	<20180612183504.2621cefa@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36827)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1fSrE3-0001H1-71
	for guix-devel@gnu.org; Tue, 12 Jun 2018 17:53:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1fSrDz-0001RC-7G
	for guix-devel@gnu.org; Tue, 12 Jun 2018 17:53:15 -0400
Received: from sender-of-o51.zoho.com ([135.84.80.216]:21030)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <rekado@elephly.net>) id 1fSrDy-0001Qh-Ro
	for guix-devel@gnu.org; Tue, 12 Jun 2018 17:53:11 -0400
In-reply-to: <20180612183504.2621cefa@scratchpost.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Tatiana Sholokhova <tanja201396@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>


Hi Tatiana,

I have only little to add to Danny=E2=80=99s comments.

> db-get-builds looks fine and we could merge this change to master.
> But you have other changes in the same commit, so we can't directly
> cherry-pick it.  (not so bad, but somewhat cumbersome now)

It is good practise to make small commits, one for every set of
logically connected changes.  This makes the review simpler and it makes
it easier to merge some parts while leaving others for later.

As you work on the changes that Danny=E2=80=99s comments imply, please take=
 the
opportunity to group related changes and commit only those together.  It
is fine and desirable to have many independent small commits.

Thanks again for your excellent work!

--
Ricardo