From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41942) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fiIsj-0003Bt-NO for guix-patches@gnu.org; Wed, 25 Jul 2018 08:27:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fiIsg-0001GG-Nj for guix-patches@gnu.org; Wed, 25 Jul 2018 08:27:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:51354) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fiIsg-0001Fh-JD for guix-patches@gnu.org; Wed, 25 Jul 2018 08:27:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fiIsg-00036C-AK for guix-patches@gnu.org; Wed, 25 Jul 2018 08:27:02 -0400 Subject: [bug#32165] [PATCH] gnu: Add cdrkit-libre. Resent-Message-ID: From: Oleg Pykhalov References: <20180715170748.4853-1-go.wigust@gmail.com> <87o9ex58pq.fsf@gnu.org> Date: Wed, 25 Jul 2018 15:26:24 +0300 In-Reply-To: <87o9ex58pq.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Tue, 24 Jul 2018 10:38:57 +0200") Message-ID: <8736w7pklr.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 32165@debbugs.gnu.org, Nils Gillmann --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Ludovic and Nils, Thank you for review. ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Oleg Pykhalov skribis: > >> * gnu/packages/cdrom.scm (cdrkit-libre): New variable. > > [...] > >> + (source (origin >> + (method url-fetch) >> + (uri (string-append >> + "https://repo.parabola.nu/other/cdrkit-libre/cdrkit= -libre-" >> + version ".tar.gz")) > > Like Nils I wonder: can you explain how it differs from cdrkit? Could > we use upstream cdrkit + snippet/patches instead of taking the source > from Parabola=E2=80=99s repo? Comparing Nix cdrkit with Parabola cdrkit-libre tarball not much differ. =2D-8<---------------cut here---------------start------------->8--- $ /tmp/local$ diff -r -u cdrkit-1.1.11-nix/ cdrkit-1.1.11-parabola/ Only in cdrkit-1.1.11-nix/doc/genisoimage: README.hfs_boot Only in cdrkit-1.1.11-nix/genisoimage: apple_driver.8 Only in cdrkit-1.1.11-nix/genisoimage: apple_driver.c =2D-8<---------------cut here---------------end--------------->8--- I probably could get a diff for apple_driver.{8,c} files, but the the upstream URI http://cdrkit.org/releases/cdrkit.tar.gz is dead. I'm not sure where is a better place to fetch the release tarball except from another GNU/Linux distribution like Parabola. >> + (build-system cmake-build-system) >> + (native-inputs >> + `(("bzip2" ,bzip2) >> + ("libcap" ,libcap) >> + ("perl" ,perl) >> + ("zlib" ,zlib))) > > It may be that all of these should be =E2=80=98inputs=E2=80=99. Could yo= u check: > > guix gc --references $(guix build cdrkit-libre) =2D-8<---------------cut here---------------start------------->8--- /gnu/store/5whrhayw7kispmd103xc05vmdvsdvhqf-cdrkit-libre-1.1.11 /gnu/store/7ifc22sh86zblnzamqimgmv06idyx69v-perl-5.26.1 /gnu/store/fxiwj2wpp11sif613axdax7gmwzsg6kp-zlib-1.2.11 /gnu/store/l4lr0f5cjd0nbsaaf8b5dmcw1a1yypr3-glibc-2.27 /gnu/store/pxf13xq984jvl2nk12wmsln39a1d8jwc-libcap-2.25 /gnu/store/qhxgdgyiyq2ilvh17fqfw0njpqlg4gsc-file-5.32 /gnu/store/rbrandv7anzjxqkr40d7fkanzssslk4b-bash-minimal-4.4.19 /gnu/store/rw1ilvs76rf2p4p0bi1fx3bffprwwb7g-bzip2-1.0.6 /gnu/store/vla5j7pbkpcp39lsdfsmz7m9azn48lr4-gcc-5.5.0-lib =2D-8<---------------cut here---------------end--------------->8--- > ? If they show up here, then =E2=80=98inputs=E2=80=99. > Sure, I will do =E2=80=98s/native-inputs/inputs/g=E2=80=99. >> + (arguments >> + `(#:tests? #f ;no tests >> + #:phases >> + (modify-phases %standard-phases >> + (add-after 'install 'old-cdrecord >> + (lambda* (#:key outputs #:allow-other-keys) >> + (with-directory-excursion (string-append (assoc-ref output= s "out") >> + "/bin") >> + (symlink "genisoimage" "mkisofs") >> + (symlink "wodim" "cdrecord"))))))) > > Please return #t. Oops, will do. >> + (home-page "http://cdrkit.org/") > > Like Nils wrote, is this the right URL? It's a right URL, I think. I converted recipe from Parabola, which references the same URL [1]. Maybe I should use a Parabola repository URL ? >> + (synopsis "Portable command-line CD/DVD recorder software, mostly >> +compatible with cdrtools") > > =E2=80=9CCommand-line CD/DVD recorder=E2=80=9D is enough IMO. OK. >> + (description "Cdrkit is a suite of programs for recording CDs and D= VDs, >> +blanking CD-RW media, creating ISO-9660 filesystem images, extracting a= udio CD >> +data, and more.") > > Here you can mention that it=E2=80=99s =E2=80=9Cmostly compatible =E2=80= =A6=E2=80=9D. Do you mean =E2=80=9Ccreating more compatible ISO-9660 =E2=80=A6=E2=80=9D? > Note: =E2=80=9Cfile system=E2=80=9D (two words). :-) OK. [1] https://git.parabola.nu/abslibre.git/tree/libre/cdrkit/PKGBUILD Oleg. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAltYbHAACgkQckbhHGm3 lWmJng/+IgF1HHwN8+nYMFztCxZbTUNm9Z91LMuCL5FpJBKSmj+5nhABJxFV+r/H MjSqBHQqLkug8CDcHO4Cg+5ab4pt6UEVhdN1nZFE2OklZZIJKP9u/DO4lhAnK60k SSJUpuCDomwq+EnE15ZA7Wgn2hPBiTfP9Wli7HZE7Va0M7Kj86t0Tla1We+4JRo9 GO4iQjdU8WNz6iMMBUWTo72/fhw2Sj8f8IbjyHzTo9enqBvVi1QP5FkQcjn4Icx5 gYzGg28u169ruwTL/ZroHZDrdd6liPjY/NWUtQvGrGtDig44fsFnR79T3EOQ5nSm zKzPScU/kRHMNd+zuWPph0H4biAhHDZLJT7QQI9IDtjB/ganPScUJm+eyPc3DssU Gpycno6J7KALP0UK62UH/HLDzmJh4qzxG9MPN7HOOyorBYE1/kVGV2YVBrA2qToM 9zXoSP95iswiBYcXwQCmkRljPEv8LfPiJZ2uSquyp8EHv1QWVW0FSmn5Ugg6IG7h rt0np/Fsng3RgF6URrHAfP3iRU7NB2fUW8o+K/b+l/ewYPnqpvlHCLrCiaO2kNVS 6mptBnLSoSdsq13A9fUe8GzKi3ZZVEqqrODuliYLsGRR0ErUp0MYLEnVC4O9eM2r g5ypFJZnClKzNL57kRctLcZIXmGnwwRRl8qrOdYt90LZsuEtbIM= =Y/MV -----END PGP SIGNATURE----- --=-=-=--