From mboxrd@z Thu Jan 1 00:00:00 1970 From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=) Subject: Re: Package for LXQt. Help wanted. Date: Sat, 27 Oct 2018 19:51:52 +0800 Message-ID: <8736sr4nfr.fsf@member.fsf.org> References: <87sh0soi8y.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47270) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gGN8e-0003N5-TG for guix-devel@gnu.org; Sat, 27 Oct 2018 07:52:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gGN8Z-0003pH-GQ for guix-devel@gnu.org; Sat, 27 Oct 2018 07:52:20 -0400 Received: from rezeros.cc ([2001:19f0:7001:2f3e:5400:ff:fe84:e55d]:42294) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gGN8Z-0003l7-0t for guix-devel@gnu.org; Sat, 27 Oct 2018 07:52:15 -0400 List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Meiyo Peng Cc: guix-devel@gnu.org Meiyo Peng writes: > Hello Song, > >> Hello, thank you again, I have push them! > > Thank you. > >> - Add comments about the missing translations (disable the >> PULL_TANSLATIONS), which are in the lxqt-l10n git repository. I think >> we can prefetch it as a 'origin', add it to the input of the >> application, or add a 'lxqt-l10n' package. > > I didn't add lxqt-l10n because it is stated as deprecated on it's home > page. Okay, I see now the repositories (lxqt-about, etc) have their translations checked in, so the next release will have translations files in the tarballs. In the meantime, we could add 'lxqt-l10n' as a package to get translations for those LXQt applications. I tried to build lxqt-l10n, but its CMakeLists.txt can't be used as-is, I'd leave it now... > >> - Correct some licenses, eg: obconf-qt, qps are under GPL2+. > > Sorry about this. I should have been more careful. > >> And a "lxqt-build-tools: Dedifen LXQT_*_DIR variables" patch is >> unapplied: >> >> (build-system cmake-build-system) >> (arguments >> - `(#:tests? #f)) ; no tests >> + `(#:tests? #f ;; no tests >> + #:configure-flags >> + `("-DLXQT_DATA_DIR=/run/current-system/profile/share" >> + "-DLXQT_ETC_XDG_DIR=/run/current-system/profile/etc/xdg"))) >> >> What are thoses variables used for? If I install the 'lxqt' package >> into my user profile, should I set them to the directories under my >> profile ($HOME/.guix-profile/share and $HOME/.guix-profile/etc/xdg)? > > These variables are used by all LXQt packages during build time. But > there is no big issue if they are not defined here, I guess it is > because XDG_*_DIRS environment variables are set correctly during > runtime. They default to directories within > /gnu/store/*-lxqt-build-tools-*/ like this: > "/gnu/store/86wy8q4yplhalf3yvmzv673naarxn3na-lxqt-build-tools-0.5.0/share" > > I defined these variables here to serve an aesthetic purpose, so that > the "Technical Info" tab within lxqt-about can show the values defined > above rather than directories like this: > "/gnu/store/86wy8q4yplhalf3yvmzv673naarxn3na-lxqt-build-tools-0.5.0/share". > Yeah, thanks for the explanation.