From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60073)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gbpqI-0005Y7-PE
	for guix-patches@gnu.org; Tue, 25 Dec 2018 11:46:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gbpqE-00058S-QI
	for guix-patches@gnu.org; Tue, 25 Dec 2018 11:46:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:40776)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gbpqE-000587-LO
	for guix-patches@gnu.org; Tue, 25 Dec 2018 11:46:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gbpqE-00050B-JF
	for guix-patches@gnu.org; Tue, 25 Dec 2018 11:46:02 -0500
Subject: bug#33849: [PATCH] gnu: Add polybar
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.33849.D33849.154575631719162.done@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <87imzkfe3g.fsf@gmail.com> <87zhswgmyo.fsf@gnu.org>
	<878t0f5tii.fsf@gmail.com>
Date: Tue, 25 Dec 2018 17:45:12 +0100
In-Reply-To: <878t0f5tii.fsf@gmail.com> (Meiyo Peng's message of "Mon, 24 Dec
	2018 14:27:33 +0800")
Message-ID: <8736qlftd3.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Meiyo Peng <meiyo.peng@gmail.com>
Cc: 33849-done@debbugs.gnu.org

Hi,

Meiyo Peng <meiyo.peng@gmail.com> skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> writes:
>
>>> +    (source
>>> +     (origin
>>> +       (method url-fetch)
>>> +       (uri (string-append "https://github.com/jaagr/polybar/releases/"
>>> +                           "download/" version "/polybar.tar"))
>>> +       (sha256
>>> +        (base32 "1zpsvh1n77bx7s6mqqh3ba828k9xbp35c2mjmcl9nywfp6r5ldqi"=
))
>>> +       (file-name (string-append name "-" version ".tar"))))
>>
>> Please use =E2=80=98git-fetch=E2=80=99 rather than downloading a generat=
ed tarball (it=E2=80=99s
>> a generated tarball, right?).
>
> No. This is a user uploaded release tarball. You can notice their
> difference. User uploaded tarball has "/releases/download/" in its URL.
>
> #+BEGIN_EXAMPLE
>   User uploaded:  https://github.com/jaagr/polybar/releases/download/3.3.=
0/polybar.tar
>   Auto generated: https://github.com/jaagr/polybar/archive/3.3.0.tar.gz
> #+END_EXAMPLE

Oh right, so that=E2=80=99s OK.

> I tried to use the git-fetch method first, but it failed to build
> because git-fetch doesn't fetch git submodules. Do we support
> recursively fetching git submodules?

Yes, just add (recursive? #t).

>>>From 3faa9dcf77ca83972db6234a9af6b22325ee0311 Mon Sep 17 00:00:00 2001
> From: Meiyo Peng <meiyo.peng@gmail.com>
> Date: Sun, 23 Dec 2018 23:05:38 +0800
> Subject: [PATCH] gnu: Add polybar.
>
> * gnu/packages/wm.scm (polybar): New variable.

Applied, thanks!

Ludo=E2=80=99.