[bug#34046] [PATCH] gnu: qjackctl: Disable xunique.

[bug#34046] [PATCH] gnu: qjackctl: Disable xunique.

[Pierre Langlois]

[-- Attachment #1: Type: text/plain, Size: 396 bytes --]

Hello Guix!

For the past few months I've been unable to use qjackctl, it would
freeze X all together on startup. It seems to happen only in tiling
window manager though. But, it looks like people upstream have found the
problem and disabling xunique fixes it!
See https://github.com/rncbc/qjackctl/issues/13.

The bug mentions qsynth too, I'll check if it has the same problem.

Thanks!
Pierre


[-- Attachment #2: 0001-gnu-qjackctl-Disable-xunique.patch --]
[-- Type: text/x-patch, Size: 1490 bytes --]

From c1ab105660e8572d6711d408a8441d4b51327f25 Mon Sep 17 00:00:00 2001
From: Pierre Langlois <pierre.langlois@gmx.com>
Date: Fri, 11 Jan 2019 20:55:42 +0000
Subject: [PATCH] gnu: qjackctl: Disable xunique.

* gnu/packages/audio.scm (qjackctl)[arguments]: Pass "--disable-xunique" to
configure-flags.
---
 gnu/packages/audio.scm | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index d47dd90f56..c3761db6c3 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -18,6 +18,7 @@
 ;;; Copyright © 2018 Thorsten Wilms <t_w_@freenet.de>
 ;;; Copyright © 2018 Eric Bavier <bavier@member.fsf.org>
 ;;; Copyright © 2018 Brendan Tildesley <brendan.tildesley@openmailbox.org>
+;;; Copyright © 2019 Pierre Langlois <pierre.langlois@gmx.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -2154,7 +2155,11 @@ and ALSA.")
                 "1rzzqa39a6llr52vjkjr0a86nc776kmr5xs52qqga8ms9697psz5"))))
     (build-system gnu-build-system)
     (arguments
-     '(#:tests? #f))                    ; no check target
+     '(#:tests? #f ;; no check target
+       ;; Disable xunique to prevent X hanging when starting qjackctl in
+       ;; tiling window managers such as StumpWM or i3
+       ;; (see https://github.com/rncbc/qjackctl/issues/13).
+       #:configure-flags '("--disable-xunique")))
     (inputs
      `(("jack" ,jack-1)
        ("alsa-lib" ,alsa-lib)
-- 
2.20.1

[bug#34046] [PATCH] gnu: qjackctl: Disable xunique.

[Ludovic Courtès]

Hi Pierre,

Pierre Langlois <pierre.langlois@gmx.com> skribis:

> For the past few months I've been unable to use qjackctl, it would
> freeze X all together on startup. It seems to happen only in tiling
> window manager though. But, it looks like people upstream have found the
> problem and disabling xunique fixes it!
> See https://github.com/rncbc/qjackctl/issues/13.
>
> The bug mentions qsynth too, I'll check if it has the same problem.

It LGTM, but let’s see if Ricardo approves.  :-)

Thanks,
Ludo’.

[bug#34046] [PATCH] gnu: qjackctl: Disable xunique.

[Ricardo Wurmus]

Ludovic Courtès <ludo@gnu.org> writes:

> Hi Pierre,
>
> Pierre Langlois <pierre.langlois@gmx.com> skribis:
>
>> For the past few months I've been unable to use qjackctl, it would
>> freeze X all together on startup. It seems to happen only in tiling
>> window manager though. But, it looks like people upstream have found the
>> problem and disabling xunique fixes it!
>> See https://github.com/rncbc/qjackctl/issues/13.
>>
>> The bug mentions qsynth too, I'll check if it has the same problem.
>
> It LGTM, but let’s see if Ricardo approves.  :-)

This seems okay to me.  This is only about letting qjackctl capture
attempts to start it another time, which isn’t an essential feature.  It
starts jackd in the background and *that* can’t be started more than
once on the same audio device anyway.

--
Ricardo

bug#34046: [PATCH] gnu: qjackctl: Disable xunique.

[Ludovic Courtès]

Hello,

Ricardo Wurmus <rekado@elephly.net> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Hi Pierre,
>>
>> Pierre Langlois <pierre.langlois@gmx.com> skribis:
>>
>>> For the past few months I've been unable to use qjackctl, it would
>>> freeze X all together on startup. It seems to happen only in tiling
>>> window manager though. But, it looks like people upstream have found the
>>> problem and disabling xunique fixes it!
>>> See https://github.com/rncbc/qjackctl/issues/13.
>>>
>>> The bug mentions qsynth too, I'll check if it has the same problem.
>>
>> It LGTM, but let’s see if Ricardo approves.  :-)
>
> This seems okay to me.  This is only about letting qjackctl capture
> attempts to start it another time, which isn’t an essential feature.  It
> starts jackd in the background and *that* can’t be started more than
> once on the same audio device anyway.

Alright, I’ve applied it now.  Thanks!

Ludo’.

[bug#34046] [PATCH] gnu: qjackctl: Disable xunique.

[Pierre Langlois]

Ludovic Courtès writes:

> Hello,
>
> Ricardo Wurmus <rekado@elephly.net> skribis:
>
>> Ludovic Courtès <ludo@gnu.org> writes:
>>
>>> Hi Pierre,
>>>
>>> Pierre Langlois <pierre.langlois@gmx.com> skribis:
>>>
>>>> For the past few months I've been unable to use qjackctl, it would
>>>> freeze X all together on startup. It seems to happen only in tiling
>>>> window manager though. But, it looks like people upstream have found the
>>>> problem and disabling xunique fixes it!
>>>> See https://github.com/rncbc/qjackctl/issues/13.
>>>>
>>>> The bug mentions qsynth too, I'll check if it has the same problem.

By the way, I've installed qsynth and it doesn't hang the system.

>>>
>>> It LGTM, but let’s see if Ricardo approves.  :-)
>>
>> This seems okay to me.  This is only about letting qjackctl capture
>> attempts to start it another time, which isn’t an essential feature.  It
>> starts jackd in the background and *that* can’t be started more than
>> once on the same audio device anyway.
>
> Alright, I’ve applied it now.  Thanks!

Brilliant, thanks!!

Pierre