From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@gnu.org>
Subject: Re: 01/01: gnu: Add hyperledger-fabric.
Date: Sat, 09 Mar 2019 12:01:28 +0100
Message-ID: <8736nwcnw7.fsf@gnu.org>
References: <20190309093458.29587.16437@vcs0.savannah.gnu.org>
	<20190309093500.E8CE62053E@vcs0.savannah.gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:45516)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1h2ZjQ-0005Yh-U9
	for guix-devel@gnu.org; Sat, 09 Mar 2019 06:01:33 -0500
In-Reply-To: <20190309093500.E8CE62053E@vcs0.savannah.gnu.org> (guix-commits's
	message of "Sat, 9 Mar 2019 04:35:00 -0500 (EST)")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: guix-devel@gnu.org, Pierre Neidhardt <mail@ambrevar.xyz>

Hello!

A couple of minor issues:

guix-commits@gnu.org skribis:

> commit 983550692dbf5a41afef1b1cae53fece42b3d4bf
> Author: Pierre Neidhardt <mail@ambrevar.xyz>
> Date:   Thu Feb 21 19:07:09 2019 +0100
>
>     gnu: Add hyperledger-fabric.
>=20=20=20=20=20
>     * gnu/local.mk (hyperledger): New variable.

Really?  :-)

> +         (replace 'build
> +           (lambda _
> +             ;; Only linux-amd64 and linux-ppc64le seem to be supported =
at the moment.
> +             (invoke "make" "-C" "src/github.com/hyperledger/fabric"
> +                     "release/linux-amd64")))

I don=E2=80=99t know how much of a difference it makes in this case but it =
might
be worth considering passing =E2=80=9C-j=E2=80=9D (number->string (parallel=
-job-count)).

> +                 (copy-recursively
> +                  "release/linux-amd64/bin"

Is this really limited to x86_64-linux?  If so, please add a
=E2=80=98supported-systems=E2=80=99 field.

Then again, this =E2=80=9Clinux-amd64=E2=80=9D thing looks worrying: can yo=
u confirm the
checkout doesn=E2=80=99t contain pre-built binaries?

> +    (synopsis "Platform for distributed ledger solutions")
> +    (description "A platform for distributed ledger solutions, underpinn=
ed by
> +a modular architecture delivering high degrees of confidentiality, resil=
iency,
> +flexibility and scalability.")

Please turn the description into a sentence, and ideally something less
marketing-ish.  :-)

Thanks,
Ludo=E2=80=99.