From: "Ludovic Courtès" <ludo@gnu.org>
To: guix-devel@gnu.org, Pierre Neidhardt <mail@ambrevar.xyz>
Subject: Re: 01/01: gnu: Add hyperledger-fabric.
Date: Sat, 09 Mar 2019 12:01:28 +0100 [thread overview]
Message-ID: <8736nwcnw7.fsf@gnu.org> (raw)
In-Reply-To: <20190309093500.E8CE62053E@vcs0.savannah.gnu.org> (guix-commits's message of "Sat, 9 Mar 2019 04:35:00 -0500 (EST)")
Hello!
A couple of minor issues:
guix-commits@gnu.org skribis:
> commit 983550692dbf5a41afef1b1cae53fece42b3d4bf
> Author: Pierre Neidhardt <mail@ambrevar.xyz>
> Date: Thu Feb 21 19:07:09 2019 +0100
>
> gnu: Add hyperledger-fabric.
>
> * gnu/local.mk (hyperledger): New variable.
Really? :-)
> + (replace 'build
> + (lambda _
> + ;; Only linux-amd64 and linux-ppc64le seem to be supported at the moment.
> + (invoke "make" "-C" "src/github.com/hyperledger/fabric"
> + "release/linux-amd64")))
I don’t know how much of a difference it makes in this case but it might
be worth considering passing “-j” (number->string (parallel-job-count)).
> + (copy-recursively
> + "release/linux-amd64/bin"
Is this really limited to x86_64-linux? If so, please add a
‘supported-systems’ field.
Then again, this “linux-amd64” thing looks worrying: can you confirm the
checkout doesn’t contain pre-built binaries?
> + (synopsis "Platform for distributed ledger solutions")
> + (description "A platform for distributed ledger solutions, underpinned by
> +a modular architecture delivering high degrees of confidentiality, resiliency,
> +flexibility and scalability.")
Please turn the description into a sentence, and ideally something less
marketing-ish. :-)
Thanks,
Ludo’.
next parent reply other threads:[~2019-03-09 11:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190309093458.29587.16437@vcs0.savannah.gnu.org>
[not found] ` <20190309093500.E8CE62053E@vcs0.savannah.gnu.org>
2019-03-09 11:01 ` Ludovic Courtès [this message]
2019-03-09 11:19 ` 01/01: gnu: Add hyperledger-fabric Pierre Neidhardt
2019-03-09 21:35 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736nwcnw7.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=mail@ambrevar.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.