From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:58453) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvoqN-0003Mj-18 for guix-patches@gnu.org; Thu, 08 Aug 2019 16:17:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hvoqM-0003d1-6t for guix-patches@gnu.org; Thu, 08 Aug 2019 16:17:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:32927) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hvoqM-0003cq-3S for guix-patches@gnu.org; Thu, 08 Aug 2019 16:17:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hvoqL-0003q1-Tv for guix-patches@gnu.org; Thu, 08 Aug 2019 16:17:01 -0400 Subject: [bug#36952] [PATCH v2] machine: Implement 'roll-back-machine'. Resent-Message-ID: From: zerodaysfordays@sdf.lonestar.org (Jakob L. Kreuze) References: <87v9v94067.fsf@sdf.lonestar.org> <87v9v8ohvq.fsf@dustycloud.org> <87v9v8k82l.fsf_-_@sdf.lonestar.org> <87v9v8vskt.fsf@elephly.net> Date: Thu, 08 Aug 2019 16:16:35 -0400 In-Reply-To: <87v9v8vskt.fsf@elephly.net> (Ricardo Wurmus's message of "Thu, 08 Aug 2019 12:50:58 +0200") Message-ID: <8736ibl8f0.fsf@sdf.lonestar.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ricardo Wurmus Cc: 36952@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ricardo, Ricardo Wurmus writes: > Can we use =E2=80=9Crelative-generation=E2=80=9D or =E2=80=9Cprevious-gen= eration-number=E2=80=9D here? > I think the stringified =E2=80=9C-1=E2=80=9D is kinda ugly, and the =E2= =80=9C*-spec=E2=80=9D procedure > only exists to handle user input, which is provided as a string. Oh yeah, definitely. I used '*-spec' here because I was using 'guix system' as a model -- didn't know it was meant for handling user input. > Is it on purpose that you aren=E2=80=99t using the previously defined =E2= =80=9Ceval=E2=80=9D > here? Whoops! Unused variable, nice catch! Thanks for the review! Regards, Jakob --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEa1VJLOiXAjQ2BGSm9Qb9Fp2P2VoFAl1MgyYACgkQ9Qb9Fp2P 2VoWXQ/8CJlZvp/+Ve8hhYmibgzwwNrvB3OgAWXN1iedFYMztGIXZdCS8s777oUR IxGsFVV/b2jiENT14oi5z3/Q0QY2phQkBxI28GnghpNI3fuz3a+k8UuueS4KWshJ QJCEPgicVKft33TIf62yRSaincFpdoOOSt+PCzs8al9Bzim1X41kumntX1wkhzqG 8pcr+zjUPuAewHAEUhn5eiKAGo+psXMtDX862w8gahi54Do7ehdcJdZ181k5Rjsj 1lIHrz62cj5sDYTkH0cDl0R1910UUWmkYpFIb/1O4kB9bNou27VBhGZVP7kew9Wf CaBUwGf1Y+D+JPEsGuxBrw+EsKpiWEF64tssTmaOi6rrCFiGC11BzSBofnjLa+Ll XZIf0NMpiPLPQngl8VaBDz/iIjWOBBOx3wbHGVccxhxSE/Npdxfb3U7MamGTbpce 8mNdB3htvhG0+ViIUmtMgqG2p+xPkRVcSufmrvWfQ5ZjQLKfCwcMCR/9CWD4LTxF NkidWf7X+48y+O2hcb8VRrx8Vzf2ouJlAfI5nK+YhusnqqcyLKhifN+5km5Ea5zm ujzSNf4vTEqJqs37NIM3ISQFwa/Mxfun3gUrfdUEgtbCPqglgIDwJP9pxWVZVPAo xWrLFqTZt2NpKf7VVSbUj9M+rBq4HMfVU0e/BA4iFCnmyYd6rbU= =nRgv -----END PGP SIGNATURE----- --=-=-=--