all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: zerodaysfordays@sdf.lonestar.org (Jakob L. Kreuze)
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 36952@debbugs.gnu.org
Subject: [bug#36952] [PATCH v2] machine: Implement 'roll-back-machine'.
Date: Thu, 08 Aug 2019 16:16:35 -0400	[thread overview]
Message-ID: <8736ibl8f0.fsf@sdf.lonestar.org> (raw)
In-Reply-To: <87v9v8vskt.fsf@elephly.net> (Ricardo Wurmus's message of "Thu, 08 Aug 2019 12:50:58 +0200")

[-- Attachment #1: Type: text/plain, Size: 612 bytes --]

Hi Ricardo,

Ricardo Wurmus <rekado@elephly.net> writes:

> Can we use “relative-generation” or “previous-generation-number” here?
> I think the stringified “-1” is kinda ugly, and the “*-spec” procedure
> only exists to handle user input, which is provided as a string.

Oh yeah, definitely. I used '*-spec' here because I was using 'guix
system' as a model -- didn't know it was meant for handling user input.

> Is it on purpose that you aren’t using the previously defined “eval”
> here?

Whoops! Unused variable, nice catch!

Thanks for the review!

Regards,
Jakob

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2019-08-08 20:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-07 12:42 [bug#36952] [PATCH] machine: Implement 'roll-back-machine' Jakob L. Kreuze
2019-08-07 20:11 ` Christopher Lemmer Webber
2019-08-07 20:57   ` [bug#36952] [PATCH v2] " Jakob L. Kreuze
2019-08-07 22:33     ` Christopher Lemmer Webber
2019-08-08 10:50     ` Ricardo Wurmus
2019-08-08 20:16       ` Jakob L. Kreuze [this message]
2019-08-08 20:17       ` [bug#36952] [PATCH v3] " Jakob L. Kreuze
2019-08-14 20:49 ` [bug#36952] [PATCH] " Christopher Lemmer Webber
2019-08-15 11:45   ` bug#36952: " Christopher Lemmer Webber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8736ibl8f0.fsf@sdf.lonestar.org \
    --to=zerodaysfordays@sdf.lonestar.org \
    --cc=36952@debbugs.gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.