[bug#34699] [PATCH] gnu: add emacs-smart-hungry-delete.

[bug#34699] [PATCH] gnu: add emacs-smart-hungry-delete.

[Nicolò Balzarotti]

---
 gnu/packages/emacs-xyz.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index decab4f292..4f645dc695 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1231,7 +1231,39 @@ or XEmacs.")
 a set of simplified face specifications and a user-supplied color palette")
     (license license:gpl3+)))
 
+(define-public emacs-smart-hungry-delete
+  (package
+    (name "emacs-smart-hungry-delete")
+    (version "20170412.1343")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://melpa.org/packages/smart-hungry-delete-"
+             version
+             ".el"))
+       (sha256
+        (base32
+         "0x1jbzs54fcngj0ldhqsnjdn91mfywhm83dl4y9547lm1js6diy5"))))
+    (build-system emacs-build-system)
+    (home-page
+     "https://github.com/hrehfeld/emacs-smart-hungry-delete")
+    (synopsis "smart hungry deletion of whitespace")
+    (description
+     "Hungrily deletes whitespace between cursor and next word, paren or
+delimiter while honoring some rules about where space should be
+left to separate words and parentheses.
+
+Usage:
+
+with use-package:
+
+(use-package smart-hungry-delete
+  :bind ((\"<backspace>\" . smart-hungry-delete-backward-char)
+\t\t (\"C-d\" . smart-hungry-delete-forward-char)))
+")
+    (license license:gpl2+)))
+
 (define-public emacs-howm
   (package
     (name "emacs-howm")
--
2.20.1

[bug#34698] [PATCH] gnu: add org-noter.

[Nicolò Balzarotti]

---
 gnu/packages/emacs-xyz.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 871721af3a..decab4f292 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -9285,6 +9285,38 @@ timestamps and date-time format strings library for Emacs.")
        "This package creates Graphviz directed graphs from Org files.")
       (license license:gpl3+))))
 
+(define-public emacs-org-noter
+  (package
+    (name "emacs-org-noter")
+    (version "1.3.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://stable.melpa.org/packages/org-noter-"
+             version
+             ".el"))
+       (sha256
+        (base32
+         "1hczwva73gsyanl1ldhdvql01gy0hy2g861yzkaklyb763sx58x4"))))
+    (build-system emacs-build-system)
+    (propagated-inputs `(("emacs-org" ,emacs-org)))
+    (home-page
+     "https://github.com/weirdNox/org-noter")
+    (synopsis
+     "A synchronized, Org-mode, document annotator")
+    (description
+     "The idea is to let you create notes that are kept in sync when you scroll through the
+document, but that are external to it - the notes themselves live in an Org-mode file. As
+such, this leverages the power of Org-mode (the notes may have outlines, latex fragments,
+babel, etc...) while acting like notes that are made /in/ the document.
+
+Also, I must thank Sebastian for the original idea and inspiration!
+Link to the original Interleave package:
+https://github.com/rudolfochrist/interleave
+")
+    (license license:gpl3)))
+
 (define-public emacs-npm-mode
   (package
     (name "emacs-npm-mode")
-- 
2.20.1

[bug#34698] [PATCH] gnu: add org-noter.

[Ludovic Courtès]

Hello,

Nicolò Balzarotti <anothersms@gmail.com> skribis:

> ---
>  gnu/packages/emacs-xyz.scm | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)

Could you add a commit log that follows our conventions?

> +       (method url-fetch)
> +       (uri (string-append
> +             "https://stable.melpa.org/packages/org-noter-"
> +             version
> +             ".el"))

Since files on MELPA are unversioned and regularly modified in place,
could you instead use the upstream URL (presumably the GitHub repo)?

> +    (synopsis
> +     "A synchronized, Org-mode, document annotator")
         ^
‘guix lint’ probably complains about this; please remove the “A”.

> +    (description
> +     "The idea is to let you create notes that are kept in sync when you scroll through the
> +document, but that are external to it - the notes themselves live in an Org-mode file. As
> +such, this leverages the power of Org-mode (the notes may have outlines, latex fragments,
> +babel, etc...) while acting like notes that are made /in/ the document.
> +
> +Also, I must thank Sebastian for the original idea and inspiration!
> +Link to the original Interleave package:
> +https://github.com/rudolfochrist/interleave

Please change the description to describe the package contents from the
viewpoint of an outsider.  See the guidelines at
<https://www.gnu.org/software/guix/manual/en/html_node/Synopses-and-Descriptions.html>.

> +    (license license:gpl3)))

The source file header explicitly says “or any later version”, so it
should be ‘license:gpl3+’.

Could you send an updated patch?

Thank you,
Ludo’.

bug#34698: [PATCH] gnu: add org-noter.

[Brett Gilio]

Ludovic Courtès <ludo@gnu.org> writes:

> Hello,
>
> Nicolò Balzarotti <anothersms@gmail.com> skribis:
>
>> ---
>>  gnu/packages/emacs-xyz.scm | 32 ++++++++++++++++++++++++++++++++
>>  1 file changed, 32 insertions(+)
>
> Could you add a commit log that follows our conventions?
>
>> +       (method url-fetch)
>> +       (uri (string-append
>> +             "https://stable.melpa.org/packages/org-noter-"
>> +             version
>> +             ".el"))
>
> Since files on MELPA are unversioned and regularly modified in place,
> could you instead use the upstream URL (presumably the GitHub repo)?
>
>> +    (synopsis
>> +     "A synchronized, Org-mode, document annotator")
>          ^
> ‘guix lint’ probably complains about this; please remove the “A”.
>
>> +    (description
>> +     "The idea is to let you create notes that are kept in sync when you scroll through the
>> +document, but that are external to it - the notes themselves live in an Org-mode file. As
>> +such, this leverages the power of Org-mode (the notes may have outlines, latex fragments,
>> +babel, etc...) while acting like notes that are made /in/ the document.
>> +
>> +Also, I must thank Sebastian for the original idea and inspiration!
>> +Link to the original Interleave package:
>> +https://github.com/rudolfochrist/interleave
>
> Please change the description to describe the package contents from the
> viewpoint of an outsider.  See the guidelines at
> <https://www.gnu.org/software/guix/manual/en/html_node/Synopses-and-Descriptions.html>.
>
>> +    (license license:gpl3)))
>
> The source file header explicitly says “or any later version”, so it
> should be ‘license:gpl3+’.
>
> Could you send an updated patch?
>
> Thank you,
> Ludo’.
>
>
>
>

Hi Ludo' and Nicolò,

Closing this as it was added in commit
576cb396eac4e8cea2b54d96382f8e77f3584e89 on 2019-06-13.

Thanks!

-- 
Brett M. Gilio
Homepage -- https://scm.pw/
GNU Guix -- https://guix.gnu.org/

[bug#34697] [PATCH] gnu: add r-lintr.

[Nicolò Balzarotti]

---
 gnu/packages/cran.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index f3bd3ded8d..a9b775f67e 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -10726,3 +10726,34 @@ using @code{S3}.")
     (description
      "This package provides a friendly interface for the construction of regular expressions.")
     (license license:expat)))
+
+(define-public r-lintr
+  (package
+    (name "r-lintr")
+    (version "1.0.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (cran-uri "lintr" version))
+       (sha256
+        (base32
+         "0vlsgq13g2ddv3wqcxaaf7yki9yjj3j1agkh91vqlvbi90i6s8mx"))))
+    (build-system r-build-system)
+    (propagated-inputs
+     `(("r-codetools" ,r-codetools)
+       ("r-crayon" ,r-crayon)
+       ("r-digest" ,r-digest)
+       ("r-httr" ,r-httr)
+       ("r-igraph" ,r-igraph)
+       ("r-jsonlite" ,r-jsonlite)
+       ("r-knitr" ,r-knitr)
+       ("r-rex" ,r-rex)
+       ("r-rstudioapi" ,r-rstudioapi)
+       ("r-stringdist" ,r-stringdist)
+       ("r-testthat" ,r-testthat)))
+    (home-page "https://github.com/jimhester/lintr")
+    (synopsis "A 'Linter' for R Code")
+    (description
+     "Checks adherence to a given style, syntax errors and possible semantic issues.  Supports on the fly checking of R code edited with 'RStudio IDE', 'Emacs', 'Vim', 'Sublime Text' and 'Atom'.")
+    (license license:expat)))
+
-- 
2.20.1

[bug#34697] [PATCH] gnu: add r-lintr.

[Ricardo Wurmus]

Hi Nicolò,

thank you for this patch.

Unfortunately, there are a couple of problems with the synopsis and the
description.  “./pre-inst-env guix lint r-lintr” will tell you about
some of the issues.  For R packages in particular please make sure that
single straight quotes as in “'RStudio'” are removed.

Please also review the Contributing section in the Guix manual for
information on what should appear in the commit message.

Could you please send an updated patch as a reply to this message?

Thanks!

--
Ricardo

[bug#34697] [PATCH 1/3] gnu: Add r-xmlparsedata.

[Nicolò Balzarotti]

* gnu/packages/cran.scm (r-xmlparsedata): New variable.
---
 gnu/packages/cran.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index 11d254001f..0a878dc340 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -14695,6 +14695,29 @@ they are often difficult to interpret.  Rex allows you to build complex
 regular expressions from human readable expressions")
     (license license:expat)))
 
+(define-public r-xmlparsedata
+  (package
+    (name "r-xmlparsedata")
+    (version "1.0.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (cran-uri "xmlparsedata" version))
+       (sha256
+        (base32
+         "0gjr3l5z5dp276lchr2649as1rkj56d2mlvbr66yg393zzw50lsh"))))
+    (properties `((upstream-name . "xmlparsedata")))
+    (build-system r-build-system)
+    (home-page
+     "https://github.com/r-lib/xmlparsedata#readme")
+    (synopsis
+     "Parse Data of @code{R} Code as an @code{XML} Tree")
+    (description
+     "Convert the output of @code{utils::getParseData()} to an @code{XML}
+tree, that one can search via @code{XPath}, and easier to manipulate in
+general.")
+    (license license:expat)))
+
 (define-public r-sctransform
   (package
     (name "r-sctransform")
-- 
2.24.0

[bug#34697] [PATCH 3/3] gnu: Add r-lintr.

[Nicolò Balzarotti]

* gnu/packages/cran.scm (r-lintr): New variable.
---
 gnu/packages/cran.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index 9ff1dd3104..07432c2785 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -14747,6 +14747,40 @@ number of linearly independent paths through a program's source code.  It was
 developed by @cite{Thomas J. McCabe, Sr. in 1976}.")
     (license license:expat)))
 
+(define-public r-lintr
+  (package
+    (name "r-lintr")
+    (version "2.0.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (cran-uri "lintr" version))
+       (sha256
+        (base32
+         "09gbci4v5n4gsfzminly8332fw7faxdi1kkyvpa10dydx02sjcwb"))))
+    (properties `((upstream-name . "lintr")))
+    (build-system r-build-system)
+    (propagated-inputs
+     `(("r-codetools" ,r-codetools)
+       ("r-crayon" ,r-crayon)
+       ("r-cyclocomp" ,r-cyclocomp)
+       ("r-digest" ,r-digest)
+       ("r-httr" ,r-httr)
+       ("r-jsonlite" ,r-jsonlite)
+       ("r-knitr" ,r-knitr)
+       ("r-rex" ,r-rex)
+       ("r-rstudioapi" ,r-rstudioapi)
+       ("r-stringdist" ,r-stringdist)
+       ("r-testthat" ,r-testthat)
+       ("r-xml2" ,r-xml2)
+       ("r-xmlparsedata" ,r-xmlparsedata)))
+    (home-page "https://github.com/jimhester/lintr")
+    (synopsis "Linter for R Code")
+    (description "Checks adherence to a given style, syntax errors and
+possible semantic issues.  Supports on the fly checking of R code edited with
+@code{RStudio IDE}, @code{Emacs} and @code{Vim}.")
+    (license license:expat)))
+
 (define-public r-sctransform
   (package
     (name "r-sctransform")
-- 
2.24.0

bug#34697: [PATCH 3/3] gnu: Add r-lintr.

[Ricardo Wurmus]

Nicolò Balzarotti <anothersms@gmail.com> writes:

> * gnu/packages/cran.scm (r-lintr): New variable.

I pushed these three patches with minor changes.

Thanks!

-- 
Ricardo

[bug#34697] [PATCH 2/3] gnu: Add r-cyclocomp.

[Nicolò Balzarotti]

* gnu/packages/cran.scm (r-cyclocomp): New variable.
---
 gnu/packages/cran.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index 0a878dc340..9ff1dd3104 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -14718,6 +14718,35 @@ tree, that one can search via @code{XPath}, and easier to manipulate in
 general.")
     (license license:expat)))
 
+(define-public r-cyclocomp
+  (package
+    (name "r-cyclocomp")
+    (version "1.1.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (cran-uri "cyclocomp" version))
+       (sha256
+        (base32
+         "0gky3svk02wiajw7nfjh30684h3qxili4bvsab0m7b6cggw6bgyd"))))
+    (properties `((upstream-name . "cyclocomp")))
+    (build-system r-build-system)
+    (propagated-inputs
+     `(("r-callr" ,r-callr)
+       ("r-crayon" ,r-crayon)
+       ("r-desc" ,r-desc)
+       ("r-remotes" ,r-remotes)
+       ("r-withr" ,r-withr)))
+    (home-page
+     "https://github.com/MangoTheCat/cyclocomp")
+    (synopsis "Cyclomatic Complexity of R Code")
+    (description
+     "Cyclomatic complexity is a software metric (measurement), used to
+indicate the complexity of a program.  It is a quantitative measure of the
+number of linearly independent paths through a program's source code.  It was
+developed by @cite{Thomas J. McCabe, Sr. in 1976}.")
+    (license license:expat)))
+
 (define-public r-sctransform
   (package
     (name "r-sctransform")
-- 
2.24.0

[bug#34696] [PATCH] gnu: add r-rematch2.

[Nicolò Balzarotti]

---
 gnu/packages/cran.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index a9b775f67e..6ab5ecc8da 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -10757,3 +10757,23 @@ using @code{S3}.")
      "Checks adherence to a given style, syntax errors and possible semantic issues.  Supports on the fly checking of R code edited with 'RStudio IDE', 'Emacs', 'Vim', 'Sublime Text' and 'Atom'.")
     (license license:expat)))
 
+(define-public r-rematch2
+  (package
+    (name "r-rematch2")
+    (version "2.0.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (cran-uri "rematch2" version))
+       (sha256
+        (base32
+         "16k0i5p7fa3qfxv59ijyn638wpz8n4jrkrnilqmh5g9l8f8bn4h6"))))
+    (build-system r-build-system)
+    (propagated-inputs `(("r-tibble" ,r-tibble)))
+    (home-page
+     "https://github.com/r-lib/rematch2#readme")
+    (synopsis
+     "Tidy Output from Regular Expression Matching")
+    (description
+     "Wrappers on 'regexpr' and 'gregexpr' to return the match results in tidy data frames.")
+    (license license:expat)))
-- 
2.20.1

bug#34696: [PATCH] gnu: add r-rematch2.

[Ricardo Wurmus]

Hi Nicolò,

thank you for this patch.  I applied it with
100f56024e72ad5effff340d34cd7a91a34a830a after a few changes:

- the description now contains full sentences
- 'regexpr' and 'gregexpr' have been wrapped in @code{}
- I added a proper commit message (with the “add” Yasnippet in Emacs)
- I added a copyright line for you
- the words in the synopsis are now lowercase
- I removed the #readme tag from the home-page field
- adjusted the indentation

Thanks!

--
Ricardo

[bug#34695] [PATCH] gnu: add r-rex.

[Nicolò Balzarotti]

---
 gnu/packages/cran.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index 111152d2d0..f3bd3ded8d 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -10705,3 +10705,24 @@ functions are provided.")
 help you to better understand object oriented programming in R, particularly
 using @code{S3}.")
     (license license:gpl3)))
+
+(define-public r-rex
+  (package
+    (name "r-rex")
+    (version "1.1.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (cran-uri "rex" version))
+       (sha256
+        (base32
+         "0alsadgjgass3wr8y5d247j12qqzg454sc84vpskclrkmz778g5x"))))
+    (build-system r-build-system)
+    (propagated-inputs
+     `(("r-lazyeval" ,r-lazyeval)
+       ("r-magrittr" ,r-magrittr)))
+    (home-page "https://github.com/kevinushey/rex")
+    (synopsis "Friendly Regular Expressions")
+    (description
+     "This package provides a friendly interface for the construction of regular expressions.")
+    (license license:expat)))
-- 
2.20.1

bug#34695: [PATCH] gnu: add r-rex.

[Ricardo Wurmus]

Hi Nicolò,

> ---
>  gnu/packages/cran.scm | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>
> diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
> index 111152d2d0..f3bd3ded8d 100644
> --- a/gnu/packages/cran.scm
> +++ b/gnu/packages/cran.scm
> @@ -10705,3 +10705,24 @@ functions are provided.")
>  help you to better understand object oriented programming in R, particularly
>  using @code{S3}.")
>      (license license:gpl3)))
> +
> +(define-public r-rex […]

Sorry for the delay.  I updated the commit message and the description
and pushed this to the master branch with commit 296ea15cf3.

Thanks!

-- 
Ricardo

[bug#34692] [PATCH] gnu: add r-statcheck.

[Nicolò Balzarotti]

---
 gnu/packages/cran.scm | 38 +++++++++++++++++++++++++++++++-------
 1 file changed, 31 insertions(+), 7 deletions(-)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index 54031fa87a..111152d2d0 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -3736,19 +3736,43 @@ published results; and a routine for graphical display.")
 supports arbitrary vertex/edge/graph attributes.")
     (license license:gpl2+)))
 
+(define-public r-statcheck
+  (package
+    (name "r-statcheck")
+    (version "1.3.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (cran-uri "statcheck" version))
+       (sha256
+        (base32
+         "0ivybdcrymlsfv6pg6p5bv70qdvgxf2vgp0kf4r0pf2fcvav1mcp"))))
+    (build-system r-build-system)
+    (propagated-inputs
+     `(("r-ggplot2" ,r-ggplot2)
+       ("r-plyr" ,r-plyr)
+       ("r-rmarkdown" ,r-rmarkdown)))
+    (home-page
+     "https://cran.r-project.org/web/packages/statcheck")
+    (synopsis
+     "Extract Statistics from Articles and Recompute p Values")
+    (description
+     "Extract statistics from articles and recompute p values.")
+    (license license:gpl2)))
+
 (define-public r-statnet-common
   (package
     (name "r-statnet-common")
     (version "4.2.0")
     (source
-      (origin
-        (method url-fetch)
-        (uri (cran-uri "statnet.common" version))
-        (sha256
-          (base32
-            "0q942g6kqmqxfss1cxb3yg8y5r1k1h5cyy99s1cfisrn6hqc6xhi"))))
+     (origin
+       (method url-fetch)
+       (uri (cran-uri "statnet.common" version))
+       (sha256
+        (base32
+         "0q942g6kqmqxfss1cxb3yg8y5r1k1h5cyy99s1cfisrn6hqc6xhi"))))
     (properties
-      `((upstream-name . "statnet.common")))
+     `((upstream-name . "statnet.common")))
     (build-system r-build-system)
     (propagated-inputs
      `(("r-coda" ,r-coda)))
-- 
2.20.1

[bug#34692] [PATCH] gnu: add r-statcheck.

[Ricardo Wurmus]

Hi Nicolò,

thanks for your patches.

Unfortunately, this patch includes unrelated changes (to
r-statnet-common) and does not have a proper commit summary.  The
changes adding r-statcheck lack a proper description (you should use
full sentences).

Would you like to send another patch addressing these issues?

Please also send related patches to the same bug number.  You can do
this by sending a cover letter to guix-patches@gnu.org, wait for the
acknowledgement, and then send the patches to the address mentioned in
the acknowledgement email.  This makes it easier for us to see in what
order related patches need to be applied.

Thanks!

--
Ricardo

[bug#34692] [PATCH] gnu: add r-statcheck.

[Ludovic Courtès]

Hi Nicolò,

Ricardo Wurmus <rekado@elephly.net> skribis:

> Unfortunately, this patch includes unrelated changes (to
> r-statnet-common) and does not have a proper commit summary.  The
> changes adding r-statcheck lack a proper description (you should use
> full sentences).
>
> Would you like to send another patch addressing these issues?

Did you have a chance to look into that, Nicolò?

Thanks in advance!

Ludo’.

[bug#34692] [PATCH] gnu: add r-statcheck.

[Nicolò Balzarotti]

[-- Attachment #1: Type: text/plain, Size: 616 bytes --]

Hi, sorry for the delay!
I'll try to have a look tomorrow :)

Nicolò

Il giorno sabato 23 marzo 2019, Ludovic Courtès <ludo@gnu.org> ha scritto:
> Hi Nicolò,
>
> Ricardo Wurmus <rekado@elephly.net> skribis:
>
>> Unfortunately, this patch includes unrelated changes (to
>> r-statnet-common) and does not have a proper commit summary.  The
>> changes adding r-statcheck lack a proper description (you should use
>> full sentences).
>>
>> Would you like to send another patch addressing these issues?
>
> Did you have a chance to look into that, Nicolò?
>
> Thanks in advance!
>
> Ludo’.
>

[-- Attachment #2: Type: text/html, Size: 820 bytes --]

[bug#34692] [PATCH] gnu: add r-statcheck.

[Nicolò Balzarotti]

[-- Attachment #1: Type: text/plain, Size: 873 bytes --]

Nicolò Balzarotti <anothersms@gmail.com> writes:

> Hi, sorry for the delay!
> I'll try to have a look tomorrow :)
>
> Nicolò
>
> Il giorno sabato 23 marzo 2019, Ludovic Courtès <ludo@gnu.org> ha scritto:
>> Hi Nicolò,
>>
>> Ricardo Wurmus <rekado@elephly.net> skribis:
>>
>>> Unfortunately, this patch includes unrelated changes (to
>>> r-statnet-common) and does not have a proper commit summary.  The
>>> changes adding r-statcheck lack a proper description (you should use
>>> full sentences).
>>>
>>> Would you like to send another patch addressing these issues?
>>
>> Did you have a chance to look into that, Nicolò?
>>
>> Thanks in advance!
>>
>> Ludo’.
>>

I have to admit, today is not March 24th, but finally here's the updated
patch (no new versions have been released since btw).

Sorry for the delay and thanks!
Nicolò


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-r-statcheck.patch --]
[-- Type: text/x-patch, Size: 1585 bytes --]

From 381ae9f063242b5740d5842b3fd515175a634a45 Mon Sep 17 00:00:00 2001
From: nixo <nicolo@nixo.xyz>
Date: Wed, 11 Dec 2019 09:51:30 +0100
Subject: [PATCH] gnu: Add r-statcheck.

* gnu/packages/cran.scm (r-statcheck): New variable.
---
 gnu/packages/cran.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index 11d254001f..a8605221c3 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -4168,6 +4168,31 @@ supports arbitrary vertex/edge/graph attributes.")
 software developed by the Statnet Project.")
     (license license:gpl3)))
 
+(define-public r-statcheck
+  (package
+    (name "r-statcheck")
+    (version "1.3.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (cran-uri "statcheck" version))
+       (sha256
+        (base32
+         "0ivybdcrymlsfv6pg6p5bv70qdvgxf2vgp0kf4r0pf2fcvav1mcp"))))
+    (build-system r-build-system)
+    (propagated-inputs
+     `(("r-ggplot2" ,r-ggplot2)
+       ("r-plyr" ,r-plyr)
+       ("r-rmarkdown" ,r-rmarkdown)))
+    (home-page
+     "https://cran.r-project.org/web/packages/statcheck")
+    (synopsis "Extract statistics from articles and recompute p-values")
+    (description "This package can automatically extract statistical null-hypothesis
+significant testing (NHST) results from articles and recompute the p-values
+based on the reported test statistic and degrees of freedom to detect possible
+inconsistencies.")
+    (license license:gpl2)))
+
 (define-public r-sna
   (package
     (name "r-sna")
-- 
2.24.0

bug#34692: [PATCH] gnu: add r-statcheck.

[Ricardo Wurmus]

Nicolò Balzarotti <anothersms@gmail.com> writes:

> I have to admit, today is not March 24th, but finally here's the updated
> patch (no new versions have been released since btw).

Excellent, thank you!  I have applied it (after reflowing the
description with M-q).

-- 
Ricardo

[bug#34694] [PATCH] gnu: add r-styler.

[Nicolò Balzarotti]

---
 gnu/packages/cran.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index 6ab5ecc8da..6acd3efdba 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -10777,3 +10777,33 @@ using @code{S3}.")
     (description
      "Wrappers on 'regexpr' and 'gregexpr' to return the match results in tidy data frames.")
     (license license:expat)))
+
+(define-public r-styler
+  (package
+    (name "r-styler")
+    (version "1.1.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (cran-uri "styler" version))
+       (sha256
+        (base32
+         "1z24mi88snbz1avjw9phq0lzmigddvycc56s83nxzr9w9z85mh05"))))
+    (build-system r-build-system)
+    (propagated-inputs
+     `(("r-backports" ,r-backports)
+       ("r-cli" ,r-cli)
+       ("r-magrittr" ,r-magrittr)
+       ("r-purrr" ,r-purrr)
+       ("r-rematch2" ,r-rematch2)
+       ("r-rlang" ,r-rlang)
+       ("r-rprojroot" ,r-rprojroot)
+       ("r-tibble" ,r-tibble)
+       ("r-withr" ,r-withr)
+       ("r-xfun" ,r-xfun)))
+    (home-page "https://github.com/r-lib/styler")
+    (synopsis
+     "Non-Invasive Pretty Printing of R Code")
+    (description
+     "Pretty-prints R code without changing the user's formatting intent.")
+    (license license:gpl3)))
-- 
2.20.1

bug#34694: [PATCH] gnu: add r-styler.

[Ricardo Wurmus]

Hi Nicolò,

> ---
>  gnu/packages/cran.scm | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
>
> diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
> index 6ab5ecc8da..6acd3efdba 100644
> --- a/gnu/packages/cran.scm
> +++ b/gnu/packages/cran.scm
> @@ -10777,3 +10777,33 @@ using @code{S3}.")
>      (description
>       "Wrappers on 'regexpr' and 'gregexpr' to return the match results in tidy data frames.")
>      (license license:expat)))
> +
> +(define-public r-styler […]

Thank you for the patch.  I’ve applied it with a few minor changes
(description and commit message) to the master branch with commit
107850b391.

--
Ricardo

[bug#34693] [PATCH] services: mpd: add more configuration options

[Nicolò Balzarotti]

* gnu/services/audio.scm (<mpd-configuration>): Add 'db-file', 'state-file'
  and 'sticker-file' fields.
---
 gnu/services/audio.scm | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/gnu/services/audio.scm b/gnu/services/audio.scm
index 6629433780..ebfe05abd0 100644
--- a/gnu/services/audio.scm
+++ b/gnu/services/audio.scm
@@ -42,6 +42,12 @@
                 (default "~/Music"))
   (playlist-dir mpd-configuration-playlist-dir
                 (default "~/.mpd/playlists"))
+  (db-file      mpd-configuration-db-file
+                (default "~/.mpd/tag_cache"))
+  (state-file   mpd-configuration-state-file
+                (default "~/.mpd/state"))
+  (sticker-file mpd-configuration-sticker-file
+                (default "~/.mpd/sticker.sql"))
   (port         mpd-configuration-port
                 (default "6600"))
   (address      mpd-configuration-address
@@ -61,6 +67,9 @@
         `(("user" ,mpd-configuration-user)
           ("music_directory" ,mpd-configuration-music-dir)
           ("playlist_directory" ,mpd-configuration-playlist-dir)
+          ("db_file" ,mpd-configuration-db-file)
+          ("state_file" ,mpd-configuration-state-file)
+          ("sticker_file" ,mpd-configuration-sticker-file)
           ("port" ,mpd-configuration-port)
           ("bind_to_address" ,mpd-configuration-address)))))
 
-- 
2.20.1

[bug#34693] [PATCH] services: mpd: add more configuration options

[Ludovic Courtès]

Hi Nicolò,

Nicolò Balzarotti <anothersms@gmail.com> skribis:

> * gnu/services/audio.scm (<mpd-configuration>): Add 'db-file', 'state-file'
>   and 'sticker-file' fields.

Could you update doc/guix.texi to document these new fields, and send an
updated patch?

Thank you for this patch!

Ludo’.

[bug#34693] [PATCH] services: mpd: add more configuration options

[Nicolò Balzarotti]

From: nixo <nicolo@nixo.xyz>

* gnu/services/audio.scm (<mpd-configuration>): Add 'db-file', 'state-file'
  and 'sticker-file' fields.
* doc/guix.texi (Music Player Daemon): Document it.
---
 doc/guix.texi          | 9 +++++++++
 gnu/services/audio.scm | 9 +++++++++
 2 files changed, 18 insertions(+)

diff --git a/doc/guix.texi b/doc/guix.texi
index 9fb5cff06d..c5857acd0c 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -20175,6 +20175,15 @@ The directory to scan for music files.
 @item @code{playlist-dir} (default: @code{"~/.mpd/playlists"})
 The directory to store playlists.
 
+@item @code{db-file} (default: @code{"~/.mpd/tag_cache"})
+The location of the music database.
+
+@item @code{state-file} (default: @code{"~/.mpd/state"})
+The location of the file that stores current MPD's state.
+
+@item @code{sticker-file} (default: @code{"~/.mpd/sticker.sql"})
+The location of the sticker database.
+
 @item @code{port} (default: @code{"6600"})
 The port to run mpd on.
 
diff --git a/gnu/services/audio.scm b/gnu/services/audio.scm
index 6629433780..ebfe05abd0 100644
--- a/gnu/services/audio.scm
+++ b/gnu/services/audio.scm
@@ -42,6 +42,12 @@
                 (default "~/Music"))
   (playlist-dir mpd-configuration-playlist-dir
                 (default "~/.mpd/playlists"))
+  (db-file      mpd-configuration-db-file
+                (default "~/.mpd/tag_cache"))
+  (state-file   mpd-configuration-state-file
+                (default "~/.mpd/state"))
+  (sticker-file mpd-configuration-sticker-file
+                (default "~/.mpd/sticker.sql"))
   (port         mpd-configuration-port
                 (default "6600"))
   (address      mpd-configuration-address
@@ -61,6 +67,9 @@
         `(("user" ,mpd-configuration-user)
           ("music_directory" ,mpd-configuration-music-dir)
           ("playlist_directory" ,mpd-configuration-playlist-dir)
+          ("db_file" ,mpd-configuration-db-file)
+          ("state_file" ,mpd-configuration-state-file)
+          ("sticker_file" ,mpd-configuration-sticker-file)
           ("port" ,mpd-configuration-port)
           ("bind_to_address" ,mpd-configuration-address)))))
 
-- 
2.20.1

bug#34693: [PATCH] services: mpd: add more configuration options

[Ludovic Courtès]

Hi Nicolò,

Nicolò Balzarotti <anothersms@gmail.com> skribis:

> From: nixo <nicolo@nixo.xyz>
>
> * gnu/services/audio.scm (<mpd-configuration>): Add 'db-file', 'state-file'
>   and 'sticker-file' fields.
> * doc/guix.texi (Music Player Daemon): Document it.

Applied, thank you!

Ludo’.

bug#34699: [PATCH] gnu: add emacs-smart-hungry-delete.

[Arun Isaac]

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]


Hi,

Thanks for the patch. Sorry this has taken forever! I have now pushed to
master after changing the commit message to follow Guix conventions,
anad building from the GitHub repo instead of MELPA.

Cheers!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 524 bytes --]