From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Giovanni Biscuolo <g@xelera.eu>
Cc: 39551@debbugs.gnu.org
Subject: bug#39551: Cannot declare an NFS mount using the <file-system> record
Date: Wed, 12 Feb 2020 14:12:32 -0500 [thread overview]
Message-ID: <8736bf39i7.fsf@gmail.com> (raw)
In-Reply-To: <878sl7bqud.fsf@roquette.mug.biscuolo.net> (Giovanni Biscuolo's message of "Wed, 12 Feb 2020 19:30:50 +0100")
Hello Giovanni,
Giovanni Biscuolo <g@xelera.eu> writes:
> Hello,
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
>
>> The attached patch fixes this issue
>
> [...]
>
>> diff --git a/guix/scripts/system.scm b/guix/scripts/system.scm
>> index b0386a1392..26a1599a93 100644
>> --- a/guix/scripts/system.scm
>> +++ b/guix/scripts/system.scm
>> @@ -566,6 +566,8 @@ any, are available. Raise an error if they're not."
>> (and (file-system-mount? fs)
>> (not (member (file-system-type fs)
>> %pseudo-file-system-types))
>> + ;; Fixes issue #39551 (see: https://bugs.gnu.org/39551).
>> + (not (string-prefix? "nfs" (file-system-type fs)))
>> (not (memq 'bind-mount (file-system-flags fs)))))
>> file-systems))
>
> Please is it possible to also add nfs4 to this fix?
>
> Thanks! Gio'
It should work already, given that I'm checking for a string *prefix* of
"nfs" :-).
next prev parent reply other threads:[~2020-02-12 19:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 19:41 bug#39551: Cannot declare an NFS mount using the <file-system> record Maxim Cournoyer
2020-02-12 8:54 ` Maxim Cournoyer
2020-02-12 18:30 ` Giovanni Biscuolo
2020-02-12 19:12 ` Maxim Cournoyer [this message]
2020-02-18 17:28 ` Maxim Cournoyer
2020-02-12 19:13 ` bug#39551: [PATCH v2] " Maxim Cournoyer
2020-02-13 15:45 ` Maxim Cournoyer
2020-02-13 21:37 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736bf39i7.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=39551@debbugs.gnu.org \
--cc=g@xelera.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.