From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:59752) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7Fro-0003x9-1E for guix-patches@gnu.org; Thu, 27 Feb 2020 04:54:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7Frm-0004Mb-QP for guix-patches@gnu.org; Thu, 27 Feb 2020 04:54:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:52706) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j7Frm-0004MR-MO for guix-patches@gnu.org; Thu, 27 Feb 2020 04:54:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j7Frm-000259-JK for guix-patches@gnu.org; Thu, 27 Feb 2020 04:54:02 -0500 Subject: [bug#39804] [PATCH] gnu: add emacs-exwm-next package (i.e. exwm for emacs-next) Resent-Message-ID: From: Pierre Neidhardt References: <87blplqcdd.fsf@web.de> Date: Thu, 27 Feb 2020 10:53:22 +0100 In-Reply-To: <87blplqcdd.fsf@web.de> (dakling's message of "Wed, 26 Feb 2020 22:07:44 +0100") Message-ID: <8736aw8igd.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: dakling Cc: 39804@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Thanks for your submission. Note that you need not create a new thread for to send a update of a patch. If you used the `git send-email` command, you could have used the `--to=3D` option to send to the previous thread. For instance =2D-8<---------------cut here---------------start------------->8--- git send-email --to=3D39756@debbugs.gnu.org 0001-my-patch.diff =2D-8<---------------cut here---------------end--------------->8--- Comments below: > --- > gnu/packages/emacs-xyz.scm | 71 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 71 insertions(+) > > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > index 6b9027df8a..c6df469895 100644 > --- a/gnu/packages/emacs-xyz.scm > +++ b/gnu/packages/emacs-xyz.scm > @@ -8601,6 +8601,77 @@ It should enable you to implement low-level X11 ap= plications.") > built on top of XELB.") > (license license:gpl3+))) > > +(define-public emacs-exwm-next I think you don't need to copy the whole package definition. Instead, you could `inherit' from the original definition and only adjust the name, description, inputs and maybe arguments. For instance =2D-8<---------------cut here---------------start------------->8--- (define-public emacs-exwm-next (package (inherit emacs) (name "emacs-exwm-next") (inputs ...) (synopsys ...))) =2D-8<---------------cut here---------------end--------------->8--- See `substitute-keyword-arguments' in the fftwf package for a convenient way to modify just one argument. > + (package > + (name "emacs-exwm-next") > + (version "0.23") > + (synopsis "Emacs X window manager") Maybe tell that this is using the next version of Emacs. > + (source (origin > + (method url-fetch) > + (uri (string-append "https://elpa.gnu.org/packages/exwm-" > + version ".tar")) > + (sha256 > + (base32 > + "05w1v3wrp1lzz20zd9lcvr5nhk809kgy6svvkbs15xhnr6x55ad5"))= )) > + (build-system emacs-build-system) > + (propagated-inputs > + `(("emacs-xelb" ,emacs-xelb))) > + (inputs > + `(("xhost" ,xhost) > + ("emacs-next" ,emacs-next) > + ("dbus" ,dbus))) > + ;; The following functions and variables needed by emacs-exwm are > + ;; not included in emacs-minimal: > + ;; scroll-bar-mode, fringe-mode > + ;; x-display-pixel-width, x-display-pixel-height > + (arguments > + `(#:emacs ,emacs Shouldn't this be `emacs-next` as well? Cheers! =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAl5XkZIACgkQm9z0l6S7 zH9nPQf9E27fTm31eLYvkzUt+6zck81xYzuqnSTCjVr4EH7StDzq0r8xObfBrJNH JsovSqNGpurjSxHnAHhE/PlZ7KokvQ0JiHL/wEF0ct1jI1wh6UAv1hjX/zMw189G hCzMePtZ6aIsHC5pHv3Z0NUiLGPPc0qxHlKSPxq6jAdxypY+fx8Nnj/0xdqoQ+0j xmvLdL3pE2gEplwZ0aVGdZyWpzlO+izgPuWUDSEJL48w5E1QXzW9L8Q6jDSfTio9 kIiOI+7kusXS4B6dolCZhCYCRWfvMeV6C/cYJxf0CGN9Rimi5M0+JUTfVKHPrEbE kGIjgQti3omKmi06FaFyfMx9VJoGoQ== =jM47 -----END PGP SIGNATURE----- --=-=-=--