From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:33234) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7ZuN-0002QW-0Y for guix-patches@gnu.org; Fri, 28 Feb 2020 02:18:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7ZuL-0005og-Sg for guix-patches@gnu.org; Fri, 28 Feb 2020 02:18:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:54606) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j7ZuL-0005ob-QM for guix-patches@gnu.org; Fri, 28 Feb 2020 02:18:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j7ZuL-0004GM-MI for guix-patches@gnu.org; Fri, 28 Feb 2020 02:18:01 -0500 Subject: [bug#39734] [PATCH] scripts: Emit GC hint if free space is lower than absolute and relative threshold. Resent-Message-ID: From: Pierre Neidhardt In-Reply-To: <87o8tjaaa4.fsf@gnu.org> References: <87lforarw6.fsf@ambrevar.xyz> <20200225102330.4825-1-mail@ambrevar.xyz> <87o8tjaaa4.fsf@gnu.org> Date: Fri, 28 Feb 2020 08:17:44 +0100 Message-ID: <8736avi3jb.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 39734@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Thanks, I noticed the issue as well on my last guix pull! :) However, shouldn't it be `min` still? On big partitions, 5% will be high, so we don't want to display a warning then, we only display it when lower than 5GiB, the minimum. On small partitions, 5GiB is too much, so we don't want to display a warning then, we only display it when lower than 5%, the minimum. Thoughts? =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAl5YvpgACgkQm9z0l6S7 zH+NIAgAlaT1Y4S16KUX3G9Ss/u1rRYIHs/9DK3slrkMbETQ9qDkDKc+bxi+I+pA NoYTVnF9pk2UpYfNT7zdpjXWR/UDj+zrYZkn6GAUye5E5Ip2SKhKJgA3RwaJmDOf Pf7xXGisRAQfOVZxI2DvCEh8CcG71ImzJO6CV/iKD8ELEFSXA+QBTbdHlhx6LxvL +JYJx4bIMEzMoCeZwi6YEUUDSomuYTDtj+kxHsIILlRkaR9NefhHLwk62vCxc4H1 ASzldcxpVWwHcQ3PvEgKfqWG4T5s/wqUREGGu5nrv4YwuBDN2XYNOtTVq0+MF/AF rFB9OgX9MvKlR1hjiPyeQrCDDS8R5A== =K767 -----END PGP SIGNATURE----- --=-=-=--