From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:58996)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j9tOp-00036C-Mt
 for guix-patches@gnu.org; Thu, 05 Mar 2020 11:31:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j9tOo-00020Q-Jz
 for guix-patches@gnu.org; Thu, 05 Mar 2020 11:31:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:37653)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1j9tOo-000204-Gt
 for guix-patches@gnu.org; Thu, 05 Mar 2020 11:31:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j9tOo-0008B0-DM
 for guix-patches@gnu.org; Thu, 05 Mar 2020 11:31:02 -0500
Subject: [bug#39734] [PATCH] scripts: Emit GC hint if free space is lower than
 absolute and relative threshold.
Resent-Message-ID: <handler.39734.B39734.158342583431396@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <87lforarw6.fsf@ambrevar.xyz>
 <20200225102330.4825-1-mail@ambrevar.xyz> <87o8tjaaa4.fsf@gnu.org>
 <8736avi3jb.fsf@ambrevar.xyz>
Date: Thu, 05 Mar 2020 17:29:58 +0100
In-Reply-To: <8736avi3jb.fsf@ambrevar.xyz> (Pierre Neidhardt's message of
 "Fri, 28 Feb 2020 08:17:44 +0100")
Message-ID: <8736amaho9.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: 39734@debbugs.gnu.org

Howdy!

Pierre Neidhardt <mail@ambrevar.xyz> skribis:

> Thanks, I noticed the issue as well on my last guix pull! :)
>
> However, shouldn't it be `min` still?
>
> On big partitions, 5% will be high, so we don't want to display a
> warning then, we only display it when lower than 5GiB, the minimum.
>
> On small partitions, 5GiB is too much, so we don't want to display a
> warning then, we only display it when lower than 5%, the minimum.
>
> Thoughts?

Hmm you must be right, sorry for getting it wrong.  Please feel free to
push a fix!

Ludo=E2=80=99.