From: Mark H Weaver <mhw@netris.org>
To: Leo Famulari <leo@famulari.name>,
Danny Milosavljevic <dannym@scratchpost.org>
Cc: Mathieu Othacehe <othacehe@gnu.org>, 43344@debbugs.gnu.org
Subject: bug#43344: "basic" system tests fail (and all the other ones) on guix master
Date: Wed, 16 Sep 2020 21:36:49 -0400 [thread overview]
Message-ID: <87363h9oab.fsf@netris.org> (raw)
In-Reply-To: <20200916162244.GA3262@jasmine.lan>
Leo Famulari <leo@famulari.name> writes:
> On Wed, Sep 16, 2020 at 04:52:45PM +0200, Danny Milosavljevic wrote:
>> commit 692d0626557451c4b557397f20b7394b612d0289
>> Author: Christoph Hellwig <hch@lst.de>
>> Date: Tue Sep 1 11:59:41 2020 +0200
>>
>> block: fix locking in bdev_del_partition
>>
>> [ Upstream commit 08fc1ab6d748ab1a690fd483f41e2938984ce353 ]
>>
>> We need to hold the whole device bd_mutex to protect against
>> other thread concurrently deleting out partition before we get
>> to it, and thus causing a use after free.
>>
>> Fixes: cddae808aeb7 ("block: pass a hd_struct to delete_partition")
>> Reported-by: syzbot+6448f3c229bc52b82f69@syzkaller.appspotmail.com
>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>> Signed-off-by: Jens Axboe <axboe@kernel.dk>
>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>>
>> ?
>
> Do you think that's the faulty commit? I won't have time to test it
> today.
Looks like a good bet to me. Many thanks to Leo for testing 5.8.9, and
to Danny for identifying the likely culprit.
Next, it probably makes sense to test 5.8.9 with the above commit
reverted. Would someone like to try it? If that works, we can avoid
the bisection, resume kernel updates, and revert this change across all
of our kernels until a better solution is found.
Mark
next prev parent reply other threads:[~2020-09-17 1:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 17:50 bug#43344: "basic" system tests fail (and all the other ones) on guix master Danny Milosavljevic
2020-09-14 13:26 ` Mathieu Othacehe
2020-09-14 16:31 ` Danny Milosavljevic
2020-09-15 22:34 ` Mark H Weaver
2020-09-15 23:06 ` Leo Famulari
2020-09-16 14:12 ` Leo Famulari
2020-09-16 14:52 ` Danny Milosavljevic
2020-09-16 15:02 ` Danny Milosavljevic
2020-09-16 16:22 ` Leo Famulari
2020-09-17 1:36 ` Mark H Weaver [this message]
2020-09-17 2:21 ` Leo Famulari
2020-09-17 8:40 ` Marius Bakke
2020-09-17 14:20 ` Leo Famulari
2020-09-17 19:08 ` Mark H Weaver
2020-09-17 14:05 ` Leo Famulari
2020-09-17 15:28 ` Danny Milosavljevic
2020-09-16 13:59 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87363h9oab.fsf@netris.org \
--to=mhw@netris.org \
--cc=43344@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
--cc=leo@famulari.name \
--cc=othacehe@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.