[bug#45108] Added emacs-burly

[bug#45108] Added emacs-burly

[rdes via Guix-patches via]

[-- Attachment #1.1: Type: text/plain, Size: 271 bytes --]

Hello,

The attached patches are to add emacs-burly. I've also attached a patch for emacs-map since it's required and not packaged yet. Please let me know in the future if this should be multiple emails.

Ryan

Sent with [ProtonMail](https://protonmail.com) Secure Email.

[-- Attachment #1.2: Type: text/html, Size: 600 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-emacs-map.patch --]
[-- Type: text/x-patch; name=0001-gnu-Add-emacs-map.patch, Size: 1394 bytes --]

From 0e24818db4f22cff0d841b7b77866121e0f2d6a5 Mon Sep 17 00:00:00 2001
From: Ryan Desfosses <rdes@protonmail.com>
Date: Mon, 7 Dec 2020 18:17:52 -0500
Subject: [PATCH 1/2] gnu: Add emacs-map

* gnu/packages/emacs-xyz.scm (emacs-map): New variable.
---
 gnu/packages/emacs-xyz.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 8a03b2d7a3..77d314e5f3 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -25728,3 +25728,24 @@ syntax highlighting and UI components.")
        "This Emacs package provides a Janet REPL to evaluate @code{janet-mode}
 s-expression.")
       (license license:expat))))
+
+(define-public emacs-map
+  (package
+    (name "emacs-map")
+    (version "2.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://elpa.gnu.org/packages/map-" version ".el"))
+       (sha256
+        (base32
+         "0ydz5w1n4vwhhzxxj003s7jv8n1wjijwfryk5z93bwhnr0cak0i0"))))
+    (build-system emacs-build-system)
+    (home-page
+     "http://elpa.gnu.org/packages/map.html")
+    (synopsis "Map manipulation functions")
+    (description
+     "map.el provides map-manipulation functions that work on alists,
+hash-table and arrays.  All functions are prefixed with \"map-\".")
+    (license license:gpl3+)))
-- 
2.29.2


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: 0002-gnu-Add-emacs-burly.patch --]
[-- Type: text/x-patch; name=0002-gnu-Add-emacs-burly.patch, Size: 1766 bytes --]

From fe69c97b2e228571a58fe87aec453ace52c70748 Mon Sep 17 00:00:00 2001
From: Ryan Desfosses <rdes@protonmail.com>
Date: Mon, 7 Dec 2020 18:26:46 -0500
Subject: [PATCH 2/2] gnu: Add emacs-burly

* gnu/packages/emacs-xyz.scm (emacs-burly): New variable.
---
 gnu/packages/emacs-xyz.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 77d314e5f3..e207dfcbe3 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -25749,3 +25749,30 @@ s-expression.")
      "map.el provides map-manipulation functions that work on alists,
 hash-table and arrays.  All functions are prefixed with \"map-\".")
     (license license:gpl3+)))
+
+(define-public emacs-burly
+  (package
+    (name "emacs-burly")
+    (version "0.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/alphapapa/burly.el")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1vaikknjzmhpszyi4yxjjkp1ihgmhpbnbx1s5pjy4mnhl1ibi33b"))))
+    (build-system emacs-build-system)
+    (propagated-inputs `(("emacs-map" ,emacs-map)))
+    (home-page
+     "https://github.com/alphapapa/burly.el")
+    (synopsis
+     "Save and restore frame/window configurations with buffers")
+    (description
+     "This package provides tools to save and restore frame and window
+configurations in Emacs, including buffers that may not be live
+anymore.  In this way, it's like a lightweight \"workspace\" manager,
+allowing you to easily restore one or more frames, including their
+windows, the windows' layout, and their buffers.")
+    (license license:gpl3+)))
-- 
2.29.2

bug#45108: Added emacs-burly

[Oleg Pykhalov]

[-- Attachment #1: Type: text/plain, Size: 1358 bytes --]

Hello,

Thank you for patches.

rdes via Guix-patches via <guix-patches@gnu.org> writes:

[…]

> Please let me know in the future if this should be multiple emails.

It's a good practice to split an email with multiple patches, which is
described on webpage “Sending a Patch Series” [1].

[1] https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html

> Sent with [ProtonMail](https://protonmail.com) Secure Email.
> From 0e24818db4f22cff0d841b7b77866121e0f2d6a5 Mon Sep 17 00:00:00 2001
> From: Ryan Desfosses <rdes@protonmail.com>
> Date: Mon, 7 Dec 2020 18:17:52 -0500
> Subject: [PATCH 1/2] gnu: Add emacs-map
                                         ^
                                         missing dot

[…]

> +    (synopsis "Map manipulation functions")
> +    (description
> +     "map.el provides map-manipulation functions that work on alists,
> +hash-table and arrays.  All functions are prefixed with \"map-\".")

1. “description should start with an upper-case letter or digit” as
reported by "./pre-inst-env guix lint".

2. Istead of ‘\"map-\"’, please use ‘@code{map-}’.

[…]

> Subject: [PATCH 2/2] gnu: Add emacs-burly
                                           ^
                                           missing dot

Pushed with changes above to master.

Oleg.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

[bug#45108] Added emacs-burly

[Nicolas Goaziou]

Hello,

Oleg Pykhalov <go.wigust@gmail.com> writes:

> Pushed with changes above to master.

I don't think the emacs-map package is needed as a propagated inputs
since it ships with Emacs. Have you tried building emacs-burly without
it?

For the same reason I'm not even sure we need to provide emacs-map at
all (we do not provide emacs-seq either).

WDYT?

Regards,
-- 
Nicolas Goaziou

[bug#45108] Added emacs-burly

[Oleg Pykhalov]

[-- Attachment #1: Type: text/plain, Size: 612 bytes --]

Hello,

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> I don't think the emacs-map package is needed as a propagated inputs
> since it ships with Emacs. Have you tried building emacs-burly without
> it?

No, I didn't try.


burly requires map 2.1, but Emacs provides 2.0 (M-x find-library map):
--8<---------------cut here---------------start------------->8---
;; Package-Requires: ((emacs "26.3") (map "2.1"))
--8<---------------cut here---------------end--------------->8---

I don't mind removing map from propagated inputs if it not break burly,
but I'm not a user of this package to decide ;-)


Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

[bug#45108] Added emacs-burly

[Michael Rohleder]

[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> Oleg Pykhalov <go.wigust@gmail.com> writes:
>
>> Pushed with changes above to master.
>
> I don't think the emacs-map package is needed as a propagated inputs
> since it ships with Emacs. Have you tried building emacs-burly without
> it?
>
> For the same reason I'm not even sure we need to provide emacs-map at
> all (we do not provide emacs-seq either).
>
> WDYT?

I think, emacs-seq has shown that packages "extracted" from emacs (here:
map, xref, project) can be problematic if they become older than the one
that ship with emacs (and are deeper in the graph?).  Not sure, maybe
this is already an issue for emacs-next users?!


-- 
	Brian Kernighan has an automobile which he helped design.
Unlike most automobiles, it has neither speedometer, nor gas gauge, nor
any of the numerous idiot lights which plague the modern driver.
Rather, if the driver makes any mistake, a giant "?" lights up in the
center of the dashboard.  "The experienced driver", he says, "will
usually know what's wrong."

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 511 bytes --]