From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id eE5VB0TZDmDaMQAA0tVLHw (envelope-from ) for ; Mon, 25 Jan 2021 14:44:20 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id X3W9AkTZDmAXDQAAB5/wlQ (envelope-from ) for ; Mon, 25 Jan 2021 14:44:20 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5CF4A94042F for ; Mon, 25 Jan 2021 14:44:19 +0000 (UTC) Received: from localhost ([::1]:47248 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l436I-0003K3-5M for larch@yhetil.org; Mon, 25 Jan 2021 09:44:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40652) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4361-0003J4-VU for guix-patches@gnu.org; Mon, 25 Jan 2021 09:44:01 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:55044) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l4361-0001xP-Nk for guix-patches@gnu.org; Mon, 25 Jan 2021 09:44:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l4361-0005m9-In for guix-patches@gnu.org; Mon, 25 Jan 2021 09:44:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45712] [PATCHES] Improve Python package quality Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 25 Jan 2021 14:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45712 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Lars-Dominik Braun Received: via spool by 45712-submit@debbugs.gnu.org id=B45712.161158583022177 (code B ref 45712); Mon, 25 Jan 2021 14:44:01 +0000 Received: (at 45712) by debbugs.gnu.org; 25 Jan 2021 14:43:50 +0000 Received: from localhost ([127.0.0.1]:38357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l435q-0005ld-5N for submit@debbugs.gnu.org; Mon, 25 Jan 2021 09:43:50 -0500 Received: from mail-qv1-f44.google.com ([209.85.219.44]:35697) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l435n-0005lP-Qg for 45712@debbugs.gnu.org; Mon, 25 Jan 2021 09:43:49 -0500 Received: by mail-qv1-f44.google.com with SMTP id l14so4183239qvp.2 for <45712@debbugs.gnu.org>; Mon, 25 Jan 2021 06:43:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=G7VfxkE+TVP8fWbYi/vyNJNTVPQ7YS83Fudi9H19YfA=; b=BuvFzzjN57nG8BdafpmZf7y0AhOxOwFueXcT7+kIEjxJRKOHoxY8Y5bT4KliomaR6A /aMiAay6Y80Uafm8e3VmP/FwMhl971OSKIX4cx1hD2OUfkqR7Z9gQxwWI1xpSQYKKQYy MKGcyuydfO+NRUBUvdN/2w1ooISFl0P+r3T+qQmTpWfgWNWRxh73l4i4txcq+0tH06qm 1NXTIZ742GkzmpVp6IGsMbseAHHZ67l9Ni93blmDNAfC1hwhE4OqkW7YB7Hr8dFHeBHi +avp34Q4N3KqRu02RBjcT+fqC/dnTGvVA7dn37EhX3zYt3OxId7SuQShrBEcVykn+8yx ArOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=G7VfxkE+TVP8fWbYi/vyNJNTVPQ7YS83Fudi9H19YfA=; b=JSBvIvfVV/Z8VREEGCXOFq9EosKyMfsNvwYCCCjZGc4sUAfukBcgqVpWbQVj6W+kwG JGCKnqcS5wSmhl5bp+HZ9QwFrYHdJ7dhfqCkGo+uhMx8Bnl9gs3ZHZXrcfRBE05a570R rEncvtG1+1Twdc8AiZQBpoedhOjDI+TO/lFvBH5JT1J0OWRJgIgnjRXFsyxp8/abE7BK HUdF7F3whW7gmihgKZh0ediA+uMx3gm8Y7TdbvGPCuzx4dKj0Iz8w9sMAsegtMuvbx9X 8+Rzphyta8xVD1aQfhr5EP9jeea70zO7hJ1mUITYDqtU1dBsv/8H5zRz6DNnfUXnFY2Y d5uA== X-Gm-Message-State: AOAM533UQujFzu18yglyiVp1sz8CfTOBC4qDHaUjeEjNb9ky2gKAlnlb 99q9VClvQwZxbtXNLDfzYLbo3NYu8x4afw== X-Google-Smtp-Source: ABdhPJw5NhSh0pBtw6lrEsXjFmz/jwc2PdgPj6A9g5T2iPVHiltj4AWwnI/+TMHOCwmyfMDOqUfd0Q== X-Received: by 2002:ad4:4b21:: with SMTP id s1mr1018192qvw.59.1611585822054; Mon, 25 Jan 2021 06:43:42 -0800 (PST) Received: from hurd (dsl-10-132-34.b2b2c.ca. [72.10.132.34]) by smtp.gmail.com with ESMTPSA id d192sm8876682qkc.65.2021.01.25.06.43.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jan 2021 06:43:41 -0800 (PST) From: Maxim Cournoyer References: Date: Mon, 25 Jan 2021 09:43:40 -0500 In-Reply-To: (Lars-Dominik Braun's message of "Thu, 7 Jan 2021 14:26:20 +0100") Message-ID: <8735yp3wmb.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45712@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.25 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=BuvFzzjN; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 5CF4A94042F X-Spam-Score: -1.25 X-Migadu-Scanner: scn0.migadu.com X-TUID: oUSHEFhfJJcE Hi! Lars-Dominik Braun writes: > Hi, > > as announced in > https://lists.gnu.org/archive/html/guix-devel/2021-01/msg00021.html Ive > been working on adding an additional phase to Python packages to check > whether they actually work. I cleaned up my patch, added tests and now > Im pretty confident it works as expected. The first patch in this > series adds this phase, while the other ones fix build failures caused > by it. All of this should go to core-updates (or a separate wip-* > branch?), since it causes a massive number of rebuilds. > > You can also pull my git repo at https://github.com/PromyLOPh/guix.git > branch work-python-importcheck. Thanks for the initiative! It looks good, on first sight. One question I have is this: does it rely on the Python package having been built with setuptools/distutils? The Python world is moving toward a plurality of PEP 517 compliant build systems; any idea if the checker will continue working for these new packages? We have currently only one such package in our collection, on core-updates. It's python-isort, added with commit 812a2931de553d12c01b0a4d53d03613b09adaaf on the core-updates branch. Thank you, Maxim