From: "Ludovic Courtès" <ludo@gnu.org>
To: zimoun <zimon.toutoune@gmail.com>
Cc: 44187@debbugs.gnu.org
Subject: bug#44187: Channel clones lack SWH fallback
Date: Sat, 18 Sep 2021 12:05:56 +0200 [thread overview]
Message-ID: <8735q2urjv.fsf@gnu.org> (raw)
In-Reply-To: <874kajglbo.fsf_-_@gmail.com> (zimoun's message of "Fri, 17 Sep 2021 19:31:55 +0200")
Hi!
zimoun <zimon.toutoune@gmail.com> skribis:
> The patch LGTM although there is a redundancy, from my understanding.
>
> On Fri, 10 Sep 2021 at 16:34, Ludovic Courtès <ludo@gnu.org> wrote:
>
>> @@ -694,7 +714,15 @@ wait until it becomes available, which could take several minutes."
>> (format log-port "SWH: found revision ~a with directory at '~a'~%"
>> (revision-id revision)
>> (swh-url (revision-directory-url revision)))
>> - (swh-download-directory (revision-directory revision) output
>> - #:log-port log-port))
>> + (swh-download-archive (match archive-type
>> + ('flat
>> + (string-append
>> + "swh:1:dir:" (revision-directory revision)))
>> + ('git-bare
>> + (string-append
>> + "swh:1:rev:" (revision-id revision))))
>
> Here the ’swid’ depends on the ’archive-type’…
>
>> + output
>> + #:archive-type archive-type
>
> …which is also passed. Then this is propagated. For instance,
> ’swh-download-directory’:
>
>> +(define* (swh-download-directory id output
>> + #:key (log-port (current-error-port)))
>> + "Download from Software Heritage the directory with the given ID, and
>> +unpack it to OUTPUT. Return #t on success and #f on failure."
>> + (swh-download-archive (string-append "swh:1:dir:" id) output
>> + #:archive-type 'flat
>> + #:log-port log-port))
>> +
>
> Does it make sense to pass this ’swhid’ equal to ’swh:1:rev’ with the
> ’flat’ archive-type? Another instance is,
>
>> + (match (vault-fetch swhid
>> + #:archive-type archive-type
>> + #:log-port log-port)
>
> and from my understanding, again ’swhid’ depends on ’archive-type’.
> Therefore, it prone error.
‘git-bare’ only makes sense for a revision, not a directory, but I
wonder if ‘flat’ can be used for a revision (in which case it’d be
equivalent to getting the corresponding directory)?
I agree there’s some redundancy between directory/revision and
flat/git-bare, but it’s the SWH API that looks like this, so I’d be
tempted to just keep it as is. Maybe we could ask for guidance on
#swh-devel.
Thanks!
Ludo’.
next prev parent reply other threads:[~2021-09-18 10:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 22:17 bug#44187: whishlist: time-machine --channel falls back to SWH zimoun
2021-03-05 14:51 ` Ludovic Courtès
2021-09-10 14:34 ` bug#44187: [PATCH 0/3] Fall back to Software Heritage (SWH) for Git clones Ludovic Courtès
2021-09-10 14:34 ` bug#44187: [PATCH 1/3] swh: Support downloads of bare Git repositories Ludovic Courtès
2021-09-17 17:31 ` bug#44187: Channel clones lack SWH fallback zimoun
2021-09-18 10:05 ` Ludovic Courtès [this message]
2021-09-18 10:27 ` zimoun
2021-09-10 14:34 ` bug#44187: [PATCH 2/3] git: 'update-cached-checkout' can fall back to SWH when cloning Ludovic Courtès
2021-09-10 14:34 ` bug#44187: [PATCH 3/3] git: 'reference-available?' recognizes 'tag-or-commit' Ludovic Courtès
2021-09-13 16:07 ` bug#44187: [PATCH 0/3] Fall back to Software Heritage (SWH) for Git clones zimoun
2021-09-14 13:37 ` Ludovic Courtès
2021-09-17 8:02 ` bug#44187: Channel clones lack SWH fallback zimoun
2021-09-18 21:10 ` Ludovic Courtès
2021-09-20 9:27 ` zimoun
2021-09-22 10:03 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735q2urjv.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=44187@debbugs.gnu.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.