From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id WKoIE9Uwn2FBAwAAgWs5BA (envelope-from ) for ; Thu, 25 Nov 2021 07:44:37 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id WIyoDtUwn2EZYgAAbx9fmQ (envelope-from ) for ; Thu, 25 Nov 2021 06:44:37 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E3B7133AD9 for ; Thu, 25 Nov 2021 07:44:36 +0100 (CET) Received: from localhost ([::1]:46364 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mq8Uk-0003sw-Qr for larch@yhetil.org; Thu, 25 Nov 2021 01:44:35 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46864) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mq8UF-0003rm-UC for guix-patches@gnu.org; Thu, 25 Nov 2021 01:44:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:44032) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mq8UE-0002Ts-Dv for guix-patches@gnu.org; Thu, 25 Nov 2021 01:44:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mq8UE-0001EO-C0 for guix-patches@gnu.org; Thu, 25 Nov 2021 01:44:02 -0500 Subject: bug#52078: [PATCH 1/2] gnu: julia: Disable broken tests. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Thu, 25 Nov 2021 06:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 52078 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun Cc: 52078-done@debbugs.gnu.org Mail-Followup-To: 52078@debbugs.gnu.org, maxim.cournoyer@gmail.com, zimon.toutoune@gmail.com Received: via spool by 52078-done@debbugs.gnu.org id=D52078.16378226294703 (code D ref 52078); Thu, 25 Nov 2021 06:44:02 +0000 Received: (at 52078-done) by debbugs.gnu.org; 25 Nov 2021 06:43:49 +0000 Received: from localhost ([127.0.0.1]:55576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mq8U0-0001Dm-Uw for submit@debbugs.gnu.org; Thu, 25 Nov 2021 01:43:49 -0500 Received: from mail-qk1-f175.google.com ([209.85.222.175]:40723) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mq8Ty-0001Db-MJ for 52078-done@debbugs.gnu.org; Thu, 25 Nov 2021 01:43:47 -0500 Received: by mail-qk1-f175.google.com with SMTP id p4so9441941qkm.7 for <52078-done@debbugs.gnu.org>; Wed, 24 Nov 2021 22:43:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=v+s/9APyRG5JsUP3k3/DIiGHsVe1wHLE6r5AEdT51OQ=; b=PXjyc+z4/Q7dRQ8R8yyXrgWlwD9HhE6ZYo8wJQy4iZzywve/MwsnqpXrnYjo0y0Lr1 naaGGRj/9zCNsg4hAJXzP/RUBH2z+9/Q5F1OGKIOQIYctZhJL1OOGIdmBDweGRLlppBZ JSOo5r8M8clgYyraeHnl7Fip848qHP593S9IZC0y1ZBCmpEUzwvDrve6xrsgOYAfXFgJ oNTKfdTOkvEye7QntBa/Y41Le+m+2LdYYNcm3/TJhZw7bT6sc3379bDVIMVm4qAcqt9J OKPLcy9AGE6ZNFw3p6JonpFr92IrkwIpAzp67QNuTIgCL9CJ0UXni4sBrEmABK1Hx56d NFQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=v+s/9APyRG5JsUP3k3/DIiGHsVe1wHLE6r5AEdT51OQ=; b=28Vatf/RsHiAx11Pm7mszV+JUQBJorPZLLfhV+Fk6Bgi14yJnCQin0fykNOm7Z6KW+ 44Tc66m0kI0IAWrK4fIQPJX80b95lWcrn4eUMmELI12gW1IpMoSw/2RuMuIJim0SAYuQ R7yQMwk6deC8MeXG+NbfvdJ++yDQ9THSPGCfqEPzhkCOSMeLo8SImJSk4ZWAtwcN6Y34 UzzdyWAfcm4r8KD3a/L4vq5hLLucNYVuhKqXcg3+Ifa5IK1jlwPVFsWf49rh3lR7g5pL s9cn+9bKBjlyOSWQb6m97j4uMU2MFJCXqSFTeMNLRCnluZ5Dus0dn/OmR1Ik1tb2Yi9U xTNw== X-Gm-Message-State: AOAM532o1vkLLX0sPaVDJkCmI3RqljmJgKalhwIOKY94r60zEGVyrDQd MZ6wQko6gLDMs/UnYPfPBysO7uyUjhvs0A== X-Google-Smtp-Source: ABdhPJzdgxc8QFtd4sDkPYM7gBMdkyMB8xGKDQvrjYFZ3qml6F0ooSgmaJwZ1tLGEpF5MCLATl4pIQ== X-Received: by 2002:a37:68d:: with SMTP id 135mr12521272qkg.427.1637822621003; Wed, 24 Nov 2021 22:43:41 -0800 (PST) Received: from hurd ([207.35.95.55]) by smtp.gmail.com with ESMTPSA id u11sm999762qko.33.2021.11.24.22.43.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Nov 2021 22:43:40 -0800 (PST) From: Maxim Cournoyer References: <20211125012443.21840-1-zimon.toutoune@gmail.com> <20211125012443.21840-3-zimon.toutoune@gmail.com> Date: Thu, 25 Nov 2021 01:43:39 -0500 In-Reply-To: <20211125012443.21840-3-zimon.toutoune@gmail.com> (zimoun's message of "Thu, 25 Nov 2021 02:24:43 +0100") Message-ID: <8735nkbuqs.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637822677; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=v+s/9APyRG5JsUP3k3/DIiGHsVe1wHLE6r5AEdT51OQ=; b=aSdIoc/7LG61lNjyc7kz2hLiBjmPRls9Tr10mbtoNfuEdYMlqjWENMQGP0hW3HT9rSyKo1 N6OyXPjlAnWWmYwNiWU/quXpOMQzySVt9BqZl7bGE5trOM7+Qs2X9Ac93ZeGxfp44fxNT8 OAKneaYTlU59pjADl6lu2WJ3Tmz0BZKYzoOFU0OSftGeQtSm92B6i9erg2/SK5HywgvsHO Hqsr67ftoIUECZh7eEDWeaIEqnMaG3tJFGuigbYcPB4Xi/LtOmrsiLj7pmwKHVB8A86w4/ v8PZPecUer5X+Wce/RPO8pS2lUZmWEyUBddDoefxNPtZUPuXaHhqyVyZO/ui0g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637822677; a=rsa-sha256; cv=none; b=LVAsfz5sPttJ7afrxbFPzHpICk0nUrnq8lJN3K459BXalwOIcP1NkSXFIaM38jl9KL++7v DOBnC8YG9xlRjzFJa8Af/6fsaZGPQq/azc5hAaNBHs9b4bwLU5Q6kD9qovp0XfW3e54xZS aYBBnHhetseReFS/BqxPrEPlYOgxXnURBpEUeZGEiXYuo5iyW2om4WekpwBS9PIndDPjf7 eGIQInpi7hvD1wo4IziFtpOrypwGr2tHU/xZNxwrcNv/ox2YGudP6ZuahtCyQknQUtVPci op1OdZKJVn2asT2qLhEIgYfrWrXnCmKRQpUHYH7dOmUiY3EyfUQluCCLPZ/dQg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=PXjyc+z4; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.79 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=PXjyc+z4; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: E3B7133AD9 X-Spam-Score: -1.79 X-Migadu-Scanner: scn1.migadu.com X-TUID: tOJIPSfFY9u5 Hello Simon, zimoun writes: > The tests are defined by the script 'test/runtests.jl' from packages and = the > parallelism depends on the implementation of this script. Therefore, 'ju= lia' > is launched using local worker processes accordingly with 'parallel?'. > > * guix/build/julia-build-system.scm (check): Set JULIA_CPU_THREADS, add > options '--procs'. > * guix/build-system/julia.scm (julia-build): Add 'parallel-tests?'. > --- > guix/build-system/julia.scm | 3 +++ > guix/build/julia-build-system.scm | 9 ++++++++- > 2 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/guix/build-system/julia.scm b/guix/build-system/julia.scm > index 2998663df1..6261f8a55a 100644 > --- a/guix/build-system/julia.scm > +++ b/guix/build-system/julia.scm > @@ -2,6 +2,7 @@ > ;;; Copyright =C2=A9 2019 Nicol=C3=B2 Balzarotti > ;;; Copyright =C2=A9 2021 Ludovic Court=C3=A8s > ;;; Copyright =C2=A9 2021 Jean-Baptiste Volatier > +;;; Copyright =C2=A9 2021 Simon Tournier > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -79,6 +80,7 @@ (define private-keywords > (define* (julia-build name inputs > #:key source > (tests? #t) > + (parallel-tests? #t) > (phases '%standard-phases) > (outputs '("out")) > (search-paths '()) > @@ -98,6 +100,7 @@ (define builder > #:source #+source > #:system #$system > #:tests? #$tests? > + #:parallel-tests? #$parallel-tests? > #:phases #$phases > #:outputs #$(outputs->gexp outputs) > #:search-paths '#$(sexp->gexp > diff --git a/guix/build/julia-build-system.scm b/guix/build/julia-build-s= ystem.scm > index 41c69665c6..f0dc419c17 100644 > --- a/guix/build/julia-build-system.scm > +++ b/guix/build/julia-build-system.scm > @@ -1,6 +1,7 @@ > ;;; GNU Guix --- Functional package management for GNU > ;;; Copyright =C2=A9 2019, 2020 Nicol=C3=B2 Balzarotti > ;;; Copyright =C2=A9 2021 Jean-Baptiste Volatier > +;;; Copyright =C2=A9 2021 Simon Tournier > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -103,11 +104,15 @@ (define* (precompile #:key source inputs outputs ju= lia-package-name > #t) >=20=20 > (define* (check #:key tests? source inputs outputs julia-package-name > + parallel-tests? > #:allow-other-keys) > (when tests? > (let* ((out (assoc-ref outputs "out")) > (package (or julia-package-name (project.toml->name "Project.= toml"))) > - (builddir (string-append out "/share/julia/"))) > + (builddir (string-append out "/share/julia/")) > + (jobs (if parallel-tests? > + (number->string (parallel-job-count)) > + "1"))) > ;; With a patch, SOURCE_DATE_EPOCH is honored > (setenv "SOURCE_DATE_EPOCH" "1") > (setenv "JULIA_DEPOT_PATH" builddir) > @@ -115,8 +120,10 @@ (define* (check #:key tests? source inputs outputs j= ulia-package-name > (string-append builddir "loadpath/" ":" > (or (getenv "JULIA_LOAD_PATH") > ""))) > + (setenv "JULIA_CPU_THREADS" jobs) > (setenv "HOME" "/tmp") > (invoke "julia" "--depwarn=3Dyes" > + (string-append "--procs=3D" jobs) > (string-append builddir "loadpath/" > package "/test/runtests.jl")))) > #t) I've applied this series as of commit 905b090582e5c03ef4fb183fda0a1ababf5cb284. Thanks for the great hacking session (and result :-)). Closing. Maxim