From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id eAvxEiVKomH8iAAAgWs5BA (envelope-from ) for ; Sat, 27 Nov 2021 16:09:25 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id OKuBDiVKomH4KgAAbx9fmQ (envelope-from ) for ; Sat, 27 Nov 2021 15:09:25 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CE65E3923A for ; Sat, 27 Nov 2021 16:09:24 +0100 (CET) Received: from localhost ([::1]:57184 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mqzKO-00019T-1w for larch@yhetil.org; Sat, 27 Nov 2021 10:09:24 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36722) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqzK2-000196-Qo for guix-patches@gnu.org; Sat, 27 Nov 2021 10:09:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:51077) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mqzK2-0003QE-Il for guix-patches@gnu.org; Sat, 27 Nov 2021 10:09:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mqzK2-0006vh-E3 for guix-patches@gnu.org; Sat, 27 Nov 2021 10:09:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51663] [PATCH] gnu: u-boot: Fix rk3399 boot from emmc. Resent-From: Pierre Langlois Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 27 Nov 2021 15:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51663 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vagrant Cascadian Cc: Pierre Langlois , 51663@debbugs.gnu.org Received: via spool by 51663-submit@debbugs.gnu.org id=B51663.163802571326593 (code B ref 51663); Sat, 27 Nov 2021 15:09:02 +0000 Received: (at 51663) by debbugs.gnu.org; 27 Nov 2021 15:08:33 +0000 Received: from localhost ([127.0.0.1]:34390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqzJY-0006uq-Sk for submit@debbugs.gnu.org; Sat, 27 Nov 2021 10:08:33 -0500 Received: from mout.gmx.net ([212.227.17.22]:48791) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqzJW-0006uS-Ku for 51663@debbugs.gnu.org; Sat, 27 Nov 2021 10:08:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1638025705; bh=AbwgBfVYJ+CD3nq7CbKaLtzgdjeqsCXKX+HHNmGsFsM=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:Date:In-reply-to; b=Bcrhw9jvtRXY/FHdPHyhLgybLwqXtT6uD66QwNrjc/qRrSh0t4p8Trp2cu3jqcXV7 k0QTPLlrAQdK38eI/Vj6jb8/CV0nApqLkvirZoP4f5a/v75zfuFwwiuvzIEF41hHKm SlsFMXrzcr3Bbq6t2gwllzeQGBiOfVS0QCP1cs/4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from labiere ([82.69.64.142]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MbRjt-1mKONl3GUT-00bwUY; Sat, 27 Nov 2021 16:08:24 +0100 References: <87a6igav2l.fsf@gmx.com> <87sfw1fcxd.fsf@yucca> <87ee7kcf79.fsf@gmx.com> User-agent: mu4e 1.6.10; emacs 27.2 From: Pierre Langlois Date: Sat, 27 Nov 2021 15:06:18 +0000 In-reply-to: <87ee7kcf79.fsf@gmx.com> Message-ID: <8735nhd4bc.fsf@gmx.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Provags-ID: V03:K1:ZRDdHk8uG0Wu34v2BD/EG2obvfsAePIs11MUaOqijzfMAsN2wXJ ACJAi+YIBjcA29iQSyG/4E/rHuL/TN6w02sJpVp4RkLXH6VGV6OsdJRzTa3gE9FeoR52awc hmH5fpyo0/E/8Jzn1Ew10B4TJBjVPTOq0qB6ZChujKkHSkJ/EkBaDN8zbWtZ5HbrIRjnJPB McXZ3Y7Xo3+iLjEGs666w== X-UI-Out-Filterresults: notjunk:1;V03:K0:K9kg7raoZj8=:Vim2ObKn0V3tDf7ZIGbRfq KMpH6QIajAioVfaheZiLcdCrW+m8saSc1BMGtWZG3kXNX3BSGqxGA+DfHfGKpkmi7XRzy6aQ4 Jq/FkFttA8ZA2qFlE7xMIzYcmHctYJnGAPcJoQ1skw5INjwIc+Lix4wNiXmQGPMWWayljNeZ7 WUsh/nVMcR8TNK/YhNriB/YxQQMKRNgckGA3DojoX2W5GCF9f1fITsi91KQIrd0gcBo+nu4Sv TwEbhptmpOlLcysPQcTphE6C5nUut5u7ZJfQGwQ7XUqtE7wJ0gM/Dma3k0BAp20T0qGXwRNi2 pXa4ehNKpBBYHGgILKdVMk6skObAFwDk2UI09uVicpJVhYsRGGzsh0t44zHo12VF36SsNd443 b5OGVzaEeVOrgUcBQJ7WAet5Vo1FpSpbBivTgMXW5tL6c6XzoqtvF9fpF//eZpP/YM+ByTlEm KK0RhnLAQu5BF4udeFvV99KSfRlp+rkvg3PU4Wqpx5hpCuhi5FSBtqDpzLroPyuZijMhd3g5x aemkoU2zuiGqV3Hj0G6m8AWpnuhVQA+0ZM2OuIS+0B1nUh9sSRxUzny9nWGUnVWZARIA1pcH4 C8qhiEEY1avnVI4UZ72sv/Etu29JJmX8SUGqsYiblCMB7RWWz1PpjWPgLIgbXZq5r3k+89tD/ MdhF28bKd0YWpP8WVvrINJmhDfCK/5uQUABwC1b+XW8eU4FutUsH0ISjwuf0rQ5+k5lkLMWin qP10fboQHX+7AWfA/vkfsQ6a9GKASOOQwnSbAgqm9x1L2BeDUVavUnHUC7dsuEGvJ+yTMwQx9 kbkw/hrCIBWm3LyyuU3iGIhmGFaQDQsuFn5GTwroPleAP6XgcMtoQ0QdNMsY+ZoQXRjd/2Jau D5NODOr2RXymEDHjQPD0YVxMVI8bhekk1gQQcCOhtoDkSjabaCMlzcncrCa/LC+cLKjD4FdfO 4SqJ+uqursqaxX5fWuAr19ld+RoOJpg65UeaWsoyAVPhJ1XrI300LdFUzqggs98fxwdvDrtUO 6BAPAYuCQhFz4GESABZJiPb1k9LuKUStiblEJZDXA1DUSVoDxWhgYvO2n9IEACpBxvs6t58Qg wh5Zf7FAx3jVQg= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1638025764; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=TY5GrHEvNkPq0Y8Y2ygzz1FIjU4T3nCQr6/tO/JfLs8=; b=ik7QCm0xqsOsRFwQXsSd5Exq5JTlSdgLEA2rNKoFQx5D/FRQC7M+C8MNEhjkAqAeHk9Tmu EKodFM0p5+knGaDu+PhfdAkBQVrEbD3nxJViaCFe59CFrAZYGe50gc/JdwqDKsbZbvVvog IFJODsLLzimA8w7+F3nzhyR1Q7cSkfzboT6TcW46im0Gu4gO1qcPIpbIfNQ/eUwENjzYJX SXB/IS9cboj/EdQK4dJuMYbOhhs9ClU/TzvULpi0wqJZcPXLrXWjlMj1zXpg2x1fW/3kLS HzHbFet3wQqaUD067mF9uNCi+OxgiiFg8pNNVmu6FFEZOuz7Y5/GzCESXgUPXg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1638025764; a=rsa-sha256; cv=none; b=IfAI7r05ZktTNXK7ZMGGn1gOEVd+x3Fnz3HWP4c6ttxFEIluvVJsPs/LDL2q5U8+JlYHAG NX5OyXpI1OhL4InSMcovRKI46jMPTljoGMxAMhCUZF6eFnseQEWkRYecAkwkREzJfCLkbY UJHfnWMGe74aGMen8M6sz8OZ+oNufztsnx/v/0mmbXwaqFcalMisP9p+DXEPTCs1q2Qxzb pTBWhfXdMTPc/HEyP3hUro1v9/2gQ5YK++wiVYRQZO36Ja3YtBxh/+GK+GLle5jeXbLFMz Sw194MgR3YC1LxYWfJfp+0oO8VPsQh2JsvXo7BbbSnI7DZ1idkEc7vywElZqqQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmx.net header.s=badeba3b8450 header.b=Bcrhw9jv; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmx.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.91 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmx.net header.s=badeba3b8450 header.b=Bcrhw9jv; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmx.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: CE65E3923A X-Spam-Score: -3.91 X-Migadu-Scanner: scn1.migadu.com X-TUID: pvBNoksnk8MR --=-=-= Content-Type: text/plain Pierre Langlois writes: > [[PGP Signed Part:Undecided]] > Hi, > > Vagrant Cascadian writes: > >> [[PGP Signed Part:Undecided]] >> On 2021-11-07, Pierre Langlois wrote: >>> I'm afraid the last u-boot update broke booting the rockpro64 and >>> pinebook-pro from the eMMC card :-/. Going through the u-boot ML, I saw >>> that it was reported [0], and this fix [1] should be applied. >>> >>> So here's a patch! I tested it on on both the pinebook-pro and >>> rockpro64. >>> >>> OK to apply? >>> >>> Thanks, >>> Pierre >>> >>> [0]: https://lists.denx.de/pipermail/u-boot/2021-November/466329.html >>> [1]: https://patchwork.ozlabs.org/project/uboot/patch/20211101044347.17822-1-yifeng.zhao@rock-chips.com/ >> ... >>> diff --git a/gnu/packages/patches/u-boot-rk3399-enable-emmc-phy.patch b/gnu/packages/patches/u-boot-rk3399-enable-emmc-phy.patch >>> new file mode 100644 >>> index 0000000000..f14a9ce104 >>> --- /dev/null >>> +++ b/gnu/packages/patches/u-boot-rk3399-enable-emmc-phy.patch >>> @@ -0,0 +1,26 @@ >>> +adapting commit ac804143cf ("mmc: rockchip_sdhci: add phy and clock >>> +config for rk3399") to fix the issue "Not found emmc phy device". >> >> I'm a little confused about this comment in the patch... is ac804143cf >> the commit which fixed the issue or broke it? is there a reference to an >> upstream commit and/or issue that fixes it? > > Yeah it's not very clear to me either, I think ac804143cf is the commit > that introduced the regression indeed. Doing a bit of digging, I don't > think the fix was merged upstream yet though :-(. > > Instead, I see Fedora opted to revert the problematic patch, along with > another dependent one. Probably before the fix was posted to the list: > > https://src.fedoraproject.org/rpms/uboot-tools/c/37df227bc0961f9f0dc4dafa9e983290dbdb2bc3 > https://bugzilla.redhat.com/show_bug.cgi?id=2014182#c3 > > Given it's not upstream, it could be safer to do what Fedora did and > revert a couple of patches, what do you think? The fix is from the > original author so I'm inclined to trust it, I'd be surprised if it > doesn't get merged. Taking another quick look today, it seems Fedora now picked up this patch, yey! https://src.fedoraproject.org/rpms/uboot-tools/c/9eb973e7d2ab74341c0eb7312576b6f016ec03d4?branch=rawhide I'm more confident it's the right fix now so I've gone ahead and pushed it. Thanks! Pierre --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFMBAEBCgA2FiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAmGiSecYHHBpZXJyZS5s YW5nbG9pc0BnbXguY29tAAoJEKj8nkR/T31UObMIAK1MtsB1gI+hvRUu5Zlv8irq ahPQTqhrehfakEsde+SgBEbjkRiT09n/+tyxsBoK4zmy1ulOONzDSwfc7iucdIry 6booZJuo8VZkItXZYzBA0+32uBF4rvXqyFRZFgb+fctV+XhTsTjRxCk5gSd3P3W4 slh0gmJ/CR7SZRC3EInzaCemV3rvgTqEgz6k5yKdONQsb+LWADWs1IL45e9fVMjP FOwLsxMb/EckfvHa+LK32FJfPFJ/mnzja9Sqph0A1pN7y+xDVTH0J/PJyEaVZegM 5pvBwERg5oLfVe7PI+C+EeIpA0+E3Scu7rCu/AgZYduH38BcMdQdtUSzdUu0+7o= =mfKK -----END PGP SIGNATURE----- --=-=-=--