From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id ANS9J8kvvmGgqwAAgWs5BA (envelope-from ) for ; Sat, 18 Dec 2021 20:00:25 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id ILdVI8kvvmHJYQAAbx9fmQ (envelope-from ) for ; Sat, 18 Dec 2021 19:00:25 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 614E5FF30 for ; Sat, 18 Dec 2021 20:00:25 +0100 (CET) Received: from localhost ([::1]:60004 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1myewR-000126-HY for larch@yhetil.org; Sat, 18 Dec 2021 14:00:24 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60670) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myew8-00011r-Jy for guix-patches@gnu.org; Sat, 18 Dec 2021 14:00:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60526) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1myew6-0003Mv-CJ for guix-patches@gnu.org; Sat, 18 Dec 2021 14:00:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1myew6-000803-Ap for guix-patches@gnu.org; Sat, 18 Dec 2021 14:00:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH v5 06/45] guix: node-build-system: Refactor patch-dependencies phase. Resent-From: Timothy Sample Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 18 Dec 2021 19:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 51838@debbugs.gnu.org, Pierre Langlois , Jelle Licht , Philip McGrath Received: via spool by 51838-submit@debbugs.gnu.org id=B51838.163985397530691 (code B ref 51838); Sat, 18 Dec 2021 19:00:02 +0000 Received: (at 51838) by debbugs.gnu.org; 18 Dec 2021 18:59:35 +0000 Received: from localhost ([127.0.0.1]:43839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myevf-0007yx-AN for submit@debbugs.gnu.org; Sat, 18 Dec 2021 13:59:35 -0500 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:47259) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myevd-0007yi-CG for 51838@debbugs.gnu.org; Sat, 18 Dec 2021 13:59:33 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id CB51932009F8; Sat, 18 Dec 2021 13:59:25 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sat, 18 Dec 2021 13:59:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=gsqD1q bsx/EJT3aNzBsfbHDGzFBekr5OZxR4iufdv2g=; b=aTBtmANrmNsMw1OdZ2bUq4 J1u1XLR8/+qQIngquT8O7vq+6wpbhs5yfNNioY9pTrGKqF4mteGTFpF+y2Hyssur W2bCiQbBEb1cTPXZqIsqohDagI59WMPg/1yMoVbHouwDoSVmRXb0jZfhbJJePSGV Qsq45bfGdn49aIfU62NU8A8f7E6H1bevN3tUlc8Df8FBLYLpwc0qc+QWk3T53jHp 0p3JQ5kDfo9o0Ub7WO0bn85p4oaAZrLTe4pGZtodk193dREWAtpOF9eopxU5ZTTm PJkIZbR0SmbyLljD7RYAoPDtiIzu0TOsNn5mapueUHJzK6T2ylM6K3yY1qQVszbQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrleekgdduudekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefvihhmohht hhihucfurghmphhlvgcuoehsrghmphhlvghtsehnghihrhhordgtohhmqeenucggtffrrg htthgvrhhnpedugeefhfegkeeuieejueehffeljeevudeitefhhfdutefgudffledukefh feeltdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hsrghmphhlvghtsehnghihrhhordgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 18 Dec 2021 13:59:24 -0500 (EST) From: Timothy Sample References: <20211213060107.129223-1-philip@philipmcgrath.com> <20211217020325.520821-1-philip@philipmcgrath.com> <20211217020325.520821-7-philip@philipmcgrath.com> <17f63a58ea9b462e67847f9c7698a119e3915a08.camel@gmail.com> <650d1c43-8106-e7e9-5855-29cfa5f9d147@philipmcgrath.com> <9fe83c79f796bb323816d2c02e45b4277680eda0.camel@gmail.com> Date: Sat, 18 Dec 2021 13:59:23 -0500 In-Reply-To: <9fe83c79f796bb323816d2c02e45b4277680eda0.camel@gmail.com> (Liliana Marie Prikler's message of "Sat, 18 Dec 2021 18:52:19 +0100") Message-ID: <8735mp3fjo.fsf@ngyro.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1639854025; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=gsqD1qbsx/EJT3aNzBsfbHDGzFBekr5OZxR4iufdv2g=; b=PweEybsdTwDjO9AYoQ/F6NrojdwwNSDpYfIS95ih3TLArdbpzqdwldC1hIMX58/jGgbzIS PlP6oyr7XWV4v35I8EElqGArxv95fZ1Xz0Lrzn7P0a62n6B/eZMHSCI4vbXOrczVjymVmu SbMTfxz5JHerNOjX3Db6F2qHtRBKeqw6c9oIABhkoV1bW6gCqOvudie1bRlf7k3nSEDrta xOb6CTxuenbYNhvg7co9Wut0F95x9pQuEQZvsUs3obaizYoWphVP1GMhJy/y+/o7uNnWkC xjsxjeetlnR2FFNY19UQDEirZYc5EEYQaG/ffxMhQSTnbUtMJYZSr6EuUOBUcg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1639854025; a=rsa-sha256; cv=none; b=Zt1KtEhgm6oyi/HxGl2jyIVg0RZDlbSD1cAJyc1vIQm0UgoMRrt/hD5OiWSwBpQuAqFtQE VtByVxSK0y33Pfv2evSy2Nj+xVaqdfFENG+1vcjwx+NDD1hvhLp6yhOsrA28my5uyM+ORl vEurLkd3iwNY8V9M4x/AX/4JZOkUa4fZzmx965lOnGt28elbtzl9b/PKP5M/KhQx1AHQFP mEd1f/l9SmwGAlUYHeBu8oXuQoQ62MSzF8vSFzOEJ1gmoOd7+tPaxACtLC9gL2RWtQTFFY bv4jIzglFCCHRS9WlKbgPXaZw83xdcXJoIdM9atKleoFYhJWmjjObOtVmBljlQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=aTBtmANr; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.71 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=aTBtmANr; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 614E5FF30 X-Spam-Score: -1.71 X-Migadu-Scanner: scn0.migadu.com X-TUID: zx3Xjr76TjFK Hi Liliana, Liliana Marie Prikler writes: > Am Samstag, dem 18.12.2021 um 12:03 -0500 schrieb Philip McGrath: > >> All of that reinforces my sense that we should not try to change this >> here. > > I think you misread me here. One thing that's bugging me is that you > (just like whoever wrote this before) strip the @ only to reintroduce > it. I think it'd be better if (resolve-dependencies) simply took a > list and the let-block deconstructed the json. > > As for the package-meta -> package-meta conversion, imo that could > perfectly be done with match or SXML transformation. WDYT? I think that, as a patch, this is a clear improvement over the existing code. Is it perfect yet? Maybe not. Further improvements can always be made. The NPM package set is small enough that build system changes can be committed directly to master. Each of the three of us has spent more time writing about it than it would take to reimplement it! :) To me, it would be unwise to hold back this series because one of the patches replaces ugly and broken mutations with merely ugly mutations. -- Tim