From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id UJUMIvkd2GEc2AAAgWs5BA (envelope-from ) for ; Fri, 07 Jan 2022 12:03:21 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id kEO3Gvkd2GGmqQAAG6o9tA (envelope-from ) for ; Fri, 07 Jan 2022 12:03:21 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CEDDA148DF for ; Fri, 7 Jan 2022 12:03:20 +0100 (CET) Received: from localhost ([::1]:57128 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5n1j-0005t3-Nx for larch@yhetil.org; Fri, 07 Jan 2022 06:03:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43266) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5mxb-0001oq-9V for guix-patches@gnu.org; Fri, 07 Jan 2022 05:59:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:50253) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n5mxa-0000hn-Mg for guix-patches@gnu.org; Fri, 07 Jan 2022 05:59:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n5mxa-0006VL-F9 for guix-patches@gnu.org; Fri, 07 Jan 2022 05:59:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53063] [PATCH wip-harden-installer 08/14] installer: Use run-command-in-installer in (gnu installer parted). Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 07 Jan 2022 10:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53063 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 53063@debbugs.gnu.org Cc: dev@jpoiret.xyz X-Debbugs-Original-To: Josselin Poiret via Guix-patches via X-Debbugs-Original-Cc: 53063@debbugs.gnu.org, Josselin Poiret Received: via spool by submit@debbugs.gnu.org id=B.164155312524961 (code B ref -1); Fri, 07 Jan 2022 10:59:02 +0000 Received: (at submit) by debbugs.gnu.org; 7 Jan 2022 10:58:45 +0000 Received: from localhost ([127.0.0.1]:43152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5mxJ-0006UX-Fn for submit@debbugs.gnu.org; Fri, 07 Jan 2022 05:58:45 -0500 Received: from lists.gnu.org ([209.51.188.17]:52346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5mxH-0006UM-38 for submit@debbugs.gnu.org; Fri, 07 Jan 2022 05:58:44 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43132) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5mxG-00010i-Pt for guix-patches@gnu.org; Fri, 07 Jan 2022 05:58:42 -0500 Received: from [2001:470:142:3::e] (port=49146 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5mxG-0000eT-E4; Fri, 07 Jan 2022 05:58:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=MdgD06YvEnL4C66l9jOfhgNH+RoFgWTxhOM+q9n0NZQ=; b=HAdyZpodq7QIBjOq83a3 mUnv3QeuMHFcJt5aU5l3KyYw/JlRfJbszD73UMfl41CJvzDQwHsBUF1ncs8IB9VfOwwIp2iJ4mChI F4IEQGXzKqzl8JfYiHVvS4Fh3upqwcy+t8vZfl/7kltrlhXVgoyub4pXLw4gZZm5eBEt9cpxT2t3p qI7DM1SDcADlctVwCbR9tBK6UkrLLGj7HnqGEnKNjeCLYgONVil7yvYJK3sdWwk7QGv2m90Am7OU6 OhhHtDYD0ILUQzNp8PotlMSYZP8wRLo9Ddltqm+YwVMRmsxhUxO+IowSGp+w5NYQFuUP3vePHrld2 DilqC96FdVeTeg==; Received: from [2a01:e0a:19b:d9a0:2f3b:16f2:b776:3ef9] (port=51060 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5mxG-0003co-I6; Fri, 07 Jan 2022 05:58:42 -0500 From: Mathieu Othacehe References: Date: Fri, 07 Jan 2022 11:58:40 +0100 In-Reply-To: (Josselin Poiret via Guix-patches via's message of "Thu, 6 Jan 2022 23:48:06 +0100") Message-ID: <8735lz4xsv.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641553400; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=MdgD06YvEnL4C66l9jOfhgNH+RoFgWTxhOM+q9n0NZQ=; b=HWj4M60SWlNneFhNJTu8jNRIJKNUB7H3VIjhpe1NON05EZZlR5FZsdKlKvJC6r6N/a/Yj7 L+jjqNOY/L9CSYfe8/EtKf0v+8/LLr+FPYDz8kSZN6pWJforUmILlIKsHx09XvLTjIrPep VlKrGmStJBMFdiCncblp8tetBzvYj5WMEsWYyDlxPUWpquFJewdPCSx107UUhEgxL1KzTe 16G85caI1Z5iWWTYx4iStoxZI5QF9Z7yGJjlKQiHIqmsuAhzQFyLCBP4PSYhlbjGGSZh8i FhvV+SfWUyu4tTYEnzOaMijmI1xjDv6ZxX9LacNIHXtIcKPcud+cqRsKjHlUgA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641553400; a=rsa-sha256; cv=none; b=hxMZR638H5EYZDaSJ5XKGBCV4vgoQ74tNX3bG1oVqWnGVzkghYVxHYau7pA9s2ldnr8aCQ Y/lYtBhwfCvh3wJxYjKFn6MxxvFIvYN75sahZxQv3Blu7KPvN9y6iw/j2D7S1SX8lka0+x saj/xRmfAp4MFU3ja9FxVOLjhFS6jrx4tVh802BnHPOpMa5tzF7sl8eOOAWTLqQ4TkTLI6 G6K1LvMnwSlSW4APIjqy+Dsf0M6wjUuXOxXi6qbRQdZhsmcHbhZim2ZSmp1XopHayDrmRz +6I7N2OjrsMy4bGnprTiNieOFuK1e+ZK5jTImZF6918oS8w3bjKA0fHtkwTkmA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=HAdyZpod; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=HAdyZpod; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: CEDDA148DF X-Spam-Score: -4.00 X-Migadu-Scanner: scn1.migadu.com X-TUID: G2XPI+eXqCin Hello Josselin, > * gnu/installer/parted.scm (remove-logical-devices, > create-btrfs-file-system, create-ext4-file-system, > create-fat16-file-system, create-fat32-file-system, > create-jfs-file-system, create-ntfs-file-system, > create-xfs-file-system, create-swap-partition, luks-format-and-open, > luks-close): Use run-command-in-installer. > (with-null-output-ports): Remove. Overall the series looks really nice! This one is a bit problematic as it breaks the installer tests because the extra "External command" pages are not handled. --8<---------------cut here---------------start------------->8--- Jan 7 11:44:28 localhost conversation expecting pattern ((quote list-selection) ((quote title) "Partitioning method") ((quote multiple-choices?) #f) ((quote items) (not-encrypted encrypted _ ...))) /gnu/store/6c0dnvp7a1sym52s4yrjzm3wvbsv1666-shepherd-marionette.scm:1:1718: ERROR: 1. &pattern-not-matched: pattern: ((quote list-selection) ((quote title) "Partitioning method") ((quote multiple-choices?) #f) ((quote items) (not-encrypted encrypted _ ...))) sexp: (confirmation (title "External command") (text "The installer will run the following command:\n\"dmsetup\" \"remove_all\"\n")) Backtrace: Jan 7 11:44:28 localhost installer[193]: running form # ("External command") with 1 clients 2 (primitive-load "/gnu/store/qpsq43z9rdb7hlabzzyz6p8pzxb?") In ice-9/eval.scm: 191:35 1 (_ #f) 619:8 0 (_ #(# #)) ice-9/eval.scm:619:8: Throw to key `marionette-eval-failure' with args `((quote (choose-partitioning installer-socket #:encrypted? #f #:passphrase "thepassphrase" #:uefi-support? #f)))'. note: keeping build directory `/tmp/guix-build-installation.drv-0' builder for `/gnu/store/6xrbsa0psm30189rigjif17c6rvi8h9g-installation.drv' failed with exit code 1 --8<---------------cut here---------------end--------------->8--- Maybe we could only display those "External command" pages when the command fails? Another issue is that if any partitioning command fails, the installer keeps going. Maybe we should instead propose to abort the installation or restart the partitioning step? Thanks, Mathieu