From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id kMB0OvQM9GFdhgEAgWs5BA (envelope-from ) for ; Fri, 28 Jan 2022 16:34:12 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 8GIuM/QM9GG0PAAAG6o9tA (envelope-from ) for ; Fri, 28 Jan 2022 16:34:12 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 68B82355C0 for ; Fri, 28 Jan 2022 16:34:12 +0100 (CET) Received: from localhost ([::1]:35746 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nDTGN-0004mD-35 for larch@yhetil.org; Fri, 28 Jan 2022 10:34:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57364) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDTCP-0001z2-2u for guix-patches@gnu.org; Fri, 28 Jan 2022 10:30:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39105) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nDTCL-00066G-UP for guix-patches@gnu.org; Fri, 28 Jan 2022 10:30:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nDTCL-0005J3-Qt for guix-patches@gnu.org; Fri, 28 Jan 2022 10:30:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52388] [PATCH] build-system: emacs: Add generation of -pkg.el files. Resent-From: Andrew Tropin Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 28 Jan 2022 15:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52388 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler , 52388@debbugs.gnu.org Cc: Ivan Sokolov Received: via spool by 52388-submit@debbugs.gnu.org id=B52388.164338375920297 (code B ref 52388); Fri, 28 Jan 2022 15:30:01 +0000 Received: (at 52388) by debbugs.gnu.org; 28 Jan 2022 15:29:19 +0000 Received: from localhost ([127.0.0.1]:60241 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDTBf-0005HI-BR for submit@debbugs.gnu.org; Fri, 28 Jan 2022 10:29:19 -0500 Received: from mail-lf1-f54.google.com ([209.85.167.54]:35417) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDTBc-0005H2-VR for 52388@debbugs.gnu.org; Fri, 28 Jan 2022 10:29:17 -0500 Received: by mail-lf1-f54.google.com with SMTP id x11so12532297lfa.2 for <52388@debbugs.gnu.org>; Fri, 28 Jan 2022 07:29:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop-in.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=wILeWRu4b2dBFxX3KUIJqitIXWi0hKUhePMng1llYjY=; b=j9olKjnLMULkFZu989JAo1JYX338vYyzfzRhkEOaB3ruONrXc/z66vJPA9sbEwsH6P isKjKdr8T/pcuptuXnasVUvPVIbzxyeECi7v4Hg3EF5tkakbD8DVwIsaxWMxgVngiLYv /qiFp4QeHUyInqsej1oTywGG08SpP8Dh8kkCke5Tpd0crq/694HNUafsIoc18jqTdRvK zxPXmetpyN0iifDiXmNHQxLAF3F4bO/YxtupswkzdqZ/0dEwGVjcmmuwZPcp1B6tI01c +u64D8cfbk7gcIUYX0ZtV2OplU+1W/3XXu3IFfcY3AEs+1eBpDIk94LFwtUIBzK2YH7h wHxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=wILeWRu4b2dBFxX3KUIJqitIXWi0hKUhePMng1llYjY=; b=7o9FlzgoVVBoS1qCY6oWlgckAQziHSb/4baapSmsrhqF3xTsn4e7WF0qyfsojcOdWo gtCdmcmZ+ZQBDiRt4CzGIDTIBhF5TRAs6DZUf8XOwbSAwb/kE/Mmgi7cVFVKMD3AYA5q X7toBPOmf313Z92xYXKl9N2zMRG46jyTvDYHKgrK+mHSS6SDHrvbo6uV+eFR62763iP0 P7+nqKY+AX5k9rtY9vlHSLBKJ7OEo1At0tTQ2Vn3pYEjyvMG7eWEgvvx8Gdu/3YQR9gR 8g2+xhydXpKP/R/5RAdSkLt9JF6JcmiawU7xwN59qRBn0PwZaK2QmkZ9Pcr9m3GpaDoM 1eeQ== X-Gm-Message-State: AOAM531NiS1M84nxzL5/Hi3JL1tp17iHzNtcMvk1GZ023oAyoF3QzJfJ yrkmHKWaB9DNRwcC3qwZdFnrpg== X-Google-Smtp-Source: ABdhPJzUeFrPoC5ScRbgJpRoxGeiOQHTNp7FmL05iqm1F63nAM6GDgbPpc1Xj7ztHhT+hLlicVW8nQ== X-Received: by 2002:a05:6512:96a:: with SMTP id v10mr6275555lft.497.1643383750870; Fri, 28 Jan 2022 07:29:10 -0800 (PST) Received: from localhost (109-252-135-33.dynamic.spd-mgts.ru. [109.252.135.33]) by smtp.gmail.com with ESMTPSA id c27sm2565218lfp.103.2022.01.28.07.29.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jan 2022 07:29:09 -0800 (PST) From: Andrew Tropin In-Reply-To: <6dc75712f3ea1cfe12594e45ae977f8f4e8543fb.camel@gmail.com> References: <871r2mrleb.fsf@trop.in> <80cfa468ef91649dce477779a70d3a8ce64fd0e4.camel@gmail.com> <87zgnp8f0n.fsf@trop.in> <6dc75712f3ea1cfe12594e45ae977f8f4e8543fb.camel@gmail.com> Date: Fri, 28 Jan 2022 18:29:06 +0300 Message-ID: <8735l73mm5.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1643384052; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=wILeWRu4b2dBFxX3KUIJqitIXWi0hKUhePMng1llYjY=; b=qmByiCQLuNr3PDUUTDkpfKS7vyYXKRsIj40jyXLacF9SkCC9cM8xh0h5Fo7JSNsHOBntsJ FqIzdVKt2UBPWtfR/owtG8NoFLZD8CrKKI8qTIfBnHtRPoxLp5EGARKNKqyzYpkDmp3erL EpZry46Vcmc43x9L6cArQAtgmfrVEhIy6Fqt3Ltt26/bOrgR3iECODx3AURT5+oL9PX3LB vMC7Bz9roAesiZ+MBx9U+sdPlR3QV6dJagPWkC4S+N+RI0pr4zO6NZ2IrcaFPPR+0R1hkU 9HYBLbDJhjDgCLCvxi/Sf7Evk5HpRvi8bj4hvVH2wu1je0e7EVvCXDQIa8TtEA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1643384052; a=rsa-sha256; cv=none; b=KeHmAl6EWABjgX4KBKVaCuAp7SRsxjPTtNaOz/YA3Xd222t0Qgob37oKQ/xomJ2i9YOD90 pSK/l8A+fHXX7WGfWCppN2GqZO/qbYAHs/+Abdyogmo2PaJRN8Qqn1iRtPM5glqd8/qlck HTMQCCVPy3BS03cTPkT3iQzC/JfBbx4hzSDXOgsxd1GiggUQ+0HfwHBBJuU84v8uNGnHs3 ZkmgAchrDiBTYp2PKKXEivCKeXmchgp6mtPCYThLZZF2ZnFl2es/XEZ01p+nNJwakqwxax BssiLiTa18FfP4qqcEVAJxVtVn982Kx+LwDSa+Cv+yjWJSWQrcCbz3WK8clwPQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trop-in.20210112.gappssmtp.com header.s=20210112 header.b=j9olKjnL; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.53 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trop-in.20210112.gappssmtp.com header.s=20210112 header.b=j9olKjnL; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 68B82355C0 X-Spam-Score: -4.53 X-Migadu-Scanner: scn0.migadu.com X-TUID: TOvxy4KTo5EV --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2022-01-21 17:57, Liliana Marie Prikler wrote: > Hi Andrew, > > Am Freitag, dem 21.01.2022 um 15:11 +0300 schrieb Andrew Tropin: >> > As promised, I took a deeper look at your patch.=C2=A0 As already note= d, >> > there were some clean-up actions I had to perform, such as keeping >> > to our line limit (it was not easy, I tell you) among other >> > things.=C2=A0 Also, confusingly, your condition-case code did not hand= le >> > errors and wrong handling of the version field blew up everything >> > for me.=C2=A0 Did you test this code? >>=20 >> I thought it was the version I used for past a few weeks, however I >> could send a little outdated version, not the latest one by accident. >> Tested it with guix build emacs-paredit. >>=20 >> See your fix which wraps both forms in one let, thank you, yep, it's >> very likely I sent an intermediate version of the patch >> accidentially. > Git index not up to date, truly a classic :) > >> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ;; befor= e trying to create package-desc.=C2=A0 Otherwis the >> > whole process >>=20 >> s/Otherwis/Otherwise, > Thanks. >>=20 > >> Applied on my local checkout of guix channel, list-packages now shows >> 117 external packages =3D)=C2=A0 Will keep it for a while and let you kn= ow >> if any problems will reveal themselves. > Fair enough, I'll reset my "14 days without review" clock then :) Have been using your version of the patch for a week now, added a few more emacs packages to my config, nothing stopped to build or launch, so it seems to work good. =2D-=20 Best regards, Andrew Tropin --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmH0C8IPHGFuZHJld0B0 cm9wLmluAAoJECII0glYwd6whk4P/3bkGQk6CdSoSO97J35+h2GOqaSYdGg30GG0 s2wF3h/rAq4AA7J/p4b2GI9lMQwpaD1NQ33sSb87p+2nrX8BIdk7WOxhKsBJXpis VzC74AY3IVQHWptKylHGcQIKCw+lfnaNqlSV4uoAqw6OVb4TrEa2q8AThqEcDKtL 0M9bZ5AqqN9wWlso2MVDLjjVgq8sbkBPCT/urvdgXJUGEXSRinbVjBDG5BupnRna 4CHR9C0oCcp/4bIyDOSf/wGlt7oQDGyk6G/AP+4txKCUgNOWgg47/yp+xR9krlJi WIKs+c4wUU8n50c7i4Qffzv2IlBPgi7XWF2ng1To3MLEkdcwsunEPScTnppg+aYZ JiDhhLQIpTBexIwZ0sf4hAPnGvnh8FFrijBIr/L3R4FWSHdAWRCB9/Q7LedQgOWq FyRGYkdGRIt8g2m6mqK2WX8t9fFA8HkT/VhfOrY0zBpHtzXpBiqbTMAVAwrB+I1g +jKRagq4FLlrAb37wlRTwIwtdc5bk//PMRLgQEQ9rfNO2ryeTRTylUFh3OE6F+QW Ge612QsnDMU1Zzg+waNds5QcEiiPPsXq45zdIo/jQZhWe5VwZTSFpjN5ANoX6x+1 SH/DWiMW20fx8ekgkWE9wzv6h6paLrqXjhJTaGQqwWM5CJpZyHBBWbx8TgH19moD pxjxLJwy =N5/i -----END PGP SIGNATURE----- --=-=-=--