From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id ANa+C1YvCmI9egEAgWs5BA (envelope-from ) for ; Mon, 14 Feb 2022 11:30:46 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id yNlACVYvCmLNPgAA9RJhRA (envelope-from ) for ; Mon, 14 Feb 2022 11:30:46 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CF08C32C58 for ; Mon, 14 Feb 2022 11:30:44 +0100 (CET) Received: from localhost ([::1]:53136 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nJYd0-0005tS-Qq for larch@yhetil.org; Mon, 14 Feb 2022 05:30:42 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45312) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJYcN-0005rC-Ar for guix-patches@gnu.org; Mon, 14 Feb 2022 05:30:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46013) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nJYcM-0007fq-SD for guix-patches@gnu.org; Mon, 14 Feb 2022 05:30:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nJYcM-0001q6-NK for guix-patches@gnu.org; Mon, 14 Feb 2022 05:30:02 -0500 Subject: bug#53901: [PATCH] publish: Sign only normative narinfo fields. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Mon, 14 Feb 2022 10:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 53901 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 53901-done@debbugs.gnu.org Cc: pukkamustard , Christopher Baines Mail-Followup-To: 53901@debbugs.gnu.org, ludo@gnu.org, ludo@gnu.org Received: via spool by 53901-done@debbugs.gnu.org id=D53901.16448345777011 (code D ref 53901); Mon, 14 Feb 2022 10:30:02 +0000 Received: (at 53901-done) by debbugs.gnu.org; 14 Feb 2022 10:29:37 +0000 Received: from localhost ([127.0.0.1]:39909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJYbx-0001p0-5Z for submit@debbugs.gnu.org; Mon, 14 Feb 2022 05:29:37 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:34694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJYbu-0001oe-SK for 53901-done@debbugs.gnu.org; Mon, 14 Feb 2022 05:29:35 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 3C24BB12; Mon, 14 Feb 2022 11:29:28 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zpyPBYmaLwjo; Mon, 14 Feb 2022 11:29:27 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 1046D1CA; Mon, 14 Feb 2022 11:29:26 +0100 (CET) From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20220209175224.26851-1-ludo@gnu.org> Date: Mon, 14 Feb 2022 11:29:26 +0100 In-Reply-To: <20220209175224.26851-1-ludo@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Wed, 9 Feb 2022 18:52:24 +0100") Message-ID: <8735klzqpl.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / X-Rspamd-Server: hera X-Rspamd-Queue-Id: 3C24BB12 X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644834644; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=A37eNyTYoPb/UKFea7FUkksxeLRHUzPKAMqnXZlNxjg=; b=SFc+HYufJOOzYKo8nlJspkG7/XBqfww/bHvTvJgo154+KXhm8dfoiqLn46wcc/JbtBV9Lv 7macc6dPSrHJzLXQzwU3kHVHlqVujSqHFjQeYsJ+TRIvPj8Mtv194Oyb+gdRGJSZ+/e5qL Xa56lJwv6HNAgEg0I2fhGW1Qib007wcvLiH2L4anu5MJoHMmpMMJ0yftKSB2x/yc488KUY aAaagOQuEwHUD1FTWe4cpvz/zHr9oehUYvhI4Otu4zanfzIa2WzvMRcgs9HrUEbxT8OOAU Y6vUzK3/GvD+dZwhighItpr6Q27iY8VjjJCc9bdousg/GtcsBdc8qAFRMbjljg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1644834644; a=rsa-sha256; cv=none; b=hJaSHOvVkg9E0x9yKlYFGMCE53kfPHvK+vh+Z90Og+eXRIwJlnlEw1kFcCjcM4lSJyB08w btdNwkKRL47eeehcGo9YrUs7d6BR4DVNGju1kZP8ocmJCTZfVHWkilxiBv2xIKkuXcEK1p N6NrcIDCCqbFtuEQYE7ld5dI6xvuKSJeggG5Ui2dqVMqWoMrThrKGELQKpzSOnxU3qlA+r U9VAmJbyFvFkeNipeuPQ1N7/yw59Ondbc9otTvnwaY0ZtRSZwW/p/kAonBl+80zMTibAjA YGMMRypyAubl1E4hwki2zvw8tAaXo8nx6MgsrqbsU9mBDJtubzDe623wxogjsA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.63 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: CF08C32C58 X-Spam-Score: -3.63 X-Migadu-Scanner: scn1.migadu.com X-TUID: v1EqtXXlS02R Hi, Ludovic Court=C3=A8s skribis: > This will allow mirror operators to alter the non-normative bits of a > narinfo, such as nar URLs and compression methods, without requiring > them to resign narinfos. > > * guix/scripts/publish.scm (narinfo-string): Remove > URL/Compression/FileSize from BASE-INFO. Move them after "Signature". > * tests/publish.scm ("/*.narinfo") > ("/*.narinfo with properly encoded '+' sign") > ("/*.narinfo with lzip + gzip") > ("with cache, lzip + gzip"): Adjust accordingly. > * tests/substitute.scm ("query narinfo with signature over relevant subse= t"): > New test. Pushed as 6adce1538d2df6fa2d68abc13ae94e2fa826d124 with a slightly different commit log. After this change, there are still non-normative fields being signed: =E2=80=9CNarSize=E2=80=9D, and =E2=80=9CDeriver=E2=80=9D: --8<---------------cut here---------------start------------->8--- $ wget -qO - http://localhost:9999/8fpk2cja3f07xls48jfnpgrzrljpqivr.narinfo StorePath: /gnu/store/8fpk2cja3f07xls48jfnpgrzrljpqivr-coreutils-8.32 NarHash: sha256:0k0l1x5kxlsd83zg36z8kcwh3xpvfhkw8m1512vv9q2vi9c2lv2h NarSize: 17180824 References: 094bbaq6glba86h1d4cj16xhdi6fk2jl-gcc-10.3.0-lib 5h2w4qi9hk1qzzg= i1w83220ydslinr4s-glibc-2.33 8fpk2cja3f07xls48jfnpgrzrljpqivr-coreutils-8.3= 2 a38k2v29l6l0iz6pmlk4dmzwdbvl10lq-acl-2.3.1 a7ggx0af69gv4k5mr1k617p4vy9kgx= 2v-libcap-2.62 fwbiihd2sbhai63y1pvvdh0f2bakfzrf-gmp-6.2.1 jkjs0inmzhj4vsvcl= bf08nmh0shm7lrf-attr-2.5.1 Deriver: y4qp5kiqg3xhgqyj67xav2ld81wpwsmw-coreutils-8.32.drv Signature: 1;ribbon;KHNpZ25hdHVyZSAKIChkYXRhIAogIChmbGFncyByZmM2OTc5KQogICh= oYXNoIHNoYTI1NiAjOEM1OUFEMjYzNEY4MDU3REI0NTUzQkMxM0RFRUM0QkQ2NDYwRDMzMzFDOE= JBN0Q5MTgwOEI4QjdDQUFGMEREMCMpCiAgKQogKHNpZy12YWwgCiAgKGVjZHNhIAogICAociAjM= EYxQkZDQUM3QzcyNEZERjU4QTA1REU4NTU5NkIyRTYxOEE4OTQ4QkJCMUQ2NEUzMkM4QUE3OTlF= NEU0NEIzMCMpCiAgIChzICMwMUREMkU1RTZDRkQwNURGNkI2OEM2OUEwMERBRjU2QUUwMkQ5RTR= DQ0E1QjQ3RUJBNUY1MzNCMTBBMDNBMzdBIykKICAgKQogICkKIChwdWJsaWMta2V5IAogIChlY2= MgCiAgIChjdXJ2ZSBFZDI1NTE5KQogICAocSAjNDYwQzg2OEJGQkM2REI2Q0JEMTdDRUZGMjE1M= kFCRENDNjdFRDg5MTk1MzE2MURCN0ZBODkyQ0JBM0MxM0IwRiMpCiAgICkKICApCiApCg=3D=3D URL: nar/gzip/8fpk2cja3f07xls48jfnpgrzrljpqivr-coreutils-8.32 Compression: gzip --8<---------------cut here---------------end--------------->8--- As suggested during the discussion with pukkamustard, we can consider taking them out as well, though I figured we=E2=80=99d rather do it separat= ely. Thanks, Ludo=E2=80=99.