From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id qK00EfdsLmIUYwEAgWs5BA (envelope-from ) for ; Sun, 13 Mar 2022 23:15:19 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id WP+ADvdsLmJpcwEA9RJhRA (envelope-from ) for ; Sun, 13 Mar 2022 23:15:19 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D314147DC0 for ; Sun, 13 Mar 2022 23:15:18 +0100 (CET) Received: from localhost ([::1]:49502 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nTWUf-0005sy-9H for larch@yhetil.org; Sun, 13 Mar 2022 18:15:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38848) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTWUQ-0005sb-7e for guix-patches@gnu.org; Sun, 13 Mar 2022 18:15:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49591) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nTWUP-0001LX-V2 for guix-patches@gnu.org; Sun, 13 Mar 2022 18:15:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nTWUP-0008KV-No for guix-patches@gnu.org; Sun, 13 Mar 2022 18:15:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 13 Mar 2022 22:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54304 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 54304@debbugs.gnu.org, Tobias Geerinckx-Rice , Cees de Groot Received: via spool by 54304-submit@debbugs.gnu.org id=B54304.164720967331963 (code B ref 54304); Sun, 13 Mar 2022 22:15:01 +0000 Received: (at 54304) by debbugs.gnu.org; 13 Mar 2022 22:14:33 +0000 Received: from localhost ([127.0.0.1]:43488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTWTx-0008JT-5H for submit@debbugs.gnu.org; Sun, 13 Mar 2022 18:14:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTWTv-0008JG-Kk for 54304@debbugs.gnu.org; Sun, 13 Mar 2022 18:14:31 -0400 Received: from [2001:470:142:3::e] (port=35038 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTWTn-0001Il-TZ; Sun, 13 Mar 2022 18:14:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=5Jcl4Q7zqWNa2RV+cy8qRCval3OtDe/ROHJHHzUq6eE=; b=eTAlI0tDs3YWm7U1+ILl eAqiKZwHZzlKBypEQM2zlRmtvbDBTLw93OzSPz+ZFSJoDd+tM0wXJdCzAlrt9uEX/z0ZsdikU8618 y2DT55MEWlHU+Ba9WYrZYwVKVkGCyZQ8u9yQKCKVQUtMRdVE7m0XQeAMkcYYOb+exxfWQVwiU5wTK l2MEijJXqWa+jfdFMU8Aq8agnMUG8vT4eVJKhItpGQL5Udku6n8InhQmLQdXR4HT4Bv8eTdEFoZTk DMkKSZS8BKgu0fDzExwm9frNEo1GzgebdbC/K2WQXNWoUHz2BV+87R4rSqdl72Qf1SXRf/DVDUjwY a+rwhfoIFhBwLA==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:62142 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTWTl-0001a3-Ur; Sun, 13 Mar 2022 18:14:23 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <5e1d2abc1008c43dd70a85999420d529980c2bd1.camel@telenet.be> <3FC21903-C19B-49C1-B865-7D15E1B3EC74@tobias.gr> <2D451842-1953-44AE-A6E8-B50EC77A26A0@tobias.gr> <_Zczh2RFJMdo3Xxkpzzzfq2LT3_PlZVB2huEPbAOcMoPnxeZWSZD7_BJfMZewYiM_LRQk4y6ScvTx_M7L-JQau-5IDMIe9G-req83waeb5o=@evrl.com> <87wnh0w41s.fsf_-_@gnu.org> <3772387f64195fabd6d4a69a4d29912e43896ba9.camel@telenet.be> Date: Sun, 13 Mar 2022 23:14:19 +0100 In-Reply-To: <3772387f64195fabd6d4a69a4d29912e43896ba9.camel@telenet.be> (Maxime Devos's message of "Fri, 11 Mar 2022 22:57:02 +0100") Message-ID: <8735jlts90.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647209718; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=5Jcl4Q7zqWNa2RV+cy8qRCval3OtDe/ROHJHHzUq6eE=; b=UlzcJFZEGlo13I8YO4HA9G827bA8RVKUJDRKCD1YEtdCCGJCCYSMG7Bsrz5ErASAzIiufh 1EJSo65fB0QmTrOPcx9tRSNcyKDVr4rfa75FMULGRUe0Ij7J3jcamS7BA9PshQKdvAmITS aGb++4NSThCh4kZN9XwK/FfAcGug6Hk6PPxbUtKCC/Svx79cRv7tNe+zYSsE+lho1mhKmk 7K1BVjOI2QihOtLBHaqFMgmylFdn9uha0W4YgPDOj68nUHaThpLX8tsmT3Lx5+APkI225y IK3UA4IfaLI7oISD4knsdsCElYnXXVq81RQNHFUBlIJO/x1KNv/xCmZYaqJzNA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647209718; a=rsa-sha256; cv=none; b=KU2Mlk5qYq6W8F+E809aXhxSYCaI1je9sgSTJaWMTJt1ImcdxMTzTsyovCpiCl5tsRgH8s InlthjApVD2+YX1cGs31BnGfhU3ZD36VB9Nq/sn+BsRJ6co1wvZx5SbdwncR4OVZH5efPW Xbp0vZFmpiKpS99Yt+y5sNKoTHvtLDDpUgoNzdzMEnBP9hSkA+tfW8UA53zXDpRI/XrSu/ jTGlvCnkYcxogPPqGSs/VcoLxBT6oKUm+cBVl6o7QAXOeBDrXwNXnonfKKk4esn2PFjhiG /CiKGpZsbFQOj0AXVe/1bN8CnHJMApWSkRjE0tbIPYSlbDKslwYAuFw88u1IwQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=eTAlI0tD; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.37 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=eTAlI0tD; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D314147DC0 X-Spam-Score: -4.37 X-Migadu-Scanner: scn0.migadu.com X-TUID: fR8pfEj4C6jB Hi, Maxime Devos skribis: > Ludovic Court=C3=A8s schreef op vr 11-03-2022 om 22:51 [+0100]: >> If we know what set of store references go in those blogs, we could >> create a text file or something in #$output whose sole purpose is to >> keep a reference to those store items. >>=20 >> For example, if we know those BEAM files contain a reference to Git, we >> can add a phase like: >>=20 >> =C2=A0 (lambda* (#:key inputs outputs #:allow-other-keys) >> =C2=A0=C2=A0=C2=A0 (symlink (search-input-file inputs "git") > > Doesn't that need to be "bin/git" instead of "git"? > >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= (string-append (assoc-ref output "out") >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 "/libexec/elixir/.git"))) >>=20 >> That way the GC will keep Git around. >> >> Thoughts? > > That is not sufficient if git acquires a graft. Argh, good point. Now, I agree with Cees that we need to be pragmatic here and opt for a =E2=80=9Cgood enough=E2=80=9D solution. So I went ahead and applied the initial patch that Cees posted. However, that =E2=80=98replace-paths=E2=80=99 phase also touches references= to /bin/sh; are they also a problem after GC? Thanks, Ludo=E2=80=99.