From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 54304@debbugs.gnu.org, Tobias Geerinckx-Rice <me@tobias.gr>,
Cees de Groot <cg@evrl.com>
Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build
Date: Sun, 13 Mar 2022 23:14:19 +0100 [thread overview]
Message-ID: <8735jlts90.fsf_-_@gnu.org> (raw)
In-Reply-To: <3772387f64195fabd6d4a69a4d29912e43896ba9.camel@telenet.be> (Maxime Devos's message of "Fri, 11 Mar 2022 22:57:02 +0100")
Hi,
Maxime Devos <maximedevos@telenet.be> skribis:
> Ludovic Courtès schreef op vr 11-03-2022 om 22:51 [+0100]:
>> If we know what set of store references go in those blogs, we could
>> create a text file or something in #$output whose sole purpose is to
>> keep a reference to those store items.
>>
>> For example, if we know those BEAM files contain a reference to Git, we
>> can add a phase like:
>>
>> (lambda* (#:key inputs outputs #:allow-other-keys)
>> (symlink (search-input-file inputs "git")
>
> Doesn't that need to be "bin/git" instead of "git"?
>
>> (string-append (assoc-ref output "out")
>> "/libexec/elixir/.git")))
>>
>> That way the GC will keep Git around.
>>
>> Thoughts?
>
> That is not sufficient if git acquires a graft.
Argh, good point.
Now, I agree with Cees that we need to be pragmatic here and opt for a
“good enough” solution.
So I went ahead and applied the initial patch that Cees posted.
However, that ‘replace-paths’ phase also touches references to /bin/sh;
are they also a problem after GC?
Thanks,
Ludo’.
next prev parent reply other threads:[~2022-03-13 22:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 20:52 [bug#54304] [PATCH] Don't fix git executable location during Elixir build Cees de Groot
2022-03-08 22:16 ` Maxime Devos
2022-03-09 17:35 ` Cees de Groot
2022-03-09 17:59 ` Tobias Geerinckx-Rice via Guix-patches via
2022-03-09 21:01 ` Cees de Groot
2022-03-09 21:49 ` Tobias Geerinckx-Rice via Guix-patches via
2022-03-11 21:33 ` Cees de Groot
2022-03-11 21:51 ` Ludovic Courtès
2022-03-11 21:57 ` Maxime Devos
2022-03-11 22:01 ` Cees de Groot
2022-03-11 22:11 ` Maxime Devos
2022-03-11 22:36 ` Cees de Groot
2022-03-11 22:45 ` Maxime Devos
2022-03-11 22:55 ` Cees de Groot
2022-03-11 23:16 ` Maxime Devos
2022-03-11 23:23 ` Cees de Groot
2022-03-13 22:14 ` Ludovic Courtès [this message]
2022-03-13 22:16 ` Cees de Groot
2022-03-08 22:17 ` Maxime Devos
[not found] ` <OtG7oZgFz6vgVWUbmqcU-n34hv-sQCpJYpJKR7rdQvIDnB1sUh_1LoUl9egvv6vKWH_THdYl9gwPrzwzXx_FnxlPXJHaB3D70jY32T3oMuk=@evrl.com>
2022-03-09 7:31 ` Maxime Devos
2022-03-09 17:29 ` Cees de Groot
2022-03-08 22:18 ` Maxime Devos
2022-03-08 22:22 ` Maxime Devos
2022-03-09 17:31 ` Cees de Groot
2022-03-09 19:45 ` Maxime Devos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735jlts90.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=54304@debbugs.gnu.org \
--cc=cg@evrl.com \
--cc=maximedevos@telenet.be \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.