From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id jRBrG6wcN2LpmgAAgWs5BA (envelope-from ) for ; Sun, 20 Mar 2022 13:23:08 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id qKcRF6wcN2KLgAEAauVa8A (envelope-from ) for ; Sun, 20 Mar 2022 13:23:08 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1BBF83890C for ; Sun, 20 Mar 2022 13:23:08 +0100 (CET) Received: from localhost ([::1]:57100 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVuaR-0005AX-76 for larch@yhetil.org; Sun, 20 Mar 2022 08:23:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50726) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVuaL-0005AP-Vo for guix-patches@gnu.org; Sun, 20 Mar 2022 08:23:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39163) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVuaL-0000Z4-NL for guix-patches@gnu.org; Sun, 20 Mar 2022 08:23:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nVuaL-000628-K3 for guix-patches@gnu.org; Sun, 20 Mar 2022 08:23:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54352] [PATCH v2] services: dnsmasq: Add more options. Resent-From: Remco van 't Veer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 20 Mar 2022 12:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54352 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 54352@debbugs.gnu.org Received: via spool by 54352-submit@debbugs.gnu.org id=B54352.164777893123120 (code B ref 54352); Sun, 20 Mar 2022 12:23:01 +0000 Received: (at 54352) by debbugs.gnu.org; 20 Mar 2022 12:22:11 +0000 Received: from localhost ([127.0.0.1]:33060 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVuZX-00060q-MC for submit@debbugs.gnu.org; Sun, 20 Mar 2022 08:22:11 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:38165) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVuZV-00060d-IG for 54352@debbugs.gnu.org; Sun, 20 Mar 2022 08:22:11 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id AFB7D32009E0; Sun, 20 Mar 2022 08:22:03 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 20 Mar 2022 08:22:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=remworks.net; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; bh=opPrnJMp4TP2dRuIY3SgxRY8ZxP5zPggwUmRKa 3s818=; b=U/G/Xuqsm7+2RIZ38HtZ69lBmD3jDlcmPq8DMglEk1FJDL8dfBMtKp wgMlrqvc+WNd4+cRkkok4L3f7HtBcnRQzSZ3pOl4RsEIr4F/pidVBd2X4a89nw92 nx2lPuvmiLLB7akXz8ptJPX+IzrDvt8iFFUBcf/AAwSGLO9Wgqk6dpux+DN1f36W k6396NZ5vh6iCzY1vtLNhp3uNJ4T49Ot1LB0jH570j3hvtgvW9cPSnCjWJzybOZd BhqE/TpJQaa8cji1zCMW/fM0bvKARCEuWKy3shuSrvM42bsRcQJCQ0WRTqt0EO3+ KFncZUBA6S95A6E+gpkbrgKkeRDYR/ow== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=opPrnJMp4TP2dRuIY 3SgxRY8ZxP5zPggwUmRKa3s818=; b=oooSLq4vhOR5UvRY/bc0skJHnMcybGLsX YogiOEpj7uZL8v/FtHlzKgqQ1Zj7miOmnfkYQOdAHcnmQMEOJNxTDruu45L4Pu1R m18MnrTyqvU1lWbHX9UZ8owkTfQvFk0A8nL6Z6nTICblXkOSiLVZnz82ZzpSx5pB hawKXuE9FOaVShREqsYF211VkD004PVV3yYVNW0oCe+1YMn9UNESqyI5Yff5feSt utX23UglM3VZ7hydRYC+PRAk7lrNTQuFOdWByAmiglx95Wf/cQq3/geta1JEGhEv EUlkgKs7qfgu4MI/YqeeruQgik3Ypboho1FrcocPwsweF7Rh51btQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeguddgfeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvufgjfffkgggtsehttdertddtredtnecuhfhrohhmpeftvghmtgho uchvrghnucdkthcugggvvghruceorhgvmhgtohesrhgvmhifohhrkhhsrdhnvghtqeenuc ggtffrrghtthgvrhhnpeeuledvteevteehfeduvefhjeduvefgkeehledtgfegvdeugeff hfekieejkedtgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehrvghmtghosehrvghmfihorhhkshdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 20 Mar 2022 08:22:02 -0400 (EDT) References: <20220312154813.5538-1-remco@remworks.net> <20220320114405.4702-1-remco@remworks.net> User-agent: mu4e 1.6.10; emacs 27.2 From: Remco van 't Veer In-reply-to: Date: Sun, 20 Mar 2022 13:22:00 +0100 Message-ID: <8735jcddav.fsf@remworks.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647778988; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=opPrnJMp4TP2dRuIY3SgxRY8ZxP5zPggwUmRKa3s818=; b=QtHRr3FeCienU/vpB7wl/VpJWeThmpCBgeZZu6rkYz1sxtEluPXjziwypqJbAFyikcJKZ1 /Bhjk7v8k4PWNcQxejErvYTIYkTWfjq3O7RERcfS5wdWZwz3QtHXvR4jveJ+W39OPyRshm i1r8uU2DXW6Qsn8l4oOX4gdkUlhtJDc56iZFRTGqy0GCL1XZh7cBQqjPUNgBxws+kAymBA +hjgEpYC1M1KK6iDDekMdrIyfhcWVsew2blLV2FTi7BP2f+nR2sh76OFapnKLTxi9AAyDx ZrxM+TaWuLUxPmLsAskagQHDQ3lFOrcaTJsjvbeK1xby4bL6/6RZrQ0pzh1yGg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647778988; a=rsa-sha256; cv=none; b=lXzTG74OQQyAqPNIOHUf8WNuGA/a2draifaSJEaIGpQGh4mrA8E9xhhUUKegOI6E//Jn0N IRRzcQJfsnM+AZy0xuNXpu0XTJR0Nj51O4F+qmwtUZKFsuPM9y14LfukBJ8fpl+/7k4oX5 80tzeAviCJPuZV7L2g6zONfgmU2oJ5ds1ldHPww3PvVpM+xwAfQDbUXI2W3yMeeuL40oIx 3lgO0PFwmQshIMRsusockaNy1pfgqMt5CWh81h8A1LaNi6v5zdRHsUIph3pKx+6NrmaLno BOzHUtvKonJV7h9aMfRZHGEBnMOJsU3syJonmRSN91mcDbVKgqU5xB9lLqerIA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=remworks.net header.s=fm3 header.b="U/G/Xuqs"; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm3 header.b=oooSLq4v; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -0.83 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=remworks.net header.s=fm3 header.b="U/G/Xuqs"; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm3 header.b=oooSLq4v; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 1BBF83890C X-Spam-Score: -0.83 X-Migadu-Scanner: scn0.migadu.com X-TUID: M4NvlUwNszAJ 2022/03/20 12:56, Maxime Devos: > It would be nice to verify that these are, in fact, booleans, > using field sanitizers. See, e.g., ensure-setuid-program-list > in (gnu system). I agree but the same could be said about the other fields and types in this record, and those of other services. In this case, the names of the fields ending with "?" should be enough for somebody to realise this is a boolean, IMHO. The ";boolean" comments I've added are just me trying to blend in.