From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id GBnNH8KEWmN1fgAAbAwnHQ (envelope-from ) for ; Thu, 27 Oct 2022 15:16:50 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id GBS5H8KEWmNXKwEA9RJhRA (envelope-from ) for ; Thu, 27 Oct 2022 15:16:50 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2194517A8D for ; Thu, 27 Oct 2022 15:16:50 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oo2f3-0000v1-CH; Thu, 27 Oct 2022 09:11:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo2f0-00005Y-Lo for guix-patches@gnu.org; Thu, 27 Oct 2022 09:11:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oo2f0-0004qi-6l for guix-patches@gnu.org; Thu, 27 Oct 2022 09:11:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oo2ez-0002BM-TB for guix-patches@gnu.org; Thu, 27 Oct 2022 09:11:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#58587] [PATCH 00/14] Introducing pyproject-build-system. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 27 Oct 2022 13:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58587 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke Cc: 58587@debbugs.gnu.org, Lars-Dominik Braun , zimoun Received: via spool by 58587-submit@debbugs.gnu.org id=B58587.16668762358349 (code B ref 58587); Thu, 27 Oct 2022 13:11:01 +0000 Received: (at 58587) by debbugs.gnu.org; 27 Oct 2022 13:10:35 +0000 Received: from localhost ([127.0.0.1]:56399 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo2eZ-0002Ab-5j for submit@debbugs.gnu.org; Thu, 27 Oct 2022 09:10:35 -0400 Received: from mail-qt1-f175.google.com ([209.85.160.175]:42766) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo2eY-0002AP-3k for 58587@debbugs.gnu.org; Thu, 27 Oct 2022 09:10:34 -0400 Received: by mail-qt1-f175.google.com with SMTP id w29so1019085qtv.9 for <58587@debbugs.gnu.org>; Thu, 27 Oct 2022 06:10:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=fMpmVE89M8o+KFlZqBJfLvvg5Y0U0gYGkTGc1QzGrzQ=; b=bSvw7wzXIApjCZXx5H1lckw6RjQ8kgYoqnK+rASbntBUwCsE+NfPKWDxaLr90onqv3 OydczjHpAkLLuQQNVmmcqm+Fd6L7ee6e8XdKn2+kAQ8B4jsrSBJ8iqi0oBAQDccT3Yu4 12OqcfGKMvypX1DMnqITgh0fas5fcDV3zYFwmMFWys6mpO3eHOCSvpNM1AEnCaEzjqfe XRAa11SWeX9ByMQjjvoQrQFard+5kM85Bsbx61oSrl0h/Fcxu4/UGzBIcT4MOmHzKrak wqSaOZC3OhaoqW1j8xDxUCeuCMKG6PDQlHD0+RLksYto6Hokbj9vgK3dDSZWgpqKhz7m Zn0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fMpmVE89M8o+KFlZqBJfLvvg5Y0U0gYGkTGc1QzGrzQ=; b=ji8B+yonsa1a3SYBhHlAONqUFz/vOPxytCzyS2YFiCKXuF90xyyfVFyufkR/shB5Q4 XlpdbK2Qot7nzFKNVqRxMjkG+pLkQg96KlBXehi9Bo8pVKlMegPV9V0+2cn0dIBOuhHb CpxKVvRSL67fgJ9VrL0bo0D3g2Hza1FUdzyL5+jMvnHgQKqOG6xjQYiieTHHB7gClEHx VR6z9v4frqCynZHRwu9O4AwAwT9FPW5vWDbfYM79H8CxW1kjJDhZMvs710YdIU7uYCe1 KNNYRGt8ahUI3GnEu3+pbypyC3cIDB+zkspFApNUBDz9525PktAQp22TITxdu5uCQVsj 4yyQ== X-Gm-Message-State: ACrzQf3uoxP4T7Cq8Fusuwd2V+v08/7Y+TZPwecUog8gRN622DrQzpBX EuDPj1Zt4NE7X5seUha6+bU= X-Google-Smtp-Source: AMsMyM7a+W/QSAw+KJAdb4DRSFdKEGCBUwMl6FMOuanQnI+148HXQXRGnnAiSG8dE3s7nB+dJnjvkg== X-Received: by 2002:ac8:5b56:0:b0:39c:db95:ac4 with SMTP id n22-20020ac85b56000000b0039cdb950ac4mr40700283qtw.299.1666876228411; Thu, 27 Oct 2022 06:10:28 -0700 (PDT) Received: from hurd (dsl-152-179.b2b2c.ca. [66.158.152.179]) by smtp.gmail.com with ESMTPSA id m3-20020a05620a24c300b006b953a7929csm940606qkn.73.2022.10.27.06.10.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Oct 2022 06:10:27 -0700 (PDT) From: Maxim Cournoyer References: <20221017200624.4076-1-marius@gnu.org> <86sfjlzdbn.fsf@gmail.com> <877d0wvlzg.fsf@gnu.org> <86ilkgp2hx.fsf@gmail.com> <871qr3v26i.fsf@gnu.org> <87v8oekjcs.fsf@gmail.com> <87eduzu18u.fsf@gnu.org> Date: Thu, 27 Oct 2022 09:10:26 -0400 In-Reply-To: <87eduzu18u.fsf@gnu.org> (Marius Bakke's message of "Sat, 22 Oct 2022 21:06:25 +0200") Message-ID: <8735b9qunx.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Guix-patches" Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1666876610; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=fMpmVE89M8o+KFlZqBJfLvvg5Y0U0gYGkTGc1QzGrzQ=; b=Rvg3bKoAsAFyjlgq+k+wA4qqmqLN3FaAIpOef5/IWjxFmM+62lJyUyc5CargNIbf52hMdi Hibx68qZ89PUR/OT+iOp68lNT2kMWmn7WhX2w275Zf3FXvE0GgrSQAbx30FCzznypKRTmN sbZ+rABCc1yikWb/Zbx6skYOJqgsEvpLL9MfL5zSuw5JDHvB4MCpixDagQ+m58KeRaMm0K CuhrOLU/+QtD6rFrXD2r5N7PvgEHIkWmGSx7eYWmWCkPKZB7QQ4SKIR65x//JSzVnFhvKr B+VeYO20Z3eWizvONPEsV1LL6i/ReBwkJZinXLwUins4Q2lHTnujXO++1N6VmQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1666876610; a=rsa-sha256; cv=none; b=XG+kOlfZRhqM8+ZWjhAjLokq99o6m3RQc+7gvAcnu4oH4LDlj8RKVkPCGXr9RdifG2n5yC mQhR0Je2H4lgA+ojOHNBWpBonRVWIMv2dSOeMdnvDUXTRZF9e2NqbAIcuyapD+3UEwDfAY XOJiPfbST8EybM4Lbcl1wbTgt1Qiq8gJiTv6Rkv5EfKtK4YJZS75HbwnGVONDuOUTRbllw T4gKJDl//II7GQE/NQH/v53+oMu6zawBTPR5z1c7q9hIXLI9BWaFlihzxTcwYIPkvwkoaS JgbQ2w1II3k0l/4rye+Ta8e3Hwh/pQHW9VW9g6iGOFfoGt5gMhUunZB1fBFtLA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=bSvw7wzX; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 9.08 X-Spam: Yes Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=bSvw7wzX; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 2194517A8D X-Spam-Score: 9.08 X-Migadu-Spam: Yes X-Migadu-Scanner: scn1.migadu.com X-TUID: 0Uu+KQs7sXmS Hi Marius, I've yet to delve into the actual patches (I intend to do so shortly), but here's a quick reply to your last message. [...] > I've now added a section in the manual about API changes and stability, > and removed more duplicate code from pyproject-build-system. I also > added a news entry. > > I think this is now ready for merge, but have some concerns: > > * The python-toolchain package is a union that includes setuptools, > wheel and others. Packages that pick up a reference to the build-time > Python will needlessly include those other packages. It could be > worked around by propagating instead of using a union. That could be better, yes. They may still be picked up in wrap phases, but that's a Guix-wide problem (can't tell between native vs regular inputs on the build side when native compiling). > * Overriding #:test-flags means having to add back the implicit defaults > for verbose output. We could add them even when #:test-flags is > present so users don't need to add "-vv" manually. This is handled for Emacs packages by having a %default-test-flags or similar that users can cons to... but it's still very too easy to forget. Perhaps we should gradually move to most arguments "extending" the defaults rather than completely overriding them; such an idea was discussed for example for the #:modules and #:imported-modules arguments recently. > > I will merge this in a few days if there are no further comments. It > can still be tweaked directly on 'master' if necessary. > > Updated patches follow shortly. I'll try to have a quick look now, as I see this hasn't landed yet. Thank you for picking up this series! -- Thanks, Maxim