all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#59152] disable failing test in earlyoom
@ 2022-11-05 23:34 pronaip
  2022-11-20 10:45 ` bug#59152: " Christopher Baines
  0 siblings, 1 reply; 2+ messages in thread
From: pronaip @ 2022-11-05 23:34 UTC (permalink / raw)
  To: 59152

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: multipart/mixed; boundary="=-=-=", Size: 2204 bytes --]

--=-=-=
Content-Type: text/plain

Wrote this completely on my netbook without compiling Guix, since that
takes literal hours on this machine, but it's a small patch so it should
work.
Also I wanted to see how well one can contribute from limited hardware.

--=-=-=
Content-Type: text/x-patch; charset=utf-8
Content-Disposition: attachment;
 filename=0001-gnu-Disable-failing-test-in-earlyoom.patch
Content-Transfer-Encoding: quoted-printable
Content-Description: disable failing test in earlyoom

From 3963439e518115e379a3726c9290c9f51f7b1c1b Mon Sep 17 00:00:00 2001
From: Csepp <raingloom@riseup.net>
Date: Sun, 6 Nov 2022 00:26:48 +0100
Subject: [PATCH] gnu: Disable failing test in earlyoom.

* gnu/packages/linux.scm (earlyoom)[arguments]: Disable failing test.
---
 gnu/packages/linux.scm | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index cf11a7fc1b..4254cf54cd 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -66,6 +66,7 @@
 ;;; Copyright =C2=A9 2022 muradm <mail@muradm.net>
 ;;; Copyright =C2=A9 2022 Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.or=
g>
 ;;; Copyright =C2=A9 2022 Hunter Jozwiak <hunter.t.joz@gmail.com>
+;;; Copyright =C2=A9 2022 Csepp <raingloom@riseup.net>
=20
 ;;;
 ;;; This file is part of GNU Guix.
@@ -3829,10 +3830,14 @@ (define-public earlyoom
                (setenv "HOME" (getcwd))))
            (add-before 'check 'disable-failing-test
              (lambda _
-               ;; This test relies on writing to /proc/%d/oom_score_adj.
                (substitute* "testsuite_cli_test.go"
+                 ;; Relies on writing to /proc/%d/oom_score_adj.
                  (("TestI" match)
-                  (string-append "skipped" match))))))
+                  (string-append "skipped" match))
+                 ;; Relies on setting niceness to -20.
+                 (("^.*\"-p\".*$" match)
+                  ;; comment out the whole line
+                  (string-append "// skipped: " match))))))
        #:make-flags
        #~(list (string-append "CC=3D" #$(cc-for-target))
                (string-append "VERSION=3Dv" #$version)
--=20
2.38.0


--=-=-=--

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#59152: disable failing test in earlyoom
  2022-11-05 23:34 [bug#59152] disable failing test in earlyoom pronaip
@ 2022-11-20 10:45 ` Christopher Baines
  0 siblings, 0 replies; 2+ messages in thread
From: Christopher Baines @ 2022-11-20 10:45 UTC (permalink / raw)
  To: pronaip; +Cc: 59152-close, guix-patches

[-- Attachment #1: Type: text/plain, Size: 122 bytes --]


Closing as this message seems not have any content. Please re-send if
you still have a patch to propose.

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-11-20 10:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-05 23:34 [bug#59152] disable failing test in earlyoom pronaip
2022-11-20 10:45 ` bug#59152: " Christopher Baines

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.