On 2022-12-02, Ludovic Courtès wrote:
> Release progress: week 8.
>
> Apologies for not sending this one on time this Thursday; instead we got
> RC1, which is nice.  :-)
>
>   https://lists.gnu.org/archive/html/guix-devel/2022-12/msg00000.html

Yay, love not having to build the source tarball to test it! :)


> The RC was made from ‘version-1.4.0’ branch, which only takes important
> fixes now (if in doubt, please ask).

Must not fix trivial known guix lint typo fixes, check! :)


With more seriousness... here come the test suite failures!

When building on Debian there are a number of tests that fail with the
same symptoms, notably something wrong with how "scm_to_utf8_stringn" is
called:

  test-name: find-packages-by-name with cache
  location: /build/guix-HqZNpM/guix-1.4.0~rc1/tests/packages.scm:1760
  source:
  + (test-equal
  +   "find-packages-by-name with cache"
  +   (find-packages-by-name "guile")
  +   (call-with-temporary-directory
  +     (lambda (cache)
  +       (generate-package-cache cache)
  +       (mock ((guix describe) current-profile (const cache))
  +             (mock ((gnu packages)
  +                    cache-is-authoritative?
  +                    (const #t))
  +                   (find-packages-by-name "guile"))))))
  expected-value: (#<package guile@3.0.8 gnu/packages/guile.scm:392 1070318> #<package guile@3.0.7 gnu/packages/guile.scm:310 1070688> #<package guile@2.2.7 gnu/packages/guile.scm:250 1070738> #<package guile@2.2.4 gnu/packages/guile.scm:297 10706e0> #<package guile@2.0.14 gnu/packages/guile.scm:147 1070790> #<package guile@1.8.8 gnu/packages/guile.scm:76 10707e8>)
  actual-value: #f
  actual-error:
  + (wrong-type-arg
  +   "scm_to_utf8_stringn"
  +   "Wrong type argument in position ~A (expecting ~A): ~S"
  +   (1 "string" #f)
  +   (#f))
  result: FAIL


Tests that appear affected by this issue:

  tests/graph.log:test-name: reverse bag DAG
  tests/graph.log:result: FAIL

  tests/packages.log:test-name: fold-available-packages with/without cache
  tests/packages.log:result: FAIL

  tests/packages.log:test-name: find-packages-by-name with cache
  tests/packages.log:result: FAIL

  tests/packages.log:test-name: find-packages-by-name + version, with cache
  tests/packages.log:result: FAIL

  tests/packages.log:test-name: find-package-locations with cache
  tests/packages.log:result: FAIL

And tests/inferiors.scm dies with a backtrace, and stops processing any
further tests so it is hard to know if those fail too:

  Backtrace:
            17 (primitive-load-path "tests/inferior.scm")
  In ice-9/eval.scm:
      619:8 16 (_ #(#(#<directory (test-inferior) 126f50> #<test-…>) #))
     293:34 15 (_ #(#(#<directory (test-inferior) 126f50> #<test-…>) #))
      159:9 14 (_ #(#(#<directory (test-inferior) 126f50> #<test-…>) #))
      159:9 13 (_ #(#(#<directory (test-inferior) 126f50> #<test-…>) #))
  In guix/discovery.scm:
      189:3 12 (fold-module-public-variables _ _ _)
  In guix/combinators.scm:
      48:26 11 (fold2 #<procedure 22e4990 at guix/discovery.scm:189:1…> …)
      48:26 10 (fold2 #<procedure 36224f0 at guix/discovery.scm:190:1…> …)
  In guix/discovery.scm:
     192:33  9 (_ #<package python-gwcs@0.18.2 gnu/packages/astronomy…> …)
  In gnu/packages.scm:
     233:37  8 (_ #<package python-gwcs@0.18.2 gnu/packages/astronomy…> …)
  In guix/packages.scm:
    1317:17  7 (supported-package? #<package python-gwcs@0.18.2 gnu/p…> …)
  In guix/memoization.scm:
      101:0  6 (_ #<hash-table 22e6c10 1900/3517> #<package python-gw…> …)
  In guix/packages.scm:
    1295:37  5 (_)
    1555:16  4 (package->bag _ _ _ #:graft? _)
    1652:22  3 (thunk)
  In guix/gexp.scm:
     523:11  2 (lower "python-gwcs-0.18.2" #:source _ #:inputs _ # _ . #)
     460:52  1 (%local-file #f #<promise #<procedure 3623160 at guix/…> …)
  In unknown file:
             0 (basename #f #<undefined>)

  ERROR: In procedure basename:
  In procedure scm_to_utf8_stringn: Wrong type argument in position 1 (expecting string): #f


Other than that, it seems to build fine. I haven't actually tested it
yet.