From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id KAoTAVl1j2TATgEASxT56A (envelope-from ) for ; Sun, 18 Jun 2023 23:21:29 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id EJcRAVl1j2SXywAAauVa8A (envelope-from ) for ; Sun, 18 Jun 2023 23:21:29 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D1E366C34 for ; Sun, 18 Jun 2023 23:21:28 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qAzpa-0003K3-ET; Sun, 18 Jun 2023 17:21:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAzpY-0003Jn-5j for guix-patches@gnu.org; Sun, 18 Jun 2023 17:21:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qAzpW-0008P9-MF for guix-patches@gnu.org; Sun, 18 Jun 2023 17:21:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qAzpW-0002Fj-9i for guix-patches@gnu.org; Sun, 18 Jun 2023 17:21:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62699] [PATCH] services: add pam-mount-volume-service-type Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 18 Jun 2023 21:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62699 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Brian Cully Cc: glv@posteo.net, 62699@debbugs.gnu.org Received: via spool by 62699-submit@debbugs.gnu.org id=B62699.16871232328600 (code B ref 62699); Sun, 18 Jun 2023 21:21:02 +0000 Received: (at 62699) by debbugs.gnu.org; 18 Jun 2023 21:20:32 +0000 Received: from localhost ([127.0.0.1]:55106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAzp2-0002Ed-37 for submit@debbugs.gnu.org; Sun, 18 Jun 2023 17:20:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAzp0-0002EP-0x for 62699@debbugs.gnu.org; Sun, 18 Jun 2023 17:20:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAzou-0008IT-Pp; Sun, 18 Jun 2023 17:20:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=/1y2xFXlT18EC766Ihu+0evQ3rZ+6Len/pvYxa8Y5tc=; b=iQwDMKf5NfVjhX8aSg6e G8rbiBmJ7U/NM15StdSEZc3GA+wTPI9ZZWUUNu0MRpZklWU7j9aSm8ypEGjHB01uDd8nttDD6jiWD KM328gjFEOyPQo2s3cytfAPTyNPFStLr31JgTUE6x7nej6B+fNB4Vtt8tKSzQee6krmY0exUB0uL8 mV/DEnmkhsJw2twI2QyVAxwSWiYyluxlEylWru8CBU6ouSAUii4KMGjD5P936DNyFLFQpk1Ot987f Bo3Ue9xm1hVtePfi02Cz7t9OP0ciO5rKJoarXja6r5joa5c4YN3YPB83vSOFEdrqKazYESehnoUz3 ey86wCFLPDqk0g==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAzou-0006rD-DM; Sun, 18 Jun 2023 17:20:24 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87lej5x8ke.fsf@psyduck.jhoto.kublai.com> Date: Sun, 18 Jun 2023 23:20:22 +0200 In-Reply-To: (Brian Cully's message of "Thu, 6 Apr 2023 12:57:43 -0400") Message-ID: <87352opiw9.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1687123288; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=/1y2xFXlT18EC766Ihu+0evQ3rZ+6Len/pvYxa8Y5tc=; b=BVP2VSqfFUDcSJqPYqz5MVYF66MGIUsBk+ormG+IBY0bBTFQexyvm1BvWlf5Jg82Yn5XLD 3w2Z7M/+rWRhjl5vIRleLn5a/n3MkT3ZG8JW+tdbNfA8fNm8E+ofVj9SxveisXNFRLjOUJ e+nJKs48b8ZvTkUGpw7H0ro25oiVY6vL3Awi3nUmE9ZneGRDsyZUJDLvDlLfjiwxXKTA+b r7z1DoTbPBnJuK27YfebPqjPrAj67JZfkjChSIW0Ai1aaDXF36mPwb+m0NtaASf1I4oBpK lkbxqa7mmftPBHWcRaqP5H6OvZG7CIfW1MG0vNnKH9HYTrdWWnX1/jfyiE8c3w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=iQwDMKf5; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1687123288; a=rsa-sha256; cv=none; b=EQbW6nWFRT0dm0suFkGN+y1aWyBwKy3LBtzg3Ij8Nk6pYsN8Hl47QKJYb4NN0cGhQqki37 7litnrt8ECQiZHnBc/kbFwah6EV09/D5dJqtL5wT98ZHGBN17uJ1GhaS1B6c0LWllvMiJw 2rFHDVjF+0EZdF4+9nJDH3/ftIJ6G/ObKd+Yeousbd8eWRGf6EPEFuGvwJVoRA1h19Vlpa QWimtF0HOGvUuEjDy1zy23+UdYol0JksAACK0gRKDYWxNQzzu0UsgYAGxIPUsjgBXrlKom VC2X6S+f7xvT8g324ZEUd0WixQVUHxRgkO50/abpJzuZ2/lSb2QeJCJ7omChxA== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -4.15 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=iQwDMKf5; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D1E366C34 X-Spam-Score: -4.15 X-TUID: eqzLYsIyZGGv Hi! Brian Cully skribis: > The `pam-mount-volumes-service-type' adds additional volumes to the > pam-mount-service-type in addition to any that are already specified in > `pam-mount-rules'. > > * doc/guix.texi (PAM Mount Volume Service): add documentation for > `pam-mount-service-type'. > * gnu/services/pam-mount.scm (extend-pam-mount-configuration): new proced= ure > (pam-mount-service-type): allow extension by other service-types > (field-name->tag): new procedure > (serialize-string): new procedure > (integer-or-range?): new procedure > (serialize-integer-or-range): new procedure > (serialize-boolean): new procedure > (pam-mount-volume): new configuration > (pam-mount-volume->sxml): new procedure > (pam-mount-volume-rules): new procedure > (pam-mount-volume-service-type): new procedure > * Makefile.am: add pam-mount tests > * tests/services/pam-mount.scm: new tests This looks useful! Nitpick: for new files like =E2=80=98pam-mount.scm=E2=80=99 in this case, i= t=E2=80=99s enough to write =E2=80=9CNew file=E2=80=9D (relief :-)). I=E2=80=99ve never used PAM mount before so I can only comment on the implementation and doc (maybe Guillaume is more familiar with it?). > Copyright @copyright{} 2022 Antero Mejr@* > Copyright @copyright{} 2023 Karl Hallsby > +Copyright @copyright{} 2023 Brian Cully Please add @* on the previous line to insert a line break. > +@item @code{user-id} (type: maybe-integer-or-range) > +Mount the volume for the user with this ID. This field may also be > +specified as a cons cell of @code{(start . end)} indicating a range of Use the term =E2=80=9Cpair=E2=80=9D rather than =E2=80=9Ccons cell=E2=80=9D= (throughout the section), for consistency with the rest of the manual and to make it more approachable. > +(test-end "services-pam-mount") Neat. How hard would it be to also have a system tests under (gnu tests =E2=80=A6= )? Seems like it would better cover functionality. Thanks! Ludo=E2=80=99.