From: Ricardo Wurmus <rekado@elephly.net>
To: guix-devel@gnu.org
Cc: Jelle Licht <jlicht@fsfe.org>
Subject: npm has irreproducible install behavior
Date: Fri, 07 Jul 2023 07:47:12 +0200 [thread overview]
Message-ID: <873520tgi4.fsf@elephly.net> (raw)
Hi Guix,
after a few days of frustrating investigation I found a bug in one of
the libraries used by npm:
https://github.com/npm/pacote/issues/285
The result is that “npm install” will not install *all* files dependent
on whether a file is deduplicated in the store. This causes
irreproducible output and build failures down the line on different
systems depending on the state of the file system.
We should patch this ourselves. We can either tell node-tar not to mark
up hardlinks with the “Link” type, or we can patch pacote to not skip
files that have the “Link” type.
I’ve tested this little addition to the build phases of node-lts on an
affected system:
--8<---------------cut here---------------start------------->8---
(add-after 'install 'do-not-ignore-links
(lambda* (#:key outputs #:allow-other-keys)
(with-directory-excursion
(string-append (assoc-ref outputs "out")
"/lib/node_modules/npm/node_modules")
(substitute* "pacote/lib/fetcher.js"
(("\\/Link\\$\\/.test\\(entry.type\\)") "false")
(("\\/File\\$\\/.test\\(entry.type\\)")
"/(File|Link)$/.test(entry.type)"))
--8<---------------cut here---------------end--------------->8---
What do you think?
--
Ricardo
next reply other threads:[~2023-07-07 5:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 5:47 Ricardo Wurmus [this message]
2023-07-07 12:38 ` npm has irreproducible install behavior Jelle Licht
2023-07-13 6:48 ` Ricardo Wurmus
2023-07-13 8:41 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873520tgi4.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=guix-devel@gnu.org \
--cc=jlicht@fsfe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.