From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id wJ2WAdR5AmV44QAAG6o9tA:P1 (envelope-from ) for ; Thu, 14 Sep 2023 05:11:16 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id wJ2WAdR5AmV44QAAG6o9tA (envelope-from ) for ; Thu, 14 Sep 2023 05:11:16 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 42F3757C0A for ; Thu, 14 Sep 2023 05:11:15 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=F15rWARk; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694661075; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=/FN7X0MOt9wfC6ncVnqg+KwTbkU7skTr0chtCAgCSV8=; b=Gdj4ww1YgKgd3Iqc9hd4F2ylADSy7vFTk2tn2HnEssSxHXmTej5Yn8tw3uwbjVSRjeFwg4 qbS3ZrG+Ku3tTZVUcTfxwNrnGS8DjYVNzhKAGqKFLQr3jk4FSIuv770FBVX3X/qNKPu+og 3CHD5f3aY9uFxAD0C8vt6UQuYyLz548NOpqh7sbRG28SHn3nDgFSv3mTJQfRkdnvjrmV6/ e2F+dFvmIFsRY6e48nIn/abtUzRbPRxVMTpmdufNAvIayYO4dykWmz2mctkxp5FJxyPiKj B3bUE6bRlndQGvuKVId6QwDiUMf7jnLNsTgvIINyr7h0tdpNqm9zgFyUxoYA+g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694661075; a=rsa-sha256; cv=none; b=motVXZU0PKlE6OOlzeM8Y7cb9Ek48hp/kkBAgm9FC8RzOBGb660cFH0CJYh6yPcwqqVd6i TgRVNn9SVEz5L3hVbVmPUUQWmCB/3fs85Rnayj8K1q9eUVRcLge0KwtKSkDP2QZ85Tfwa5 LQ+H1vwk221cBzcW52f5b1dlk0d7AApQu27F8yHUrwkIsigCB/F7WgTY69qEa4ay1wTuQM sKf9eycWVwRM6kfA7oNBB/gs6BxPYYa7ov8Dr12oN4ffp0ORZ65pM2rmHN/t5k3RXyrj8d 4KccC7YzL5S4arD9XfAQ79/OFb9d1QdQmf0SgRSbpdHnycSUNtEacHNqkLmF7Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=F15rWARk; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qgckt-00065M-EY; Wed, 13 Sep 2023 23:10:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgckr-00064N-Hd for guix-patches@gnu.org; Wed, 13 Sep 2023 23:10:57 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qgckr-0007fZ-9V for guix-patches@gnu.org; Wed, 13 Sep 2023 23:10:57 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qgckw-00067O-Hf for guix-patches@gnu.org; Wed, 13 Sep 2023 23:11:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65860] [PATCH 0/4] Resolve a circular module dependencies in embedded modules Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 14 Sep 2023 03:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65860 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 65860@debbugs.gnu.org Received: via spool by 65860-submit@debbugs.gnu.org id=B65860.169466104923496 (code B ref 65860); Thu, 14 Sep 2023 03:11:02 +0000 Received: (at 65860) by debbugs.gnu.org; 14 Sep 2023 03:10:49 +0000 Received: from localhost ([127.0.0.1]:36426 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgckV-00066f-2g for submit@debbugs.gnu.org; Wed, 13 Sep 2023 23:10:48 -0400 Received: from mail-qt1-x835.google.com ([2607:f8b0:4864:20::835]:61463) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgckQ-00066O-GO for 65860@debbugs.gnu.org; Wed, 13 Sep 2023 23:10:33 -0400 Received: by mail-qt1-x835.google.com with SMTP id d75a77b69052e-4132c2cee1dso2695411cf.2 for <65860@debbugs.gnu.org>; Wed, 13 Sep 2023 20:10:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694661019; x=1695265819; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=/FN7X0MOt9wfC6ncVnqg+KwTbkU7skTr0chtCAgCSV8=; b=F15rWARkr3CQcMhjwjeDPRmBvQtLWRCzw31NksNh4zQX3UZtuF2+VkbkIL3Jl0f20w EoOuFJUEPl76yemEB8GRwF19flwCyKAHddizTCjDpEDmeA2cuT4ew7aJpcPeD6eW36Fd C1lRDhG5xNuSfxP2zxMQWIm0WtWkwoA2Q3RXWT/m8HPUXemdj8f2HbBR87k4ZuJRLusg x9sStmPEa30W2qEJQhfpziVxdGss68KC/ck9lewvB99mXHJ5BshACBe+1HTsCON1ILx+ yR9RxcPTBAXsh4d3UqVJ1hAI4Lm/KQTahqIQ7DcYov9HdxPQKCRG4dx5zKx1QPqP+UUT NauA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694661019; x=1695265819; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=/FN7X0MOt9wfC6ncVnqg+KwTbkU7skTr0chtCAgCSV8=; b=LyFjKAtoh4JR3Z8d2mtiA4wv9/VUPdLbd3NFrX8YYQ9PsftFGn1WM2xTqZZOGt/BfI NH4T9bcmbcDZS5qRnGz7ihofyG7m0vUiU3i/i6C6hfHC5fZy/iSLZDKtEZgnW+8BzBI2 KhXEzxuI3X45vWa6GjfWG8YuXlntCWsdOvmeiK7TvMRIh4/OIvAtpj4tkeqY1veO9HLl wrfxqys82Uzrfb1Ljy/8YKnGjzo6bWpghxZ9Ehxz3aAiu9BVp5du2SdRqVX0CWbyTjLQ BiH+i4Y5cGGgbyh6+eX8lJSHe96qecYH9D4Zf3ota4KzK6x8hmnqcBDmQA5JZ/s9brrR WEcg== X-Gm-Message-State: AOJu0YyzCMggQPrBmtt2BlJgqleoV3IYLfY4q2uAohXUGZ0YjGDZRfOr Wtvv3aG3BPNG1lTE6DlLSHyoK5J4HoM= X-Google-Smtp-Source: AGHT+IHpU0Cn0UMqeXXC1+aKAZ5Rj0pybINcCaZnnwFL4B/GQ4kCjHYv5nInKWuQpzQmfF/HBGG62w== X-Received: by 2002:ac8:59c1:0:b0:410:a9f8:c7e6 with SMTP id f1-20020ac859c1000000b00410a9f8c7e6mr4183846qtf.42.1694661018686; Wed, 13 Sep 2023 20:10:18 -0700 (PDT) Received: from hurd (dsl-149-165.b2b2c.ca. [66.158.149.165]) by smtp.gmail.com with ESMTPSA id f5-20020ac80685000000b0040554ed322dsm186293qth.62.2023.09.13.20.10.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 20:10:18 -0700 (PDT) From: Maxim Cournoyer References: <87r0n1kedj.fsf_-_@gnu.org> Date: Wed, 13 Sep 2023 23:10:16 -0400 In-Reply-To: <87r0n1kedj.fsf_-_@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Wed, 13 Sep 2023 22:27:36 +0200") Message-ID: <8734zhv49z.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam: Yes X-Migadu-Spam-Score: 6.52 X-Spam-Score: 6.52 X-Migadu-Queue-Id: 42F3757C0A X-Migadu-Scanner: mx0.migadu.com X-Spam: Yes X-TUID: aShGU7CRqb7x Hi, Ludovic Court=C3=A8s writes: > Hi, > > Maxim Cournoyer skribis: > >> Partially addresses . >> >> * gnu/packages/avr.scm: Add commentary comment. >> (avr-gcc): Turn into this... >> (make-avr-gcc): ... procedure. >> (avr-libc): Likewise, into... >> (make-avr-gcc): ... this. Adjust native-inputs accordingly. >> (avr-toolchain): Likewise, into... >> (make-avr-toolchain): ... this. >> * gnu/packages/avr-xyz.scm (simavr) [propagated-inputs]: replace avr-too= lchain >> with a call to the 'make-avr-toolchain' procedure. > > [...] > >> Fixes . >> >> Before this change, simply adding the following import: >> >> modified gnu/packages/firmware.scm >> @@ -42,6 +42,7 @@ (define-module (gnu packages firmware) >> #:use-module (gnu packages admin) >> #:use-module (gnu packages autotools) >> #:use-module (gnu packages assembly) >> + #:use-module (gnu packages avr) >> #:use-module (gnu packages backup) >> #:use-module (gnu packages base) >> #:use-module (gnu packages bash) >> >> Would cause byte compilation and/or evaluation to fail due to a circular >> module dependency. [...] > People will lose the ability to install those toolchains, for instance > with =E2=80=98guix install propeller-toolchain=E2=80=99, or to upgrade pr= ofiles that > contain them (though =E2=80=98guix install axoloti-runtime=E2=80=99 is st= ill good, for > instance). > > I=E2=80=99m not sure whether that=E2=80=99s acceptable, but we should che= ck with known > users of this, such as Ricardo. It's a pity to loose that ability (it's also a pity to not be able to simply 'guix install gcc-cross-some-target', for the same reason) but the statu quo where pulling (gnu packages avr) causes hard to grasp failures is worst, in my opinion. I wasn't able to work on adding packages dependent on (gnu packages avr) for that reason. Debugging was a pain. > I=E2=80=99ve always felt that these toolchains should be provided as part= of the > =E2=80=9Cregular=E2=80=9D cross-compilation framework in cross-base.scm. = Packages that > always need to be cross-compiled (to AVR microcontrollers, etc.) would > have a hardcoded #:target in their =E2=80=98arguments=E2=80=99 field. I = forgot why this > was rejected. That'd be an improvement, I think. Right now we have to call a procedure in the input fields everywhere, it's not very elegant. Until then, the change proposed here seems the best we can do. I've been adding new avr-dependent firmware packages in (gnu packages firmware) happily on top of it. --=20 Thanks, Maxim