From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id MOCXETU9HmXLgAAAauVa8A:P1 (envelope-from ) for ; Thu, 05 Oct 2023 06:36:05 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id MOCXETU9HmXLgAAAauVa8A (envelope-from ) for ; Thu, 05 Oct 2023 06:36:05 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BB5E452CBB for ; Thu, 5 Oct 2023 06:36:04 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="KMuioN/B"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1696480565; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Lmn3DSeCfq1MmP0TfUWjOqkjYSXFsVWLYmWGS0Z9o0Q=; b=HAvmelRwyX7C2aeAcGoaVAEVbBBeXy4ANvaEv0M9pO4vLFZFm5Uyw53+PYWU+6paisEGfB fs8/32DJNwVS8vemgR/KToc6DOhJ3r5SV3slVSYALslRsq5XdiDVhhBwdzrKUmD/D8iLDK tBKd2ucJVqHAoQ4bsfqNg+I0Gqg6ZnjVKmcf/95Gg45Zq8COmXb7IlEEU9OYjda8qyW4ru eH0/gMxQS3FG897Twlxki/TCTWFeLbaEgA4U1beIYMfR/xV/j4eaOOHdNQyTN0ePcXaVyn On0he7pYCepOFM46lsiFP0Cu4dAtN09bWm2zfTpthGIO3FGildszO6oIprpUPA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1696480565; a=rsa-sha256; cv=none; b=uvRK6SEl7ZiA1WhoI2w5j5EVE+yVJDiym/pZ2hnd1vRwcnovi5pLTY6QxkPDjxn0mq3N7M VK1WvpqON61ROiGbhoX2wte38/7kzPUcvUQDDJc2XxxAVXeGgGYFog3Ru2HJaCaT7caQbZ eSMziWEpJaFTzFrizsCBNyGXhNq84Zb6tpdLlk3XpboboL/cjvZUiye6kkR4OdO9jqHhp+ oplmaDPtJZfGzy9gAfG0NjNv9lrBpmHjDi9/0bQyqEeG03q3jX3RmtAhlJxqQZSwtTfesc 2CmOrcdNPA26BbwufGGHqbhAhrq4q4UosNng+aVnRVO+VqphywsBYoKlG33ehg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="KMuioN/B"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qoG5S-0000eZ-H9; Thu, 05 Oct 2023 00:35:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoG5Q-0000e7-IU for guix-patches@gnu.org; Thu, 05 Oct 2023 00:35:44 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qoG5Q-0001JJ-A9 for guix-patches@gnu.org; Thu, 05 Oct 2023 00:35:44 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qoG5i-00007T-0w for guix-patches@gnu.org; Thu, 05 Oct 2023 00:36:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66263] [PATCH 00/23] guix: Add avr as a platform. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 05 Oct 2023 04:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66263 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jean-Pierre De Jesus DIAZ Cc: 66263@debbugs.gnu.org, vagrant@debian.org, efraim@flashner.co.il Received: via spool by 66263-submit@debbugs.gnu.org id=B66263.1696480504370 (code B ref 66263); Thu, 05 Oct 2023 04:36:01 +0000 Received: (at 66263) by debbugs.gnu.org; 5 Oct 2023 04:35:04 +0000 Received: from localhost ([127.0.0.1]:45705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qoG4m-00005p-0f for submit@debbugs.gnu.org; Thu, 05 Oct 2023 00:35:04 -0400 Received: from mail-qv1-xf30.google.com ([2607:f8b0:4864:20::f30]:47264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qoG4j-000054-AI for 66263@debbugs.gnu.org; Thu, 05 Oct 2023 00:35:02 -0400 Received: by mail-qv1-xf30.google.com with SMTP id 6a1803df08f44-65b051a28b3so2879666d6.2 for <66263@debbugs.gnu.org>; Wed, 04 Oct 2023 21:34:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696480477; x=1697085277; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=Lmn3DSeCfq1MmP0TfUWjOqkjYSXFsVWLYmWGS0Z9o0Q=; b=KMuioN/BfYzSPcj51Nl32leWM14e6vH5UTLzKp3/xijZR8PYzeAF+qin6xhynhyCGY 7l1OgueQLk4wN+Cy3tjCHv5E4liPqsHqm3ZHJIp1HGHrw0UPnCzvG1OjoNw9Fu5Pjksi JAADnJ1K4K+UOwmFGiLC9Fj/+H7+5KAFHOEOTfZ7DoMI6bUb9aceCpDL9FTvpVfp31B6 B9BZWOS6+8IjeBmA0MEiHA4a5mXrB1hYBMyByEJofP7Ny71HutQ3BldK+nYsj+6nTpO/ s4TmxAA4v1mqanmyvKcTvhuAJdTUciqkF7O3kZ7DXZEPDzryGdVVOrn9ae2P7c8jECXO 6AHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696480477; x=1697085277; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Lmn3DSeCfq1MmP0TfUWjOqkjYSXFsVWLYmWGS0Z9o0Q=; b=PBABp3aMj5Ldndg4AAWCmaJ33O+rR98P/X8i2L59Vwax4ZzDIrGjF6fR+gdwezMk4I LXmIIXcLtZ5tOdhanveuwCnKcrc/ld0yzX5KeTJYQYyjhL/HHlknzwQueaRfCgmsZPt1 n63uYJERmtXEQlEf4NkZgFXipxh5nFy04oEZeaLjXBDeu2SnBVwIGzLU9CokARqSDLSF nMQIvS4uRnGcEMRA1i+9QfkIzK5A73YTtpKpTTKC+HL8fk1VXYOTSxwXJeDkU3JoSOrX V7oEAB7s0fDg6JtODKcTghyd9prWjQ+/CnNVFRiEx8Ui49NtlcRcsqsqXr4szM3X0cpU opkQ== X-Gm-Message-State: AOJu0YxL6dHTbcZqrU46lkw2cknCDNEdusJ9i20X+A83Ca57J2TZrV8m fdh/7wWoRIFdBHX2f4XctQw= X-Google-Smtp-Source: AGHT+IF6kHZsisFN8SsO535eMMwEmFB/OcKPyEbKB3Qn6znpoNimZgt9qJSFdFaTtKt9rmjuwfx4Xg== X-Received: by 2002:a0c:f4c3:0:b0:655:d2c7:a9d1 with SMTP id o3-20020a0cf4c3000000b00655d2c7a9d1mr3799390qvm.14.1696480477596; Wed, 04 Oct 2023 21:34:37 -0700 (PDT) Received: from hurd (dsl-141-24.b2b2c.ca. [66.158.141.24]) by smtp.gmail.com with ESMTPSA id m10-20020ae9e70a000000b0076dae4753efsm229324qka.14.2023.10.04.21.34.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Oct 2023 21:34:37 -0700 (PDT) From: Maxim Cournoyer References: <20230929091627.7820-1-jean@foundationdevices.com> <20230929091627.7820-9-jean@foundationdevices.com> Date: Thu, 05 Oct 2023 00:34:36 -0400 In-Reply-To: <20230929091627.7820-9-jean@foundationdevices.com> (Jean-Pierre De Jesus DIAZ's message of "Fri, 29 Sep 2023 11:16:13 +0200") Message-ID: <8734yp1ycj.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -5.12 X-Spam-Score: -5.12 X-Migadu-Queue-Id: BB5E452CBB X-TUID: 2B/6qcaDTexg Hi, Jean-Pierre De Jesus DIAZ writes: > * gnu/packages/cross-toolchain.scm (make-cross-gcc-toolchain): New > procedure. You forgot to mention the registration of the new module in the local.mk file. [...] > +++ b/gnu/packages/cross-toolchain.scm > @@ -0,0 +1,58 @@ > +;;; GNU Guix --- Functional package management for GNU > +;;; Copyright =C2=A9 2023 Foundation Devices, Inc. > +;;; > +;;; This file is part of GNU Guix. > +;;; > +;;; GNU Guix is free software; you can redistribute it and/or modify it > +;;; under the terms of the GNU General Public License as published by > +;;; the Free Software Foundation; either version 3 of the License, or (at > +;;; your option) any later version. > +;;; > +;;; GNU Guix is distributed in the hope that it will be useful, but > +;;; WITHOUT ANY WARRANTY; without even the implied warranty of > +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +;;; GNU General Public License for more details. > +;;; > +;;; You should have received a copy of the GNU General Public License > +;;; along with GNU Guix. If not, see . > + > +(define-module (gnu packages cross-toolchain) > + #:use-module (gnu packages avr) > + #:use-module (gnu packages cross-base) > + #:use-module (guix build-system trivial) > + #:use-module (guix packages) > + #:use-module (srfi srfi-1) > + #:export (make-cross-gcc-toolchain)) I'm a bit confused; why do we need this new module; couldn't it live in (gnu packages cross-base)? Also, there are extraneous imports: (gnu packag= es avr) is not needed for one. With a recent Guile you can check for such imports with --8<---------------cut here---------------start------------->8--- guild compile -W3 your-file.scm --8<---------------cut here---------------end--------------->8--- > +(define* (make-cross-gcc-toolchain target > + #:key > + (libc (cross-libc target)) > + (xgcc (cross-gcc target #:libc libc)) > + (xbinutils (cross-binutils target))) Please add a doc string, and memoize packages returning procedures like this one. > + (package > + (name (string-append (package-name xgcc) "-toolchain")) > + (version (package-version xgcc)) > + (source #f) > + (build-system trivial-build-system) > + (arguments > + '(#:modules ((guix build union)) > + #:builder (begin > + (use-modules (ice-9 match) > + (guix build union)) This will work as long as all the file names are ASCII only, as there's no locale support in the trivial-build-system. I guess this is not a problem here, but just mentioning it, as it bit me in the past. --=20 Thanks, Maxim