From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id wEJrI+DSNWXRlgAAG6o9tA:P1 (envelope-from ) for ; Mon, 23 Oct 2023 03:56:48 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id wEJrI+DSNWXRlgAAG6o9tA (envelope-from ) for ; Mon, 23 Oct 2023 03:56:48 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3C2523DF22 for ; Mon, 23 Oct 2023 03:56:48 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=JH1QGIf+; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1698026208; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=bFEfs8bFlQm3YBSkg6jG4/B0Qu2a3Cbc95IrD0+H1qY=; b=hwUR4QGE4Jwf8bEvk710XGm9f8NIwDogjRrXa1faz4+8tPnqUeuspTaebTfLEmN2wSFqls JVfYuRxCs1aGCumBAZHEe7SeospULuqRtXb39ZAGGfgtxbeSmCWNYJ8olByhQjsyXazmjZ 8Y085rMoVJYQYWaG0NpfGpAL4M4P1/aiAkpGhf3AMLGmOJTN5Gi07QWMShhbEasDcBVsYg 9Z9wRyXXa4wCThy8jk53W/cER3Wrtb8kzKs3H1P17raPGkc2y0ROc0JhiY8uhsTOhpwbFK rM2zb08m0qESlIJ6gbfAhi9fPOTNqCbXNY7h1GT81LfyV6v01+TzmfbNSqXS1Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=JH1QGIf+; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1698026208; a=rsa-sha256; cv=none; b=WUFTpImqjgblp9uQebNzdULmzth3RJDO1oljaPWfv059NEmn1zS7PZxvsMzdNoV3FVZA3W Mpgr5IaDtVsWyvbkjDe8RMtBLJYpQJ5FBrngLt2ChKtq98KUfzJq+MIAHfGvy+TwR0GlSg I0govU1hW7AtFnyDmCUlHSxqwklhuu8UpM1PxHDYsycyYzyv2C9R51ohbBc4DsbI/bN4yg rlmrw1FKFaBV310/RtDJ8ZJT/eDR09vo44VYjX5FIAhZsl068ULYrd5ud7pJXizE/deSDp Iu+zoULDL4+G3JovbnCHJjnwEgATAhFUiVAx9cLikGyk91rducz1b0Bq+T+ZhA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qukBI-0006ks-B7; Sun, 22 Oct 2023 21:56:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qukBG-0006kX-61 for guix-patches@gnu.org; Sun, 22 Oct 2023 21:56:35 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qukBF-0005cN-Tg for guix-patches@gnu.org; Sun, 22 Oct 2023 21:56:33 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qukBi-0006Tz-6H for guix-patches@gnu.org; Sun, 22 Oct 2023 21:57:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 23 Oct 2023 01:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Cc: 66436@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.169802619824885 (code B ref 66436); Mon, 23 Oct 2023 01:57:02 +0000 Received: (at 66436) by debbugs.gnu.org; 23 Oct 2023 01:56:38 +0000 Received: from localhost ([127.0.0.1]:48637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qukBH-0006TF-5N for submit@debbugs.gnu.org; Sun, 22 Oct 2023 21:56:38 -0400 Received: from mail-qt1-x831.google.com ([2607:f8b0:4864:20::831]:58370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qukBC-0006Sx-Id for 66436@debbugs.gnu.org; Sun, 22 Oct 2023 21:56:34 -0400 Received: by mail-qt1-x831.google.com with SMTP id d75a77b69052e-41cbf8e1f77so16259291cf.0 for <66436@debbugs.gnu.org>; Sun, 22 Oct 2023 18:56:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698026156; x=1698630956; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bFEfs8bFlQm3YBSkg6jG4/B0Qu2a3Cbc95IrD0+H1qY=; b=JH1QGIf+xq6WnGvtwvhFdQdZ+a2Hh29rqIiDaVYoj6aDIUD+pAYT9cEAeWXlO4yunQ c8j/LVE/24xQASpKeKFslaQYoliadFccx4oBcVeaV3/mOokKvZ1hObA1VAJK+OdyU9QT VhPEeyp9mXR18M8VtmPk07G4lDgsA/KQrZ5lAl3o0r8Ti8dKahnj2D9S15gi3LpBrOPK vfafgamskvJTguKEY8SAta4CjIDEjrIL4r2gvTtuawGWGhT79oePK4o6AkEybiYnx4gf 6mqslGUkf1BSZsc51fhtL9QqI9cXPLNzPPLEPznOi1wFEM2fMrF5QnhVQ2eoFFhWiGp/ 35pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698026156; x=1698630956; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=bFEfs8bFlQm3YBSkg6jG4/B0Qu2a3Cbc95IrD0+H1qY=; b=WbBRIrMk/ABYRFdf8UOcbJxMtw0irQxD7nQ6MLfzNRXBlA+luDuGR1hcVn5o8dd1kr iM03VFk6dU6Pbn23YOnpnV8q7lzfp5y44HyUm+cTtKl4ZbrNDQp093iKcRQGS3HniWnr HtC6aw9MU0/H0pjXNMm1j51i/K+MRN6MGPN15M327TkYveyxcHmshQU3+42/8PQMVbfz mnRPjmPAuU2NeT4lIZra2J2DieL9rsCbwBrvz84x0X31UUPsrI3VFkOnJ4w7OlaODIIO AHQoq5TCLlMtbrW97qqV4NowtxtC8hvaVIprgepV9O9yluXpvOiWpbO5mgaX314BOBNn wJQQ== X-Gm-Message-State: AOJu0YyooQ08oXPaciM+ex71t6pmUGwnT0eCJdb08LE25I6OM6y1pFbr +LLU/8lLDsHs95YsWuBTAsQ= X-Google-Smtp-Source: AGHT+IEnoQlIQTLyy64woTgy0F8Yk42BAudpxUQH7KPNsgEHLtME3SKPIv9WxHnWG5sSDfFq9bn91Q== X-Received: by 2002:a05:622a:490:b0:41c:e206:349b with SMTP id p16-20020a05622a049000b0041ce206349bmr5672939qtx.68.1698026156094; Sun, 22 Oct 2023 18:55:56 -0700 (PDT) Received: from hurd (dsl-205-236-230-191.b2b2c.ca. [205.236.230.191]) by smtp.gmail.com with ESMTPSA id t10-20020ac8738a000000b00417db2593bdsm2384501qtp.72.2023.10.22.18.55.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Oct 2023 18:55:55 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: <87il6ybf27.fsf@lassieur.org> ("=?UTF-8?Q?Cl=C3=A9ment?= Lassieur"'s message of "Sun, 22 Oct 2023 22:03:12 +0200") References: <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> <0a5e027af3c0b61f9ab9f3c66e73b7a769eef7fd.1696983695.git.maxim.cournoyer@gmail.com> <87h6mlzp9g.fsf@lassieur.org> <87r0logap6.fsf@gmail.com> <87il6ybf27.fsf@lassieur.org> Date: Sun, 22 Oct 2023 21:55:54 -0400 Message-ID: <8734y29k5x.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: 3.59 X-Spam-Score: 3.59 X-Migadu-Queue-Id: 3C2523DF22 X-Migadu-Scanner: mx2.migadu.com X-TUID: Qt2PUM4Ispaq Hi, Cl=C3=A9ment Lassieur writes: > Hi Maxim, > > Maxim Cournoyer writes: > >>> 1. What should the reviewer do with old-style patches, like the ones >>> that don't use G-Expressions? Should we tell the submitter to use >>> them when possible or is it only a matter of style that is up to the >>> submitter? Obviously they are hard to grasp for newcomers. >>> >>> It's probably good for newcomers if we teach them how to use >>> G-Expressions but we don't really have time to do so, given the >>> number of patches waiting to be reviewed. >>> >>> This question could be extended to style issues. Like using %var >>> versus var. >> >> I think we should now make sure all new submissions use the current >> style; if they aren't we can demand of the contributors to adjust it. >> There is a blog post and enough examples in the code base already that >> should make this not too difficult. > > Are you referring to this one? > https://guix.gnu.org/en/blog/2023/dissecting-guix-part-3-g-expressions/ Rather to the one corresponding to the 1.4.0 release, which introduced these new changes: . --=20 Thanks, Maxim