From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id sO8NERnZqWWqVgEA62LTzQ:P1 (envelope-from ) for ; Fri, 19 Jan 2024 03:06:17 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id sO8NERnZqWWqVgEA62LTzQ (envelope-from ) for ; Fri, 19 Jan 2024 03:06:17 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=Tan05v7I; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1705629977; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=/62Rlj6DoHWdvj6SdJwHUsyxwrpcNcwDZyzSpPcDlu0=; b=EyJWrbng99TsYyqDR6rXC60kWKLMa7NOwBOi98kFsuCjidNkwn/knDD+DLmpL5y8g3l2Q/ C/WGLQDwV6j+MCZc66jRKAMoC5GkXSB910ZOK09Xjo+2KuzmSSrFlzoupFVX9o1mgnenx6 1Wp3+klFyUwdFZMSKbiCQCViVisS+t6vgGEb7a8q6gPB+Y5h5z381v6RY5ewlROt0xaYJy fRqgvAKtcr8gurFE8jPyIFY42QjRFfBK+tGdSwDNdMBzS9m76HjpOLkR8yx8TsFSQCvl9L a7bkX8faoTuKdIuIFlzH2sY5ajKbQhrhq/V1DHowCUlahewRcEYgJS9eAYqIrw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=Tan05v7I; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1705629977; a=rsa-sha256; cv=none; b=c9b/tH1C/CO5LH94tcXuArftDdKzGk8m83XW33t1IzZdvGTuvOSRyq5P2CmWZ8CfdLYdPK Ifpl5Y6LSR0ToQURj463tlG77Ws4m5SgzYTXU1qVgdpMK0E24zA2ma2IZU8C9qUSDk3qXq YJExh5RyaFhr409NO2c/xOi6X3p9Jnn82MSfLo7bP10zfNctKnqjPuavSUlFQZM5mM3d9a CygHBGwju2AIEjtDY4s90aSeE+rbVTmPL9NBIVOaIZK6cqVCxSQJycED2KywJBrh6BbL9F /kwDZttjNGX8eE/ln3brEALwH8LkypuFbFQJlMpgIMYSj9GUsQexLEkiEYD6GQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E2C3732F41 for ; Fri, 19 Jan 2024 03:06:16 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rQeGj-0002pB-Gj; Thu, 18 Jan 2024 21:06:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQeGf-0002oo-Jy for guix-patches@gnu.org; Thu, 18 Jan 2024 21:06:03 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rQeGd-0006Xw-Vg for guix-patches@gnu.org; Thu, 18 Jan 2024 21:06:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rQeGf-0006kS-K1 for guix-patches@gnu.org; Thu, 18 Jan 2024 21:06:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68250] [PATCH v2] gnu: mpv: Fix pkgconfig file. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 19 Jan 2024 02:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68250 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hilton Chain Cc: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= , 68250@debbugs.gnu.org, Munyoki Kilyungi , Zheng Junjie , Lars-Dominik Braun , Josselin Poiret , Andrew Tropin , jgart , Marius Bakke Received: via spool by 68250-submit@debbugs.gnu.org id=B68250.170562995425924 (code B ref 68250); Fri, 19 Jan 2024 02:06:01 +0000 Received: (at 68250) by debbugs.gnu.org; 19 Jan 2024 02:05:54 +0000 Received: from localhost ([127.0.0.1]:57064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rQeGX-0006k3-Vg for submit@debbugs.gnu.org; Thu, 18 Jan 2024 21:05:54 -0500 Received: from mail-qv1-xf31.google.com ([2607:f8b0:4864:20::f31]:61910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rQeGU-0006jk-T5 for 68250@debbugs.gnu.org; Thu, 18 Jan 2024 21:05:52 -0500 Received: by mail-qv1-xf31.google.com with SMTP id 6a1803df08f44-68174626bb9so2259916d6.3 for <68250@debbugs.gnu.org>; Thu, 18 Jan 2024 18:05:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705629943; x=1706234743; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/62Rlj6DoHWdvj6SdJwHUsyxwrpcNcwDZyzSpPcDlu0=; b=Tan05v7IciqNe+fGc0HbjbC71yaYI0WPtPiVDVwUO77wmOIZbaE9KwGKPbAwa9FTAP m2aKBdquBYytgBMGn8MNvq85RcdxYi568Al5Q60U5z3si3jV4Njr+rmEKTY73ZW01Ci8 1EZCVDjzscfNi1x5WnE80Mf+yJpvJ5MZ67rjLZKXSsNGzMVyfj0dtAdcGUYrdSJTV3pd hEORijzDSmPmqktQeHY/PeNjN9d4QykFO25+Ylw81pLf1BUMIdMsCdKJDIHXYYfsgaGM 45P2J3uxQBtSFmobtKoefb5hH5HIYvw+ZlZyOYi5zSevRTDdPHbYVjOMKsv2UQeYFikQ Ntow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705629943; x=1706234743; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/62Rlj6DoHWdvj6SdJwHUsyxwrpcNcwDZyzSpPcDlu0=; b=hjN8DmRy1Pz3hHcLqkxKptFRSw9mNLeZuWWBjMsATa3sDkve1aSbHXuI1dT47Kk5C0 iD1NaJVt754Rs+driutXvIrMiwo9wu4ivQGbvLPsvARFAN0XrHoodRAzjQsNyqYkuKFS +5VBptNIOWWyXnX59rPshO7Cm003eqxvDruRiQIqOEHSkniZGa8fltfn4mouGU+7g6AU Ok+1iyaDhfnjgkbVp8OrqryQH/9q4TufkCmEpHsviZvVWsReTYrFX0Qip4mLFK+T38kG Vi0hzFDPWILfyE6i8+Vj7QC2bFL+sgMf8Pey7JRaH0jc93gcNtUwVi8VZoQMEthB2F9a ZkVw== X-Gm-Message-State: AOJu0YyR1NCjpmMetOSBE0CLYuOjWIIyB8TYnCvDi1BLAKhjwjNFQL+Q HXconERhPjeHeNDvhsjxiBQS/7fKdN0vnloDsfqB6hi7zZAJVUSc X-Google-Smtp-Source: AGHT+IHxgPS1y5jcXfvVzsjIjFvaWraUlQ2UmwnbFaVmvM4GubFMYNRhKS2I6Ep68CJp3FeNmd3wJA== X-Received: by 2002:a05:6214:1bcf:b0:681:789f:4358 with SMTP id m15-20020a0562141bcf00b00681789f4358mr2068266qvc.39.1705629943319; Thu, 18 Jan 2024 18:05:43 -0800 (PST) Received: from hurd (dsl-10-132-160.b2b2c.ca. [72.10.132.160]) by smtp.gmail.com with ESMTPSA id oh10-20020a056214438a00b0068187f22739sm1356864qvb.39.2024.01.18.18.05.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 18:05:42 -0800 (PST) From: Maxim Cournoyer In-Reply-To: <14315fb383a6560c67bdc6bf3f7cab8b8e36e0bb.1704514279.git.hako@ultrarare.space> (Hilton Chain's message of "Sat, 6 Jan 2024 12:23:49 +0800") References: <521d0ba6e3d10b3b8aa98b35862d819c82223412.1704430613.git.hako@ultrarare.space> <14315fb383a6560c67bdc6bf3f7cab8b8e36e0bb.1704514279.git.hako@ultrarare.space> Date: Thu, 18 Jan 2024 21:05:41 -0500 Message-ID: <8734uukrgq.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 2.31 X-Spam-Score: 2.31 X-Migadu-Queue-Id: E2C3732F41 X-Migadu-Scanner: mx12.migadu.com X-TUID: xgrkBrBkIKwE Hi, Hilton Chain writes: > This is a follow-up to ce7b2b57aa6da0ceace94ea5fb42392c7ff97d53. > > * gnu/packages/video.scm (mpv)[arguments]<#:phases>: Add 'fix-mpv.pc. > > Suggested-by: =E5=AE=8B=E6=96=87=E6=AD=A6 > Change-Id: I9826d5d6c957ca3022fa326aee111edb533f05bc > --- > gnu/packages/video.scm | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm > index e70aa5352e..10d46db38b 100644 > --- a/gnu/packages/video.scm > +++ b/gnu/packages/video.scm > @@ -2365,7 +2365,13 @@ (define-public mpv > ;; and passed as linker flags, but the order in which they= are added > ;; varies. See . > ;; Set PYTHONHASHSEED as a workaround for deterministic re= sults. > - (setenv "PYTHONHASHSEED" "1")))) > + (setenv "PYTHONHASHSEED" "1"))) > + ;; mpv.pc is generated by meson. libmpv's headers don't actua= lly > + ;; require these dependencies so it's safe to remove these two= fields. > + (add-after 'install 'fix-mpv.pc > + (lambda _ > + (substitute* (string-append #$output "/lib/pkgconfig/mpv.p= c") > + (("^(Requires|Libs)\\.private:.*") ""))))) > #:configure-flags > #~(list "-Dlibmpv=3Dtrue" > "-Dcdda=3Denabled" I've just seen this, after pushing a hot fix as f3fdb4e041cb5740ba0b38b9ad017571f8414d33, which propagates all listed libraries in Requires.private. I suppose that someone wanting to build something statically from mpv would benefit from having the original mpv.pc file without modifications. Perhaps we can try it out for a bit, and if the propagation causes problems, we can fall-back to this change here? --=20 Thanks, Maxim