From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id gO33DYDI2GXMJgEAqHPOHw:P1 (envelope-from ) for ; Fri, 23 Feb 2024 17:32:00 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id gO33DYDI2GXMJgEAqHPOHw (envelope-from ) for ; Fri, 23 Feb 2024 17:32:00 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=UFWMdKCz; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1708705920; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=0mSxxpshL/EU+E+eJ2McFr7Bt88ket6Qn0W+MZ6c3i0=; b=BVlp0jvotUxKtacAMh4g2dihZuRHFLv6TqB0wFCbuYtKjXzNOO5CXCNiL9ZWMEpDOTRL98 wtv7dGsSVWiDmdUHb05Q91kh90K1hysTsGTfjJVlCWBXvc+EZF/D2c+dVUgew2iqmQV9wJ H7E0/sMcYDCk8X8qoWrXlyisZ/1C6E6K+IktrX1p3RMSi2ojmSkEdltLmG8GoiFBR4L/jn oUTM+HSUUazcBApu5uRjuzrDNGMv02eVI3qA7peYTsHwA0RqLjpjFhh55crJt7umMotFd5 0+tHaTYIS+H/TMgERBEKbwtRWMxN1gLp2nZnw6jLgP3L2XYxi4xYjewM17oBkg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=UFWMdKCz; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1708705920; a=rsa-sha256; cv=none; b=IphjgcsllQagmcTrncrW5Kxu56lP7j9vaDod/KAjHAiF/LUTlq7yE9ZNk3IrqivSkU/ZQQ kHLsIvrYkDcEMhm9m2KT1kKfCgRLvNXU5t4oyyQFsvPB45qOM1fsh32yHySRDBsrJaaqJo XZTpI+WLy8givtUMcvIibGcUh6Pm3OSUbkqTbzZflDr7DTnPtvkpDuQGy+9jG1WRpEjxcP 1rRCmIvF7ymcyG8Tj3ske6UdxXcZ/xZCEs3dHI9qBE+BWhKr2mnyO7ZNRShYyg5zLFJ3Ta fn1SVU80wGzvN1995VeFV/zfH4HZdtRBDH0qSCeMtcG+8+zmTcuPBEHSje4Zbw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 98EDB10C85 for ; Fri, 23 Feb 2024 17:31:59 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rdYSo-0007Ry-8z; Fri, 23 Feb 2024 11:31:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdYHu-0003kL-GU for guix-patches@gnu.org; Fri, 23 Feb 2024 11:20:38 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rdYHu-0005ld-6y for guix-patches@gnu.org; Fri, 23 Feb 2024 11:20:38 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rdYIH-0003ij-OB for guix-patches@gnu.org; Fri, 23 Feb 2024 11:21:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#69291] [PATCH 2/5] scripts: substitute: Allow not using with-timeout in download-nar. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 23 Feb 2024 16:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69291 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , 69291@debbugs.gnu.org, Ricardo Wurmus , Christopher Baines Received: via spool by 69291-submit@debbugs.gnu.org id=B69291.170870522114199 (code B ref 69291); Fri, 23 Feb 2024 16:21:01 +0000 Received: (at 69291) by debbugs.gnu.org; 23 Feb 2024 16:20:21 +0000 Received: from localhost ([127.0.0.1]:51313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdYHc-0003gu-Se for submit@debbugs.gnu.org; Fri, 23 Feb 2024 11:20:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37830) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdYHb-0003gX-IF for 69291@debbugs.gnu.org; Fri, 23 Feb 2024 11:20:20 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdYH7-00050K-9n; Fri, 23 Feb 2024 11:19:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=0mSxxpshL/EU+E+eJ2McFr7Bt88ket6Qn0W+MZ6c3i0=; b=UFWMdKCzkPFSlms5+AxE ZWJjQE4UqjKFQ64S0ja68hW1Pmiv95GOg24R4yrR+1JhaG/j0Q1bccv7fLA8kfNG/I4436//P2Wll 9QDWHKL2TDtmpF9O4U361Hy9xeu/2Itclv7sxnNgdY13q53MirXW19DC5Rnnce/CSZQmC7p68NzWh Y3vHvIJckMU7xHvU8wa3j/hiEIaZQM7XpdrUXyN3p7N+EGV7zeog0zBtsWdhpYEee/Frstg8bjUJY AQWxovAmG/d4BZowt2klABXtJXHAiclo4K7OBEDwlwahW97MJ4PMIG+UJ7oaK162CLvMUQtf55DLv ZH2VQ6P/m8u+ig==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <2bcc2278b5aefcd81fbc53b791d08622b6d93c7c.1708458147.git.mail@cbaines.net> (Christopher Baines's message of "Tue, 20 Feb 2024 19:42:24 +0000") References: <2bcc2278b5aefcd81fbc53b791d08622b6d93c7c.1708458147.git.mail@cbaines.net> Date: Fri, 23 Feb 2024 17:19:46 +0100 Message-ID: <8734tjgnkt.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -2.84 X-Spam-Score: -2.84 X-Migadu-Queue-Id: 98EDB10C85 X-Migadu-Scanner: mx13.migadu.com X-TUID: lWQCes2YPgDl Christopher Baines skribis: > I don't think the approach of using SIGALARM here for the timeout will wo= rk > well in all cases (e.g. when using Guile Fibers), so make it possible to = avoid > this. > > * guix/scripts/substitute.scm (download-nar): Pass the fetch timeout in a= s an > option. > > Change-Id: I8cbe6cdfa10cdaa7d41974cbea56a95f5efecfe6 The patch LGTM. That said, maybe we should just pass #:timeout to =E2=80=98http-fetch=E2=80= =99? It=E2=80=99s not strictly equivalent because it only controls the timeout on connection establishment, but in practice it should have the same effect. Ludo=E2=80=99.