From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 4BfLBWbACWa2XgEAqHPOHw:P1 (envelope-from ) for ; Sun, 31 Mar 2024 21:58:30 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id 4BfLBWbACWa2XgEAqHPOHw (envelope-from ) for ; Sun, 31 Mar 2024 21:58:30 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=fsfe.org header.s=2021081301 header.b=cbS76g6l; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fsfe.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1711915110; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=9o+wBwqqYgWcrdMzPKZ4dLlF0RT66Qxw5WAqLYELs1c=; b=Oui2vehMwiS5xDvFoLboMACovSu6Am08EVwx4JRJr5rqoNFjrT3qKIaIn/2Y/q7Itx6Ws/ VPyFUz+2xW4Q8OTULtV2mD9/OS/ie9Wm5zRA/RfQvtkYToNbfc/EADeK5AEzBXOw2jGJJ7 UoU4AZJKVOP0cNvUqgtgCS2MU50rUSfsFn3SFaGJGg1r9u12DMLGUAF9faQbTWGK008X+p TyRm4PCVuy4ACwa/slDj2E0L1oUvidBBUIMIAQrJgitHFAVEely5elFzyI4SfL1tKn7659 sJmbuBX+UHVqtjYmn3kcgnNLcpNSCdWStbbYx7uBK8HHzMyqFDVRSrxN4G/KuQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=fsfe.org header.s=2021081301 header.b=cbS76g6l; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fsfe.org (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1711915110; a=rsa-sha256; cv=none; b=scYrjj1wSvwFkozRDlkDeum+bi3e7m6wFr3UktbMq7iYXMljKzboMNsct2gH1QSTYHsvV2 qVfhb5xWnWgVWyPopJKmnlYROfvryPo5MfK4/RYoDfjqTthTZge8ps/vCQ9cFeW/KGgAlG NG4mFptlaulHhnmH9Lyw2uMv0pKn8i7g0xIAsGHucy+kLXgyyh9DL086oqmB3s8+m0c6ua bqVN9mPaZZESyDMUzee4FDERdizeZitcGBRlxEYlliKTh0jGcEvBm3wOIAi8Y0OVdYILF6 hJf8TgHgXHfCs+I4wM/vrQgTEQMnOOHMnwlaheO9jTS0KA0GULFfQ/1sTm5HZg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B20AE615FD for ; Sun, 31 Mar 2024 21:58:29 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rr1Jc-0006VG-E6; Sun, 31 Mar 2024 15:58:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rr1JY-0006UQ-Ri for guix-patches@gnu.org; Sun, 31 Mar 2024 15:58:00 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rr1JX-0006RA-98 for guix-patches@gnu.org; Sun, 31 Mar 2024 15:57:59 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rr1JZ-0006S1-VC for guix-patches@gnu.org; Sun, 31 Mar 2024 15:58:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62375] Continue the npm-binary importer Resent-From: Jelle Licht Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 31 Mar 2024 19:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62375 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch moreinfo To: Pablo Zamora , "62375@debbugs.gnu.org" <62375@debbugs.gnu.org> Received: via spool by 62375-submit@debbugs.gnu.org id=B62375.171191503724628 (code B ref 62375); Sun, 31 Mar 2024 19:58:01 +0000 Received: (at 62375) by debbugs.gnu.org; 31 Mar 2024 19:57:17 +0000 Received: from localhost ([127.0.0.1]:48504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rr1Ir-0006P8-7Z for submit@debbugs.gnu.org; Sun, 31 Mar 2024 15:57:17 -0400 Received: from mail2.fsfe.org ([2001:780:215:1::55]:53906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rr1Io-0006Ou-MC for 62375@debbugs.gnu.org; Sun, 31 Mar 2024 15:57:16 -0400 From: Jelle Licht DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fsfe.org; s=2021081301; t=1711915028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9o+wBwqqYgWcrdMzPKZ4dLlF0RT66Qxw5WAqLYELs1c=; b=cbS76g6lsc9WMuyk89Yhdv8Ji/GMT98B3H7DNEh8FU7PEH4Ck0mkhIx+VK9G8BWq/eiE0N SRCsFxKDt6BAtSO7ccxUesXX11KXuhOkz9DIVAbMY+IvMrfnJeIYRu1VvMEzpNSQAs0EWY zYdoErIKp586cM78XRSNqGfuJp5shD4= In-Reply-To: References: Date: Sun, 31 Mar 2024 21:57:07 +0200 Message-ID: <8734s6gooc.fsf@fsfe.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: B20AE615FD X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: 5.03 X-Spam-Score: 5.03 X-TUID: YMiNmc9OR/YA Hi Pablo, Pablo Zamora writes: > Dear Guix, > > I am stuck while trying to define the 'bitwarden' package definition on my personal channel here https://github.com/Pablo12345678901/guix-custom-channel/blob/master/dev/my-bitwarden.scm . I am facing issues due to the npm dependencies. > > One of the potential solution would be this importer. I would like to finish writing it and perform the tests. That is nice to hear! I just sent v2 of this patch addressing most of the shortcomings that were identified earlier. > On which branch should I send git pull request to continue what has been done so far ? This would be my first commit with guix. I see two ways forward, depending on how much work you foresee and/or are willing to do: 1) This patch gets through another round of review, and afterwards you can send patches based on the 'master' branch. 2) You work on improving this patch while it is still under review, and send a V{3,4,5} patch as a reply to this very thread. Kind regards, Jelle Licht