From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: Richard Sent <richard@freakingpenguin.com>, guix-devel@gnu.org
Subject: Re: Codifying/Documenting Guix commit message conventions?
Date: Mon, 01 Jul 2024 10:14:51 -0400 [thread overview]
Message-ID: <8734ot8ahw.fsf@gmail.com> (raw)
In-Reply-To: <d86dc2502bac91d371b206bd8b3f76c9589f3f8f.camel@gmail.com> (Liliana Marie Prikler's message of "Sun, 30 Jun 2024 08:25:35 +0200")
Hi Liliana,
Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> Am Samstag, dem 29.06.2024 um 21:11 -0400 schrieb Maxim Cournoyer:
>> Hi Liliana,
>>
>> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
>> > I think we should use a "Fixes: [short description] <URI>" footer
>> > for both Guix and upstream bugs, that can easily be parsed –
>> > hopefully by both humans and machines. That would give the
>> > interested reader the (contextual) information they need, while
>> > also leaving the main body to a more thorough description of the
>> > patch itself.
>>
>> That's a good idea, and I already use a "Fixes:" git trailer for
>> fixed bugs, but I also like to be able to see from the 'git log'
>> output which commits were security related (I see value in the
>> summary [security fixes] "tag").
> Oh, sure, my preference w.r.t. that would be to have [security fix] or
> [security fixes] in the header, and the particular CVEs in the trailer.
That sounds like a good idea to me.
Would someone be available/motivated to prepare a patch with these new
suggested guidelines, added to our 'Contributing' section?
--
Thanks,
Maxim
next prev parent reply other threads:[~2024-07-01 14:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 23:04 Codifying/Documenting Guix commit message conventions? Richard Sent
2024-06-28 8:59 ` Andreas Enge
2024-06-29 1:11 ` Maxim Cournoyer
2024-06-29 1:42 ` Richard Sent
2024-06-29 6:51 ` Liliana Marie Prikler
2024-06-30 1:11 ` Maxim Cournoyer
2024-06-30 6:25 ` Liliana Marie Prikler
2024-07-01 14:14 ` Maxim Cournoyer [this message]
2024-07-01 22:17 ` Richard Sent
2024-07-02 2:20 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734ot8ahw.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=guix-devel@gnu.org \
--cc=liliana.prikler@gmail.com \
--cc=richard@freakingpenguin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.