From: Sharlatan Hellseher <sharlatanus@gmail.com>
To: guix-devel@gnu.org
Subject: Update default Golang version on go-team branch
Date: Mon, 15 Jul 2024 12:28:56 +0100 [thread overview]
Message-ID: <8734oaq4g7.fsf@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 2521 bytes --]
Hi Guix!
I had a courage to refresh the default Goang version to build packages
from 1.17 to 1.21 as all version before it are already EoL. After
rebuilt 900+ packages locally I've fixed some failing to build packages.
The packages in golang-build were refresh as well which involve to
rebuild about 1000+ packages depending on them.
The changes are pushed to go-team brunch to check any other failures.
My plan is to continue shifting packages from golang.scm to dedicated
submodules which may boost maintainability of Golang ecosystem.
I'd like to highlight a "feature" of the `go:embedded` build option
which fails to archive during build without this hack:
--8<---------------cut here---------------start------------->8---
;; FIXME: Pattern embedded: cannot embed directory embedded:
;; contains no embeddable files.
;;
;; This happens due to Golang can't determine the valid directory of
;; the module which is sourced during setup environment phase, but
;; easy resolved after coping to expected directory "vendor" within
;; the current package, see details in Golang source:
;;
;; - URL: <https://github.com/golang/go/blob/>
;; - commit: 82c14346d89ec0eeca114f9ca0e88516b2cda454
;; - file: src/cmd/go/internal/load/pkg.go#L2059
(add-before 'build 'copy-input-to-vendor-directory
(lambda* (#:key import-path #:allow-other-keys)
(with-directory-excursion (string-append "src/" import-path)
(mkdir "vendor")
(copy-recursively
(string-append
#$(this-package-native-input "go-github-com-charmbracelet-glamour")
"/src/github.com")
"vendor/github.com")
(copy-recursively
(string-append
#$(this-package-native-input "go-github-com-alecthomas-chroma-v2")
"/src/github.com")
"vendor/github.com"))))
(add-before 'install 'remove-vendor-directory
(lambda* (#:key import-path #:allow-other-keys)
(with-directory-excursion (string-append "src/" import-path)
(delete-file-recursively "vendor")))))))
--8<---------------cut here---------------end--------------->8---
It might need some adjustment to go-build-system.
Related issues:
- https://issues.guix.gnu.org/71011
--
Oleg
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next reply other threads:[~2024-07-15 11:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 11:28 Sharlatan Hellseher [this message]
2024-07-21 13:09 ` Update default Golang version on go-team branch Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734oaq4g7.fsf@gmail.com \
--to=sharlatanus@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.