From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 0GdIG0BG22ZGlAAAqHPOHw:P1 (envelope-from ) for ; Fri, 06 Sep 2024 18:13:20 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id 0GdIG0BG22ZGlAAAqHPOHw (envelope-from ) for ; Fri, 06 Sep 2024 20:13:20 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=NkgIpfd5; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=kW23tWEv; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1725646400; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=BU5hiHRCan9f/8xNxLfLEEkW1+EpdsgnkSo/CS9fQGQ=; b=I2BGVdj3iu5BLGqlrdKpsZwH28b+mgcXcFoa2OMBXYdY4k0rLsFVoVipu9mkDY1dlGXADE rKGYr9OZIy7i/Z5w+6KT6uBY96rMNlYnItNX7r4adbofVsRSw74chBrEs6mDb4hb2Wf/iT WoHtvXJVwfw1aVxmv30vBNFUh9NJhLDqsOxKsHn+yU0IdmtjLesaNQX1HafDHYcrGZGfYc z9rn1FM4zl9ke4mCCZ+GRqFKIz6/vIg9WGZB7GUCxZvWYyadyTWYHVau0Jwib+tCSGlE9P 8Wd/HRhv8uE3p7Jh3Z6pgUAhKkIt0jCNWknll3Opf24km1V0yn0ivgiELUxasA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=NkgIpfd5; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=kW23tWEv; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1725646400; a=rsa-sha256; cv=none; b=aMz7Hdcj4EEXarTLStHuQQqW9dpJ4bm7Fv6TF+Xko4OVOX2PAKd4pam0JrPtfCH9CAceWE 1SZEU21aUPB87h/lJMs+H1ETqPQDn6Rwe/Bjhwy5O9h7juZ2Ii4Z15x6HQCtLCP4b1yV2s qrYDmaGuJKjFib7/qPhkifAzaQOQc6t4JwTMzE6bR3ci/+AcVoBGR3QE79c80V4LgIAKGc cySbFbd+PohNYIUx1zfqqFGBSk7ezSbejn7ouOmhWVe8FjM1IFYUCh/RFcURUbjAMzP3n5 vloOzhbHQ8wDsnlGBx0lnwZrkJYCIrS5S4xx99rOw/aMXsFhnJiznYBEO6MfJA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E99BC746F0 for ; Fri, 06 Sep 2024 20:13:19 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1smdSE-0000YE-Q4; Fri, 06 Sep 2024 14:13:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smdSA-0000FR-Mz for guix-patches@gnu.org; Fri, 06 Sep 2024 14:13:02 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1smdSA-0005ck-DN for guix-patches@gnu.org; Fri, 06 Sep 2024 14:13:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=BU5hiHRCan9f/8xNxLfLEEkW1+EpdsgnkSo/CS9fQGQ=; b=NkgIpfd5UjSQ6lZSeAKCE4KH6ZtDKqdOLNQ4QYQ2bZGgYIqc2a9DI09IECMWGXe8rjA4a4316fhakyU9ED3iURqdLDfXorTRm6kLkV6QW7UFwlomFrrB/vW130FdT+QCzk7jsaud4SFRmDk441R4fJVRAV402S/O3ZxnBbybWcbEjcsQu7OK/FYx2ii1rNGW2y5kIQue6F/Bh+q2JOnkIz4BKGuCs8ARYUz9KzrWZfNLbHQRaCiqZ932TF9pVzJiT8Y739eHdmlTlKyxFla+mgBe9vvcMfek5nXePt63Yy7NqMy7g6qXWfAXxRgoxUIHkIxXL8j/E5KWT+DUrcGfqw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1smdSA-0006xS-2c for guix-patches@gnu.org; Fri, 06 Sep 2024 14:13:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#73073] [PATCH 4/6] gnu: gnome-recipes: Move libgd origin from phases to native-inputs. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 06 Sep 2024 18:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73073 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler , 73073@debbugs.gnu.org Cc: Vivien Kraus , Maxim Cournoyer Received: via spool by 73073-submit@debbugs.gnu.org id=B73073.172564636826703 (code B ref 73073); Fri, 06 Sep 2024 18:13:02 +0000 Received: (at 73073) by debbugs.gnu.org; 6 Sep 2024 18:12:48 +0000 Received: from localhost ([127.0.0.1]:54154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smdRw-0006wd-4w for submit@debbugs.gnu.org; Fri, 06 Sep 2024 14:12:48 -0400 Received: from mail-wm1-f44.google.com ([209.85.128.44]:59553) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smdRt-0006wN-Pb for 73073@debbugs.gnu.org; Fri, 06 Sep 2024 14:12:46 -0400 Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-42ca4e0299eso6049755e9.2 for <73073@debbugs.gnu.org>; Fri, 06 Sep 2024 11:12:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725646300; x=1726251100; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=BU5hiHRCan9f/8xNxLfLEEkW1+EpdsgnkSo/CS9fQGQ=; b=kW23tWEvSvki1I09ofwGIIxy/2a/lVePq0kGKPuo6rsdSnqbDeyMzI4ZhD9QwQo6pl UDjoX0sb9jkO21yNh5Tc5nR/dtswPHz9CD4WXWmsa2EFJB/Q9xDfVxJfAKQ6C6w20Mus RH1G9WghRGx0Ew4dRco/lbo9Ba5qvSiaC1SnQB1qZ9al9M2nVhCjfk1ZhO2N1uiiQdib Q02Kr04xQYtPSi9AhYEHLRrotOrYWq2wQYHsqv/9uj9phFA1QmA+2Yx478qFbQbHitb/ 8iKqZGqCJBb0IaXXkrcBE7RJtTAGQoYtK0pQM/xt+PuamrTieLWxHCpPRAWURE88J6KR NZRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725646300; x=1726251100; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BU5hiHRCan9f/8xNxLfLEEkW1+EpdsgnkSo/CS9fQGQ=; b=OwqdKAJoeurglc6UgFm606lafUsnqzia6QuC8pJxQQBNcQkMcCLh9n1Hq5uM1bnslz orokQ4FZRY94zxMShGgS9tABKaw1YL/MbVLyzf7OmQSTP3LG7GYECckK0YxTmxr595En lORPfqVSZOO+xRWwtCpZeMhLYIQdKzvaYdVU6dajqBJpoU5LuVX8/LGf8907BSr3ldYz ThSuXEa2ECgJoCBRmJERuENOK8coQBFhPxfQGKPmHpYMXqDTS8U4KIs4mCJIjR3wAgI4 tgacYQlB9bp8Aw6v5iRzGomX9mWglhWUuoKTct+OvvkxfdI7bJZVlU93tPbzT9Pa66d8 AEPQ== X-Forwarded-Encrypted: i=1; AJvYcCWjBeEjPmvlJ/YqIMqLXh7eOGGHepECNspTlwjFSCj/ibeg3sR2T4Hmx1uVEdAAaBBmyNV1Hg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxShLDvKHbcSaBlAyuin/J5cuQJL0oFjFy821iJ0xmDMK4Afffm AxP0fT8urXtX2py/98ZqvV5XWS9kjrO1zpAkkyU+Cx6UvHlxhQu/ X-Google-Smtp-Source: AGHT+IGu+Ba4+SvG0T4P+MA/jyQuuKFbC3moJW7whyptry8T+2cP55G2D/HXV3M7m+hetflEDcWhog== X-Received: by 2002:a5d:4991:0:b0:368:5bb4:169b with SMTP id ffacd0b85a97d-378926858b2mr60510f8f.4.1725646299691; Fri, 06 Sep 2024 11:11:39 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:34c8:9fc9:674c:115f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3789164f990sm455169f8f.81.2024.09.06.11.11.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Sep 2024 11:11:39 -0700 (PDT) From: Simon Tournier In-Reply-To: References: <4b84954a845391197ebbdbb7f5c9d04eb3ecdc7f.1725636992.git.zimon.toutoune@gmail.com> Date: Fri, 06 Sep 2024 20:11:27 +0200 Message-ID: <8734mcire8.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: E99BC746F0 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -8.92 X-Spam-Score: -8.92 X-TUID: wmLtXlYuB+47 Hi Liliana, My aim is not to mix, under =E2=80=99inputs=E2=80=99 record field, the old = style (label) with the new style (no label) but to have the =E2=80=99origin=E2=80=99 insi= de =E2=80=99inputs=E2=80=99 and not inside =E2=80=99arguments=E2=80=99. On Fri, 06 Sep 2024 at 19:33, Liliana Marie Prikler wrote: > I can see why you're doing that, but I'm not really convinced it helps > the package. As I wrote in the cover letter: This is annoying because these origins are hidden from =E2=80=99package-direct-sources=E2=80=99; see module (guix packages= ). So it helps the package. ;-) Please note that the docstring of =E2=80=99package-direct-sources=E2=80=99 = is currently lying. ;-) Well, the situation is a bug, IMHO. --8<---------------cut here---------------start------------->8--- "Return all source origins associated with PACKAGE; including origins in PACKAGE's inputs and patches." --8<---------------cut here---------------end--------------->8--- > IMHO, G-Expressions in phases serve in part to facilitate uses like > this. I agree that G-exps facilitate manipulation of store paths. But using =E2=80=99origin=E2=80=99 inside arguments appears to me as an abuse of the = feature. As I wrote in the cover letter: Moreover and tangentially, it appears to me an anti-pattern of the functional paradigm: The data from the impure outside should be han= dled by the =E2=80=99source=E2=80=99 record field, or otherwise by =E2= =80=99inputs=E2=80=99, =E2=80=99native-inputs=E2=80=99 or =E2=80=99propagated-inputs=E2=80=99 record fields; let say only = =E2=80=99inputs=E2=80=99 for simplicity. Therefore, I strongly think =E2=80=99origin=E2=80=99 should not be inside a= rguments. Somehow, my submission is a proposal for dealing with the case. And it=E2=80=99s not really if it needs to, or should, be done. :-) > Particularly, we're now even adding a labeled input, > which makes for a cursed situation where all but one inputs are > unlabeled=C2=B9. Please note it=E2=80=99s a specific inputs: it=E2=80=99s an =E2=80=99origin= =E2=80=99. This can be checked by the pattern matching, e.g., (((? string? label) (? origin? o) ;Allow old style as sometimes require= s by origin in inputs `(,label ,o)) Other said, it would not be a =E2=80=9Ccursed situation=E2=80=9D; only a si= tuation using a locally defined input. Cheers, simon