From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 4E70Dtxx4GZUDgEA62LTzQ:P1 (envelope-from ) for ; Tue, 10 Sep 2024 16:20:44 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id 4E70Dtxx4GZUDgEA62LTzQ (envelope-from ) for ; Tue, 10 Sep 2024 18:20:44 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=CCO1Ervv; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=CEYIJnlp; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1725985244; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=90ko/e6TXXQXxoIJzJvkDCXZLgAt/jWj5tlqesJdksA=; b=Ab42L8qNhipMxfilKLPblhlkNRCPS0Fxlf7HaP5fubRjWjWwsYQv3qr8r8mXHZYWd6fqCb Kxv4M8h8V9cEvY2UZrkt7uAx9ZZN97hUIF7rOT7WRHOtM/+GrOSZvOyTSZB86GyBOIR+XU 6xlo7Esuw5PGcxwWc73CkVkaEWUvi6vifAR0LCk960QXhEgAKe6hQNejs7aYEYyS0SuKpP 8QBYMBXTElihxoeuYBdmAYhMM5AWGJ3KLQnRI7hnsARqzlSi2CcM6m6h8e7o47+3w6Pldt iICRY43+O2Vhnm+I6YYvhGIYVwSdE7+GVMKuCsjJ0XdeYecw4wbhBz1QA41vNA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1725985244; a=rsa-sha256; cv=none; b=IkJsq0xyjEZcPqKneIr+ySg12eceN9/GfLOByTrzbx4pfHjMk7gE7BDszDIwGA/w7V1Q8n WRzKmwIh65awENGyhH/QoJa88/QNF5/DVmZsWwADcrE7RMIhQQjN53tU39dPQClAbUH9CM 2+siEOtpLkXqG8SGGnry6vbHm3x9razG8+WYP4Zqs5V3El2SwZkfMzykq5yquamlbJbIkR hLahxnIfruBAztDSI39g0b02cLsTmSyZThFHxmai2Bve/18SZ0MZqjiXwFZqi1fKi+kJwn C6CiVyn9kf27Kzg9sWIA+TpC577pRJs1FzcL3X28fo2dbNqS5/BpUgI8Ftmrhw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=CCO1Ervv; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=CEYIJnlp; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D09791C7E1 for ; Tue, 10 Sep 2024 18:20:43 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1so3bB-0000dV-V2; Tue, 10 Sep 2024 12:20:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1so3ay-0000RY-EQ for guix-patches@gnu.org; Tue, 10 Sep 2024 12:20:03 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1so3ax-0004IR-2Q for guix-patches@gnu.org; Tue, 10 Sep 2024 12:20:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=90ko/e6TXXQXxoIJzJvkDCXZLgAt/jWj5tlqesJdksA=; b=CCO1ErvvxWzhTMLaOuvdzVd6QZKfAKmScTfi1zkZOu6Ka8C0yGju8/L6nKtKJnEIuUodvvU48MSOt0Hm8TOQSneZ+zbqPCN1AEOy88Jvj9dH6wgYFnZA/Al5zHdhFLKOLJDoI99gOzTnRHLNUt8edGmZuzX6r/6AYgo3hE6mpIAp4dW1qetzn8i97NqenwNPgIKA3hACduh1YtgQxAIYyNLIntvLKILa42ddfuW/1vByIMX70Niy7+v/qQXAT4NjvRznxYuClzbHQ4Y84OsVEbhqNzdONGyOjeu/aNgZa7TPGsc0fGSnmB+NktPJvUhxB7eFo/MroUiMfEzCq4rIOQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1so3b2-0004bH-59 for guix-patches@gnu.org; Tue, 10 Sep 2024 12:20:04 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#69827] [PATCH 1/3] build-system/go: Add subdir parameter to go-version->git-ref. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 10 Sep 2024 16:20:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69827 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sharlatan Hellseher , 69827@debbugs.gnu.org Cc: "Artyom V. Poptsov" , Stephen Webber , Timo Wilken Received: via spool by 69827-submit@debbugs.gnu.org id=B69827.172598514117283 (code B ref 69827); Tue, 10 Sep 2024 16:20:04 +0000 Received: (at 69827) by debbugs.gnu.org; 10 Sep 2024 16:19:01 +0000 Received: from localhost ([127.0.0.1]:36659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1so3a0-0004UW-Vp for submit@debbugs.gnu.org; Tue, 10 Sep 2024 12:19:01 -0400 Received: from mail-wm1-f44.google.com ([209.85.128.44]:43256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1so3Zz-0004UF-3f for 69827@debbugs.gnu.org; Tue, 10 Sep 2024 12:18:59 -0400 Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-42cb58d810eso15101265e9.0 for <69827@debbugs.gnu.org>; Tue, 10 Sep 2024 09:18:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725985068; x=1726589868; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=90ko/e6TXXQXxoIJzJvkDCXZLgAt/jWj5tlqesJdksA=; b=CEYIJnlpT+kJocZobTWPYP8+ftgF70fmbRX8kOb5QGOioyAwhnhQW2EqB5T5QrvlXH il7BEeyv0TZtYt7Ns1i5DTIvY+NqGVJuS6tKd5n2JYljC3TFjXf/hFTK0f/3J2KmDI2u DQa2S66HxDTNTWJV4oYo8+Cc9RWUTw+vEKvEOOOKHecFOhycEPMh1AXWGhhuP7TqOlr6 nJ4/p7C4lVIBid25oa2GeXYp1xTI+DXbMgVzdSdgj/jEwOFDcDAtFiaQCHSIhI0X/zZ/ mRZ6NFgrZxSKY1Yhi1Qmim245pLH2lwi2rYHtwFUTeDC0+50MiWvvGtb8AQBwMB3LTfj rxOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725985068; x=1726589868; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=90ko/e6TXXQXxoIJzJvkDCXZLgAt/jWj5tlqesJdksA=; b=o68FGJr8PV4CfquSl4UbcPzUgDehatOLjU1cwRXyvVC3ofqWA5KhH+/wywAFcJ/Yxp whjxZlhDq/rhmc/XWY/6Bmj4HYrBUHKF9qiqULJzZCc2VKlDFUh0TypGtg2frN6tI6Lx FckDJUZAW7n9ugrax5tT29bOg0DtXGq49XnrM1EgvqW802apORlfbii0wlhy/cF0AksN ojD7k/xwe/NguaMQacZ81VM+71QiSBXJVOirVf+VOLtMHYYnTtd2QcdlCsLKAYTZefg2 UHRoFhrIsOvPgv5r8AGqXN+pm0T8EKg7j5Vpf+FVLbsPTQyDpHRJhz8hpMIVh3lKM/tK AFwQ== X-Forwarded-Encrypted: i=1; AJvYcCX5nWyg0hqupR4OY8sgjuQxqdYZWmMONB8gHNybxxB8y0N4sP+t/c99HQK2uo/n3jVGnRTGsw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxRuVGn5ohQITKf7/rL+O6/pzHUea7m2otGyYhk8SuN6KYrQYsW 5GTVgaRY9VJ3j7wttk6fyktOnd8m5+1TLzvRs0RK28aviwrqg7fv X-Google-Smtp-Source: AGHT+IHDSJ/4pOua62/mjmatMwbf7LjI2tV9LW73k+3it05n4QcmRBYq4d2mamfj9cl0Lak0ceTQCA== X-Received: by 2002:a05:600c:3b9c:b0:42c:b332:1619 with SMTP id 5b1f17b1804b1-42cbddb7904mr23549995e9.2.1725985067624; Tue, 10 Sep 2024 09:17:47 -0700 (PDT) Received: from lili (roam-nat-fw-prg-194-254-61-40.net.univ-paris-diderot.fr. [194.254.61.40]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-378956d363asm9409821f8f.72.2024.09.10.09.17.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Sep 2024 09:17:47 -0700 (PDT) From: Simon Tournier In-Reply-To: <87tterfsi3.fsf@gmail.com> References: <87tterfsi3.fsf@gmail.com> Date: Tue, 10 Sep 2024 14:21:49 +0200 Message-ID: <8734m7g0ma.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: D09791C7E1 X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -8.92 X-Spam-Score: -8.92 X-TUID: tiIrXg4OkyJA Hi Oleg, Thanks for taking care about the unmerged patches. :-) On Sat, 07 Sep 2024 at 15:28, Sharlatan Hellseher w= rote: > - <2023-05-22> [PATCH 0/2] Fix annoyance with "guix import go" > by Simon Tournier > [...] > May we come to some consensus and apply some median patch including all > proposals and fixing the currently issue with import golang modules with > subdirs? Well, from my perspective, patch#63647 was ready but since I am not really using =E2=80=9Cguix import go=E2=80=9D, I do not feel qualified to k= now what is better: error out at the first Git issue and continue with a wrong hash. Somehow, what appears to you the better answer of: I thought it would be more appropriate to error out as soon as we h= ave a Git problem, rather than print a warning and emit an incorrect hash. I understand that, when using =E2=80=98--recursive=E2=80=99, this m= eans aborting the whole process without producing anything. But maybe that=E2=80=99s= better that producing an incorrect (origin =E2=80=A6) form? My intuition is not to abort the whole process and instead get something where I manually fix these incorrect hashes. When I had to do it, it had been far easier and faster than looping over =E2=80=9Cguix import go=E2= =80=9D. In other words, =E2=80=9Cguix import go foo -r=E2=80=9D and paste the outpu= t in one file, then run =E2=80=9Cguix build foo=E2=80=9D and fix the incorrect hash = origins or some other package tweaks. I have not looked into the other patches; if they fix similar issues, Cheers, simon 1: [bug#63647] [PATCH 0/2] Fix annoyance with "guix import go" Ludovic Court=C3=A8s Tue, 06 Jun 2023 17:42:00 +0200 id:87zg5c61iv.fsf@gnu.org https://issues.guix.gnu.org/63647 https://issues.guix.gnu.org/msgid/87zg5c61iv.fsf@gnu.org https://yhetil.org/guix/87zg5c61iv.fsf@gnu.org