all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: get-state <mazin@getstate.dev>
Cc: "Wiktor Żelazny" <wz@freeshell.de>,
	"Sharlatan Hellseher" <sharlatanus@gmail.com>,
	"Munyoki Kilyungi" <me@bonfacemunyoki.com>,
	74057-done@debuggs.gnu.org, "Lars-Dominik Braun" <lars@6xq.net>,
	74057@debbugs.gnu.org, =guix-patches@gnu.org,
	"Marius Bakke" <marius@gnu.org>,
	"Tanguy Le Carrour" <tanguy@bioneland.org>,
	jgart <jgart@dismail.de>
Subject: [bug#74057] [PATCH v2 1/1] gnu: Add python-green.
Date: Fri, 01 Nov 2024 22:58:46 +0900	[thread overview]
Message-ID: <8734kb12eh.fsf@gmail.com> (raw)
In-Reply-To: <fb85e245bccdcb3b2a66beb454d3abc716cbd6e3.1730424294.git.mazin@getstate.dev> (get-state's message of "Fri, 1 Nov 2024 04:27:14 +0300")

Hi,

get-state <mazin@getstate.dev> writes:

> From: Wiktor Żelazny <wz@freeshell.de>
>
> * gnu/packages/python-check.scm (python-green): New variable.
>
> Change-Id: I554e8a635ff51413c79e3834fc1b88b34bbda84b
> Signed-off-by: get-state <mazin@getstate.dev>

This is a cool collaboration :-).  I believe the correct trailer to
denote a review should be 'Reviewed-by: ...'.

> ---
>  gnu/packages/python-check.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/python-check.scm b/gnu/packages/python-check.scm
> index ba66b081a5..3d181c8f7e 100644
> --- a/gnu/packages/python-check.scm
> +++ b/gnu/packages/python-check.scm
> @@ -3003,3 +3003,27 @@ (define-public python-vulture
>  dead code.  Also, code that is only called implicitly may be reported as
>  unused.")
>      (license license:expat)))
> +
> +(define-public python-green
> +  (package
> +    (name "python-green")
> +    (version "4.0.2")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "green" version))
> +       (sha256
> +        (base32 "1cd62nbn5dvlpnsyplp6cb24wd230san8dpm6pnl99n2kwzpq1m4"))))
> +    (build-system pyproject-build-system)
> +    ;; python-coverage both in requirements.txt and requirements-dev.txt
> +    (propagated-inputs (list python-colorama python-coverage python-lxml
> +                             python-unidecode))
> +    (native-inputs (list python-black python-django python-mypy
> +                         python-testtools))
> +    (home-page "https://github.com/CleanCut/green")
> +    (synopsis "Clean, colorful, fast python test runner")
> +    (description
> +     "@code{green} is a python test runner which in addition to
> +being clean, colorful and fast describes itself as powerful, traditional,
> +descriptive, convenient, thorough, embedded, modern, portable and living.")
> +    (license license:expat)))

I've capitalized Python, adjusted the trailer and did a few improvements
to the description/style:

--8<---------------cut here---------------start------------->8---
1 file changed, 32 insertions(+), 9 deletions(-)
gnu/packages/python-check.scm | 41 ++++++++++++++++++++++++++++++++---------

modified   gnu/packages/python-check.scm
@@ -3015,15 +3015,38 @@ (define-public python-green
        (sha256
         (base32 "1cd62nbn5dvlpnsyplp6cb24wd230san8dpm6pnl99n2kwzpq1m4"))))
     (build-system pyproject-build-system)
-    ;; python-coverage both in requirements.txt and requirements-dev.txt
-    (propagated-inputs (list python-colorama python-coverage python-lxml
-                             python-unidecode))
-    (native-inputs (list python-black python-django python-mypy
-                         python-testtools))
+    (native-inputs
+     (list python-black
+           python-django
+           python-mypy
+           python-testtools))
+    ;; The python-coverage dependency appears both in requirements.txt and
+    ;; requirements-dev.txt.
+    (propagated-inputs
+     (list python-colorama
+           python-coverage
+           python-lxml
+           python-unidecode))
     (home-page "https://github.com/CleanCut/green")
-    (synopsis "Clean, colorful, fast python test runner")
+    (synopsis "Clean, colorful, fast Python test runner")
     (description
-     "@code{green} is a python test runner which in addition to
-being clean, colorful and fast describes itself as powerful, traditional,
-descriptive, convenient, thorough, embedded, modern, portable and living.")
+     "@code{green} is a Python test runner that describes itself as:
+@table @emph
+@item Clean
+Low redundancy in output.  Result statistics for each test is vertically aligned.
+@item Colorful
+Terminal output makes good use of color when the terminal supports it.
+@item Fast
+Tests run in independent processes (one per processor by default).
+@item Powerful
+Multi-target and auto-discovery support.
+@item Traditional
+It uses the normal @code{unittest} classes and methods.
+@item Descriptive
+Multiple verbosity levels, from just dots to full docstring output.
+@item Convenient
+Bash-completion and ZSH-completion of options and test targets.
+@item Thorough
+Built-in integration with @url{http://nedbatchelder.com/code/coverage/, coverage}.
+@end table")
     (license license:expat)))

[back]
--8<---------------cut here---------------end--------------->8---

And pushed as commit 08dc72473b.

Thanks to both of you!  Closing.

-- 
Maxim




      reply	other threads:[~2024-11-01 14:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-28 10:31 [bug#74057] [PATCH] gnu: Add python-green Wiktor Żelazny
2024-11-01  1:27 ` [bug#74057] QA for 74057 get-state
2024-11-01  1:27   ` get-state
2024-11-01  1:35     ` get-state
2024-11-01  1:35     ` [bug#74057] [PATCH v2 1/1] gnu: Add python-green get-state
2024-11-01 13:58       ` Maxim Cournoyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8734kb12eh.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=74057-done@debuggs.gnu.org \
    --cc=74057@debbugs.gnu.org \
    --cc==guix-patches@gnu.org \
    --cc=jgart@dismail.de \
    --cc=lars@6xq.net \
    --cc=marius@gnu.org \
    --cc=mazin@getstate.dev \
    --cc=me@bonfacemunyoki.com \
    --cc=sharlatanus@gmail.com \
    --cc=tanguy@bioneland.org \
    --cc=wz@freeshell.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.