From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id UCcqJznEWmebKQAA62LTzQ:P1 (envelope-from ) for ; Thu, 12 Dec 2024 11:08:41 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id UCcqJznEWmebKQAA62LTzQ (envelope-from ) for ; Thu, 12 Dec 2024 12:08:41 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=jAPwUUla; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=VLPwYg0J; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1734001721; a=rsa-sha256; cv=none; b=el0VS98jqT0q8DmMNBT5+wq+1PaWcyQgXpf0RNneAu5s6jMoOxiEvhalxfKlt/VN0LHxws S98ZLbJyZ1R8t7ypmMktfJaLV25BiE8r6x2NvLWJVRGdXtxlBkvsT2CKiqWPFjzICp3TMO pi7owWGXzm67GzM5ig8jP5aityYcyCmVkVvkdx91maBlxQZgb9yEDtqcjm4Yd+HjHJbOhH 1AtjomQguhZVs6o6+ByOOsXOlZE77O0GUS0EOkiqDQjA+Ijm9SUnO+14dnrimLRBBWQ6Pt XTlOr/wJFNYnyftsnkXfY22fdiWu0bCmw5nt8SRMZ1BubAN6xu/aZhulBGbhEA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=jAPwUUla; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=VLPwYg0J; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1734001721; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=bTpD6gGidPoXDzXTOP/aLsIG51Xr6uxeHXH+JRfl65M=; b=GdMKq+5TOOYhY8epstqnuLS98U8hHe42vi/HRlBjSk6o38Srf8ieq4qb5bAcyAnBr4qqjp hXq/WLW0rkhp63GqNEFGCf6acJEULjYF+ZCEAksRylzI+wXiFpQ2O6Q5M6S6ND91oG/T/y USzPQLe7G+YI6FQMZY+AWgNqqh+cK9cSauC2zi+ejn+3+AVGGf8u0i11/w+RBqQQ3LbTBW u60h/IBuDeNckP7dnnd2pLK39ig+dCGqtADbPK1ib8JiD1Rslx02Id85qFTBAaRJHv98CF rMBKI0UY+U9au58Lv/63SQhxYp7/Dm5Go5NwkeV372Qyy8ppCADHpsRpZdqlww== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 46A397B9E6 for ; Thu, 12 Dec 2024 12:08:41 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tLh37-0002iO-QF; Thu, 12 Dec 2024 06:08:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLh35-0002ho-R3 for guix-patches@gnu.org; Thu, 12 Dec 2024 06:08:03 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tLh35-00047U-Gt for guix-patches@gnu.org; Thu, 12 Dec 2024 06:08:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=bTpD6gGidPoXDzXTOP/aLsIG51Xr6uxeHXH+JRfl65M=; b=jAPwUUlaAyiX6xsMTMtdM7lbtDz2o+uWpGyTK5Mkj234bX+UztbjRzaGCzKXR0ThA/+Eb9fkusNWbOIhNudl4LovXQ1A7JZneBAVsINe84PnqVlHMdPY5pJrBWnleuj8A8E+jbDbtuYaAqtxQHJLHYsGKlg0f4Gk62mhD/bYsdUgM9w+M9NFYO1zcnV7336QjGeT4yHAdsY2A6NdSbGMNmlolc3e1iSL1OK2zyM62ECf4jZ7ra3yPnQeG39mtSwBcYgI6RvZbE0dZYfCxy+c3nyHDW9Vpe1tjIWtTLIST+91xVbx39bQkwJL0G6oQ8DObp1zyFy2sFb2tl6a40KwdQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tLh35-0000sM-6m for guix-patches@gnu.org; Thu, 12 Dec 2024 06:08:03 -0500 Subject: bug#74459: comments Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Thu, 12 Dec 2024 11:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 74459 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Gabriel Wicki Cc: 74459-done@debbugs.gnu.org Mail-Followup-To: 74459@debbugs.gnu.org, ludo@gnu.org, gabriel@erlikon.ch Received: via spool by 74459-done@debbugs.gnu.org id=D74459.17340016773338 (code D ref 74459); Thu, 12 Dec 2024 11:08:02 +0000 Received: (at 74459-done) by debbugs.gnu.org; 12 Dec 2024 11:07:57 +0000 Received: from localhost ([127.0.0.1]:37847 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLh2y-0000rm-Lk for submit@debbugs.gnu.org; Thu, 12 Dec 2024 06:07:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLh2w-0000rY-Sq for 74459-done@debbugs.gnu.org; Thu, 12 Dec 2024 06:07:55 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLh2o-00046B-RS; Thu, 12 Dec 2024 06:07:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=bTpD6gGidPoXDzXTOP/aLsIG51Xr6uxeHXH+JRfl65M=; b=VLPwYg0JvtFWmDA1TTz1 1M+i3wSdY6SCndbVXMfedEVNZBdmMaFZ/acawRbi/H3xCCEbIurLwSo1xqC0XVMK9pxYCXBDlIgBr +NbHEZ/0KNqrdTAqZRWVgP+fl2Gtn7sftDM0ZSddc8+uIE4JuxsWqF4Tpxg1aMk9aY8T7vi/0dhDA FZIQ8N4MSufIC5gF1tsDslRBsdhcdnZP7w8KMghubX9Rtzqqg10X78SWjm805s2TDXNWw3R9kXoX0 7qBEkGk5CHZ2d4LHri0W271WTFbKgmtBSr7S2CXDULzLy9oYjo+ZuXFKA1/z2F7v2QATwW8tXMTpd rj+QLeSJnLje1Q==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: (Gabriel Wicki's message of "Mon, 2 Dec 2024 23:46:09 +0100") References: <87zfliywiw.fsf@gnu.org> Date: Thu, 12 Dec 2024 12:07:41 +0100 Message-ID: <8734itcg76.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 46A397B9E6 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -3.67 X-Spam-Score: -3.67 X-TUID: 5BXw1wQznOar Hi, Gabriel Wicki skribis: > Thanks for your review, Ludo'! I've addressed your concern and came up > with an even more readable solution -- I hope you agree. Yes, that=E2=80=99s nice. Applied, thanks! I removed =E2=80=9Cguix:=E2=80=9D from commit subject lines and also follow= ed up with a commit that pre-compiles the regexp instead of recompiling it every time via =E2=80=98string-match=E2=80=99 (it can make a difference when linting a= large number of packages as is the case in the Data Service for example). Thanks! Ludo=E2=80=99.