From: ludo@gnu.org (Ludovic Courtès)
To: Nikita Karetnikov <nikita@karetnikov.org>
Cc: bug-guix@gnu.org
Subject: Re: 'python-build-system'
Date: Mon, 29 Apr 2013 13:42:58 +0200 [thread overview]
Message-ID: <871u9tlfzx.fsf@gnu.org> (raw)
In-Reply-To: <87obcym1vj.fsf@karetnikov.org> (Nikita Karetnikov's message of "Mon, 29 Apr 2013 07:50:24 +0400")
Nikita Karetnikov <nikita@karetnikov.org> skribis:
>> Yes, definitely. But that’s not a problem: these scripts are most
>> likely unused during the build process and afterward.
>
> So, should I package it (without replacing shells)?
No, no need for zsh here, AFAICS.
>>> * guix/build/utils.scm (wrap-program): Assume that 'prog' is an
>>> absolute filename. Adjust 'prog-real' and 'prog-tmp' accordingly.
>>> Also, change 'prog-tmp' to honor command line arguments.
>
>> What was wrong with the previous approach? I don’t like the “assume
>> it’s an absolute file name” bit, because we don’t know whether the
>> assumption holds.
>
> Well, have a look at this snippet:
>
> + (for-each (cut wrap-program <> var)
> + files)))
>
> Each 'file' here will have an absolute filename.
>
> I failed to make it work with the previous version.
Can you clarify what didn’t work exactly? It’s not clear to me.
>> You need double quotes around $@.
>
> Why should I add them?
So that argument expansion does not incur further splitting, in case of
arguments containing white space (info "(bash) Special Parameters").
>> You also need to keep (package-native-search-paths python). See commit
>> 35ac56b6, which fixed that for Perl & co.
>
> Could you elaborate? Why is it needed? Is it necessary to add
> 'python-search-paths'?
If you append (package-native-search-paths python) to the list of search
paths, then PYTHONPATH will automagically be defined appropriately (see
<http://lists.gnu.org/archive/html/bug-guix/2013-03/msg00158.html>.)
If you don’t, then PYTHONPATH will be undefined, unless you explicitly
define it in build/python-build-system.scm, which is not the recommended
option.
So just mimic the change made in the above commit for perl-build-system.
HTH,
Ludo’.
next prev parent reply other threads:[~2013-04-29 11:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-05 18:21 'python-build-system' Nikita Karetnikov
2013-04-07 10:34 ` 'python-build-system' Ludovic Courtès
2013-04-23 9:49 ` ERROR: missing interface for module (gnutls) (was: 'python-build-system') Nikita Karetnikov
2013-04-23 11:51 ` ERROR: missing interface for module (gnutls) Ludovic Courtès
2013-04-23 15:03 ` Nikita Karetnikov
2013-04-23 16:01 ` Ludovic Courtès
2013-04-27 15:14 ` 'python-build-system' Ludovic Courtès
2013-04-28 1:55 ` 'python-build-system' Nikita Karetnikov
2013-04-28 17:18 ` 'python-build-system' Nikita Karetnikov
2013-04-28 20:52 ` 'python-build-system' Ludovic Courtès
2013-04-29 3:50 ` 'python-build-system' Nikita Karetnikov
2013-04-29 11:42 ` Ludovic Courtès [this message]
2013-05-08 1:52 ` 'python-build-system' Nikita Karetnikov
2013-05-08 16:47 ` 'python-build-system' Ludovic Courtès
2013-05-08 23:22 ` 'python-build-system' Nikita Karetnikov
2013-05-09 20:29 ` 'python-build-system' Ludovic Courtès
2013-04-29 19:33 ` 'python-build-system' Ludovic Courtès
2013-04-30 15:04 ` 'python-build-system' Ludovic Courtès
2013-04-28 22:50 ` 'python-build-system' Cyril Roelandt
2013-04-29 11:50 ` 'python-build-system' Ludovic Courtès
2013-04-29 19:24 ` 'python-build-system' Cyril Roelandt
2013-04-30 13:47 ` 'python-build-system' Nikita Karetnikov
2013-05-06 21:07 ` 'python-build-system' Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871u9tlfzx.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=bug-guix@gnu.org \
--cc=nikita@karetnikov.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.