From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add Grue Hunter.
Date: Thu, 30 May 2013 13:53:59 +0200
Message-ID: <871u8oy97s.fsf@gnu.org>
References: <878v3hgxql.fsf@karetnikov.org> <8761ykl9xl.fsf@gnu.org>
	<87fvxn3b51.fsf@karetnikov.org> <87ppwqdgv2.fsf@gnu.org>
	<87zjvkpw6o.fsf@karetnikov.org> <877giozglk.fsf@gnu.org>
	<87d2sgwio8.fsf@karetnikov.org> <878v34xujn.fsf@gnu.org>
	<878v2xkuds.fsf_-_@karetnikov.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:56531)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Ui1Qs-0008PT-R9
	for bug-guix@gnu.org; Thu, 30 May 2013 07:54:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Ui1Qn-0000ZI-Rv
	for bug-guix@gnu.org; Thu, 30 May 2013 07:54:14 -0400
Received: from [2a01:e0b:1:123:ca0a:a9ff:fe03:271e] (port=59699
	helo=xanadu.aquilenet.fr) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Ui1Qn-0000WY-Jt
	for bug-guix@gnu.org; Thu, 30 May 2013 07:54:09 -0400
In-Reply-To: <878v2xkuds.fsf_-_@karetnikov.org> (Nikita Karetnikov's message
	of "Thu, 30 May 2013 07:40:31 +0400")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
To: Nikita Karetnikov <nikita@karetnikov.org>
Cc: bug-guix@gnu.org

Nikita Karetnikov <nikita@karetnikov.org> skribis:

>> See =E2=80=98package-from-tarball=E2=80=99 for an example, in bootstrap.=
scm.
>
> Thanks.  Can I push the attached patch along with this one [1,2]?

OK for [1].

Comments about the rest:

> Two questions, though:
>
> 1. Is it necessary to use 'begin' here?
>
> (begin
>   (mkdir out)
>   (copy-file tarball "grue-hunter.tar.gz")
>   ...)

Yes, because it=E2=80=99s a sequence of instructions.

> 2. I'd like to use
>
> (patch-shebang (string-append bin "/grue-hunter")
> 			   (list perl))

Should be (list (string-append perl "/bin")).

Free free to commit after that change if it works as expected.

> +    (synopsis "Text adventure game")
> +    (description
> +     "Grue Hunter is a text adventure game written in Perl.  You must ma=
ke
> +your way through an underground cave system in search of the Grue.  Can =
you
> +capture it and get out alive?")
> +   (license agpl3+)))

The indentation of =E2=80=98(license=E2=80=99 differs from the lines above.

Thanks,
Ludo=E2=80=99.