Re: [PATCH] gnu: Add Grue Hunter.

[ludo@gnu.org (Ludovic Courtès)]

Nikita Karetnikov <nikita@karetnikov.org> skribis:

>> See ‘package-from-tarball’ for an example, in bootstrap.scm.
>
> Thanks.  Can I push the attached patch along with this one [1,2]?

OK for [1].

Comments about the rest:

> Two questions, though:
>
> 1. Is it necessary to use 'begin' here?
>
> (begin
>   (mkdir out)
>   (copy-file tarball "grue-hunter.tar.gz")
>   ...)

Yes, because it’s a sequence of instructions.

> 2. I'd like to use
>
> (patch-shebang (string-append bin "/grue-hunter")
> 			   (list perl))

Should be (list (string-append perl "/bin")).

Free free to commit after that change if it works as expected.

> +    (synopsis "Text adventure game")
> +    (description
> +     "Grue Hunter is a text adventure game written in Perl.  You must make
> +your way through an underground cave system in search of the Grue.  Can you
> +capture it and get out alive?")
> +   (license agpl3+)))

The indentation of ‘(license’ differs from the lines above.

Thanks,
Ludo’.