From: ludo@gnu.org (Ludovic Courtès)
To: Nikita Karetnikov <nikita@karetnikov.org>
Cc: bug-guix@gnu.org
Subject: Re: [PATCH] gnu: Add Grue Hunter.
Date: Thu, 30 May 2013 13:53:59 +0200 [thread overview]
Message-ID: <871u8oy97s.fsf@gnu.org> (raw)
In-Reply-To: <878v2xkuds.fsf_-_@karetnikov.org> (Nikita Karetnikov's message of "Thu, 30 May 2013 07:40:31 +0400")
Nikita Karetnikov <nikita@karetnikov.org> skribis:
>> See ‘package-from-tarball’ for an example, in bootstrap.scm.
>
> Thanks. Can I push the attached patch along with this one [1,2]?
OK for [1].
Comments about the rest:
> Two questions, though:
>
> 1. Is it necessary to use 'begin' here?
>
> (begin
> (mkdir out)
> (copy-file tarball "grue-hunter.tar.gz")
> ...)
Yes, because it’s a sequence of instructions.
> 2. I'd like to use
>
> (patch-shebang (string-append bin "/grue-hunter")
> (list perl))
Should be (list (string-append perl "/bin")).
Free free to commit after that change if it works as expected.
> + (synopsis "Text adventure game")
> + (description
> + "Grue Hunter is a text adventure game written in Perl. You must make
> +your way through an underground cave system in search of the Grue. Can you
> +capture it and get out alive?")
> + (license agpl3+)))
The indentation of ‘(license’ differs from the lines above.
Thanks,
Ludo’.
next prev parent reply other threads:[~2013-05-30 11:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 19:36 Grue Hunter: Can't create directories in the store Nikita Karetnikov
2013-05-15 0:59 ` Cyril Roelandt
2013-05-15 12:11 ` Ludovic Courtès
2013-05-16 2:35 ` Nikita Karetnikov
2013-05-16 16:33 ` Ludovic Courtès
2013-05-24 9:24 ` Nikita Karetnikov
2013-05-24 12:51 ` Ludovic Courtès
2013-05-24 14:34 ` Nikita Karetnikov
2013-05-24 15:32 ` Ludovic Courtès
2013-05-30 3:40 ` [PATCH] gnu: Add Grue Hunter Nikita Karetnikov
2013-05-30 11:53 ` Ludovic Courtès [this message]
2013-06-03 3:18 ` Nikita Karetnikov
2013-06-03 10:14 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871u8oy97s.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=bug-guix@gnu.org \
--cc=nikita@karetnikov.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.